[Bug 30213] New: Hide Delete (aka Priority) column when user only has place_hold permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Bug ID: 30213 Summary: Hide Delete (aka Priority) column when user only has place_hold permission Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: sbrown@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com With the change to holds permissions in Bug 29540, the Delete (or Priority, with full holds permissions) column isn't useful and is misleading for users with only the place_hold permission. They don't have the option to change holds' priority using the column, and if they select 'del' on a patron to delete their hold, they get locked out for having insufficient permissions when they click the Update Hold(s) button. But this is misleading because they *can* delete an individual hold using the red X. It would be clearer if that entire column were hidden for users with only the place_hold permission. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, | |lucas@bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30207 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207 [Bug 30207] Librarians with only "place_holds" permission can no longer update hold pickup locations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131327&action=edit Bug 30213: Hide Delete (aka Priority) column when user only has place_hold permission This patch changes the way the priority column displays when viewing a list of holds as a user who doesn't have permission to change hold priority. To test: - Apply the patch and log into the staff interface as a user with at least "place_hold" permission. - Locate a record which can be put on hold and place multiple holds. - View the list of holds. - As a user with both "place_hold" and "modify_holds_priority" permission, you should see a "Priority" column with <select> fields allowing you to change hold priority. You should also see the arrow buttons for changing priority. - As a user with only "place_hold" permission, the "Priority" column should show the priority as a number. You should not see the arrow buttons. - In both cases, confirm that all operations work correctly: Changing hold date, expiration date, pickup library, suspended status; Cancelling holds. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131327|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 131336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131336&action=edit Bug 30213: Hide Delete (aka Priority) column when user only has place_hold permission This patch changes the way the priority column displays when viewing a list of holds as a user who doesn't have permission to change hold priority. To test: - Apply the patch and log into the staff interface as a user with at least "place_hold" permission. - Locate a record which can be put on hold and place multiple holds. - View the list of holds. - As a user with both "place_hold" and "modify_holds_priority" permission, you should see a "Priority" column with <select> fields allowing you to change hold priority. You should also see the arrow buttons for changing priority. - As a user with only "place_hold" permission, the "Priority" column should show the priority as a number. You should not see the arrow buttons. - In both cases, confirm that all operations work correctly: Changing hold date, expiration date, pickup library, suspended status; Cancelling holds. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org Status|Needs Signoff |Signed Off --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- Works as described. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Bug 30213 depends on bug 30207, which changed state. Bug 30207 Summary: Librarians with only "place_holds" permission can no longer update hold pickup locations https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Bug 30213 depends on bug 30207, which changed state. Bug 30207 Summary: Librarians with only "place_holds" permission can no longer update hold pickup locations https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131336|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138761&action=edit Bug 30213: Hide Delete (aka Priority) column when user only has place_hold permission This patch changes the way the priority column displays when viewing a list of holds as a user who doesn't have permission to change hold priority. To test: - Apply the patch and log into the staff interface as a user with at least "place_hold" permission. - Locate a record which can be put on hold and place multiple holds. - View the list of holds. - As a user with both "place_hold" and "modify_holds_priority" permission, you should see a "Priority" column with <select> fields allowing you to change hold priority. You should also see the arrow buttons for changing priority. - As a user with only "place_hold" permission, the "Priority" column should show the priority as a number. You should not see the arrow buttons. - In both cases, confirm that all operations work correctly: Changing hold date, expiration date, pickup library, suspended status; Cancelling holds. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Bug 30213 depends on bug 30207, which changed state. Bug 30207 Summary: Librarians with only "place_holds" permission can no longer update hold pickup locations https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org