[Bug 32994] New: Remove compiled files from src 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Bug ID: 32994 Summary: Remove compiled files from src 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: mtj@kohaaloha.com QA Contact: testopia@bugs.koha-community.org CC: mtj@kohaaloha.com small followup patch for bug 32609 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- Created attachment 146840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146840&action=edit Bug 32609: Remove compiled files from src small patch for debian packaging no testing info provided -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #2 from Mason James <mtj@kohaaloha.com> --- (In reply to Mason James from comment #0)
small followup patch for bug 32609
this patch adds a file that stops dpkg-source from including ./node_modules dir to koha-common.deb package to test... - build a package, note failure - apply patch - build a package, note success -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146840|0 |1 is obsolete| | --- Comment #3 from Mason James <mtj@kohaaloha.com> --- Created attachment 146843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146843&action=edit Bug 32609: Remove compiled files from src this patch adds a file that stops dpkg-source from including ./node_modules dir to koha-common.deb package to test... - build a package, note failure - apply patch - build a package, note success -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #4 from Mason James <mtj@kohaaloha.com> --- Created attachment 146932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146932&action=edit Bug 32994: Remove compiled files from src (2) this patch adds 2 files that stops dpkg-source from including ./node_modules dir into koha-common.deb package to test... - build a package, note failure - apply patch - build a package, note success -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146843|0 |1 is obsolete| | Attachment #146932|0 |1 is obsolete| | --- Comment #5 from Mason James <mtj@kohaaloha.com> --- Created attachment 146933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146933&action=edit Bug 32994: Remove compiled files from src (2) this patch adds 2 files that stops dpkg-source from including ./node_modules dir into koha-common.deb package to test... - build a package, note failure - apply patch - build a package, note success -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove compiled files from |Remove compiled files from |src 2 |src (2) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, | |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32809 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32609 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #6 from Mason James <mtj@kohaaloha.com> --- Created attachment 146994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146994&action=edit Bug 32994 - remove breaking css/maps/*.map files from Makefile.PL to test: - run makefile, note failure $ perl Makefile.PL make[1]: *** No rule to make target 'koha-tmpl/opac-tmpl/bootstrap/css/maps/opac-rtl.css.map', needed by 'pm_to_blib'. Stop. make[1]: Leaving directory '/build/koha-22.12.00-4~git+20230221145053.b112630a' dh_auto_build: make -j1 returned exit code 2 make: *** [debian/rules:9: build] Error 2 dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 E: Failed autobuilding of package - apply patch - run makefile, note success -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #7 from Mason James <mtj@kohaaloha.com> --- version info below... $ apt policy yarn: *** 1.22.19-1 500 500 https://dl.yarnpkg.com/debian stable/main amd64 Packages $ apt policy nodejs: *** 14.21.3-deb-1nodesource1 999 500 https://deb.nodesource.com/node_14.x buster/main amd64 Packages 100 /var/lib/dpkg/status $ npm -v 6.14.18 $ gulp -v CLI version: 2.3.0 Local version: Unknown -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146994|0 |1 is obsolete| | --- Comment #8 from Mason James <mtj@kohaaloha.com> --- Created attachment 146995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146995&action=edit Bug 32994 - remove breaking css/maps/*.map files from Makefile.PL to test: - run makefile, note failure $ perl Makefile.PL $ make $ make install webpack 5.74.0 compiled with 3 warnings in 20831 ms Done in 36.01s. make: *** No rule to make target 'koha-tmpl/opac-tmpl/bootstrap/css/maps/opac-rtl.css.map', needed by 'pm_to_blib'. Stop. - apply patch - run makefile, note success -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32975 [Bug 32975] Error in package.json's definition of css:build vs css:build:prod -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- With bug 32975 you shouldn't need the second patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #10 from Mason James <mtj@kohaaloha.com> --- (In reply to Jonathan Druart from comment #9)
With bug 32975 you shouldn't need the second patch.
hiya, i've confirmed 2nd patch is needed on latest HEAD 9863c18cc8 Bug 32933: Use val() instead of attr("value") when getting field values with jQuery -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Can we remove the lines instead of commenting? Also, are you running a dev install on packaging? the map files are only supposed to be generated when not using the :prod parameters, as those map files are only relevant on dev builds (they carry information about the scss file from which the css files were generated, for easier debugging). Can you post what you run on the build? Also, have you run git clean -f -x -d to make sure you don't have stray files? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #12 from Mason James <mtj@kohaaloha.com> --- (In reply to Tomás Cohen Arazi from comment #11)
Can we remove the lines instead of commenting?
Also, are you running a dev install on packaging? the map files are only supposed to be generated when not using the :prod parameters, as those map files are only relevant on dev builds (they carry information about the scss file from which the css files were generated, for easier debugging).
Can you post what you run on the build? Also, have you run git clean -f -x -d to make sure you don't have stray files?
note: no DEV_INSTALL=1 is set here is how i'm running a build... $ git clean -fdx $ git log --oneline | head -1 9863c18cc8 Bug 32933: Use val() instead of attr("value") when getting field values with jQuery $ git status On branch master Your branch is up to date with 'origin/master'. nothing to commit, working tree clean $ dpkg-buildpackage -b ... webpack 5.74.0 compiled with 3 warnings in 21555 ms Done in 36.15s. make[1]: *** No rule to make target 'koha-tmpl/opac-tmpl/bootstrap/css/maps/opac-rtl.css.map', needed by 'pm_to_blib'. Stop. make[1]: Leaving directory '/mnt/ssd4/pb-nightly/koha' dh_auto_build: make -j1 returned exit code 2 make: *** [debian/rules:9: build] Error 2 dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146995|0 |1 is obsolete| | --- Comment #13 from Mason James <mtj@kohaaloha.com> --- Created attachment 147106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147106&action=edit Bug 32994 - remove breaking css/maps/*.map files from Makefile.PL to test: - run makefile, note failure $ perl Makefile.PL $ make $ make install webpack 5.74.0 compiled with 3 warnings in 20831 ms Done in 36.01s. make: *** No rule to make target 'koha-tmpl/opac-tmpl/bootstrap/css/maps/opac-rtl.css.map', needed by 'pm_to_blib'. Stop. - apply patch - run makefile, note success -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #14 from Mason James <mtj@kohaaloha.com> --- (In reply to Tomás Cohen Arazi from comment #11)
Can we remove the lines instead of commenting?
new patch uploaded with lines removed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #15 from Mason James <mtj@kohaaloha.com> --- (In reply to Jonathan Druart from comment #9)
With bug 32975 you shouldn't need the second patch.
aah, ive just clicked that 32975 isnt pushed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #16 from Mason James <mtj@kohaaloha.com> --- (In reply to Mason James from comment #15)
(In reply to Jonathan Druart from comment #9)
With bug 32975 you shouldn't need the second patch.
aah, ive just clicked that 32975 isnt pushed
confirmed package build fails with 32975 applied -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #17 from Mason James <mtj@kohaaloha.com> --- (In reply to Mason James from comment #15)
(In reply to Jonathan Druart from comment #9)
With bug 32975 you shouldn't need the second patch.
aah, ive just clicked that 32975 isnt pushed
ignore this -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #18 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #9)
With bug 32975 you shouldn't need the second patch.
Bug 32975 is probably the reason why the second patch is needed. I haven't double-checked but that would be my guess. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to David Cook from comment #18)
(In reply to Jonathan Druart from comment #9)
With bug 32975 you shouldn't need the second patch.
Bug 32975 is probably the reason why the second patch is needed. I haven't double-checked but that would be my guess.
Indeed, I misread the patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32609 Assignee|koha-bugs@lists.koha-commun |mtj@kohaaloha.com |ity.org | --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Looks like we are dealing with 2 different problems here. Would have been beteer to have 2 different bugs; Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 [Bug 32609] Remove compiled files from src -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146933|0 |1 is obsolete| | Attachment #147106|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147109&action=edit Bug 32994: Remove compiled files from src (2) this patch adds 2 files that stops dpkg-source from including ./node_modules dir into koha-common.deb package to test... - build a package, note failure - apply patch - build a package, note success Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147110&action=edit Bug 32994: Remove breaking css/maps/*.map files from Makefile.PL to test: - run makefile, note failure $ perl Makefile.PL $ make $ make install webpack 5.74.0 compiled with 3 warnings in 20831 ms Done in 36.01s. make: *** No rule to make target 'koha-tmpl/opac-tmpl/bootstrap/css/maps/opac-rtl.css.map', needed by 'pm_to_blib'. Stop. - apply patch - run makefile, note success Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147109|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147110|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 147129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147129&action=edit Bug 32994: Remove compiled files from src (2) this patch adds 2 files that stops dpkg-source from including ./node_modules dir into koha-common.deb package to test... - build a package, note failure - apply patch - build a package, note success Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 147130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147130&action=edit Bug 32994: Remove breaking css/maps/*.map files from Makefile.PL to test: - run makefile, note failure $ perl Makefile.PL $ make $ make install webpack 5.74.0 compiled with 3 warnings in 20831 ms Done in 36.01s. make: *** No rule to make target 'koha-tmpl/opac-tmpl/bootstrap/css/maps/opac-rtl.css.map', needed by 'pm_to_blib'. Stop. - apply patch - run makefile, note success Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #26 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33213 --- Comment #27 from Mason James <mtj@kohaaloha.com> --- *** Bug 33213 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com --- Comment #28 from Lucas Gass <lucas@bywatersolutions.com> --- Not needed in 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Bug 32994 depends on bug 32975, which changed state. Bug 32975 Summary: Error in package.json's definition of css:build vs css:build:prod https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32975 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Bug 32994 depends on bug 32609, which changed state. Bug 32609 Summary: Remove compiled files from src https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org