[Bug 19953] New: Record page: acquisition details: add column for invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Bug ID: 19953 Summary: Record page: acquisition details: add column for invoice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: victor.grousset@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Created attachment 70427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70427&action=edit Screenshot proposed change See the attachment for how it would look. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70427|Screenshot proposed change |Screenshot of proposed description| |change -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 --- Comment #1 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 70431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70431&action=edit Bug 19953: Record page: acquisition details: add column for invoice Test plan: 1. create a vendor with minimal info 2. create a basket with minimal info 3. add a item to the basket 4. close the basket 5. receive a shipment 6. on the "receipt summary" click on "receive" for the wanted item (it should be the only one) 7. items → receive? → tick this checkbox 8. save 9. click on "finish receiving" 10. Go to the record → Acquisition details 11. Apply this patch 12. Refresh the page 13. You should see the new column -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70431|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 72676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72676&action=edit Bug 19953: Record page: acquisition details: add column for invoice Test plan: 1. create a vendor with minimal info 2. create a basket with minimal info 3. add a item to the basket 4. close the basket 5. receive a shipment 6. on the "receipt summary" click on "receive" for the wanted item (it should be the only one) 7. items → receive? → tick this checkbox 8. save 9. click on "finish receiving" 10. Go to the record → Acquisition details 11. Apply this patch 12. Refresh the page 13. You should see the new column Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |victor.grousset@biblibre.co |ity.org |m --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Victor, please remember to assign yourself the bugs you work on! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 --- Comment #5 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Indeed, thanks :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 72676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72676 Bug 19953: Record page: acquisition details: add column for invoice Review of attachment 72676: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19953&attachment=72676) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ +695,4 @@
[% END %] </td> <td> + [% IF (order.invoiceid) %]
I think it would be nicer to check the permission here like we do on the next column. Strangely it seems we don't have a separate permission for managing invoices in acq, the templates check for "any permission in the acquisitions module". Could you mirror that here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72676|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 73515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73515&action=edit Bug 19953: Record page: acquisition details: add column for invoice Test plan: 1. create a vendor with minimal info 2. create a basket with minimal info 3. add a item to the basket 4. close the basket 5. receive a shipment 6. on the "receipt summary" click on "receive" for the wanted item (it should be the only one) 7. items → receive? → tick this checkbox 8. save 9. click on "finish receiving" 10. go to the record → Acquisition details 11. apply this patch 12. refresh the page 13. you should see the new column Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #8 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- "any permission in the acquisitions module" So I used CAN_user_acquisition Here is my amend: diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt index f130644..9b1eb1a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ -704,9 +704,13 @@ </td> <td> [% IF (order.invoiceid) %] - <a href="/cgi-bin/koha/acqui/invoice.pl?invoiceid=[% order.invoiceid %]" - title="Invoice detail page"> - [% order.invoicenumber %]</a> + [% IF CAN_user_acquisition %] + <a href="/cgi-bin/koha/acqui/invoice.pl?invoiceid=[% order.invoiceid %]" + title="Invoice detail page"> + [% order.invoicenumber %]</a> + [% ELSE %] + [% order.invoicenumber %] + [% END %] ########################################################## note: I haven't invalidated the sign off. (maybe I should?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just make your changes as a follow-up patch (separate) next time. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73515|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73593&action=edit Bug 19953: Record page: acquisition details: add column for invoice Test plan: 1. create a vendor with minimal info 2. create a basket with minimal info 3. add a item to the basket 4. close the basket 5. receive a shipment 6. on the "receipt summary" click on "receive" for the wanted item (it should be the only one) 7. items → receive? → tick this checkbox 8. save 9. click on "finish receiving" 10. go to the record → Acquisition details 11. apply this patch 12. refresh the page 13. you should see the new column Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 --- Comment #11 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> ---
Just make your changes as a follow-up patch (separate) next time. :)
Got it, two patches wouldn't have looked clean in the history but if two patches are an issue then the maintainer could just squash them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Victor Grousset/tuxayo from comment #11)
Just make your changes as a follow-up patch (separate) next time. :)
Got it, two patches wouldn't have looked clean in the history but if two patches are an issue then the maintainer could just squash them.
Why would they not have looked clean? It's how we roll :) The general rule is that once a patch has been signed off, you shoud not change the signed patches but add changes as seprate patches. This way the sign-offer and QA can verify the changes and the history is clear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 --- Comment #13 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> ---
Why would they not have looked clean?
It would be like 2/3 of the work in one patch and 1/3 in the other.
It's how we roll :)
The general rule is that once a patch has been signed off, you shoud not change the signed patches but add changes as seprate patches. This way the sign-offer and QA can verify the changes and the history is clear.
Thanks for the clarification, it's simpler like that :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Record page: acquisition |Add column for invoice in |details: add column for |acquisition details tab |invoice | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick@bywatersolutions.com --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Small enhancement, pushed to stable for 17.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org