https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36469 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Summary|addbiblio.css used in |Conflict between |unwanted pages (?) |_header.scss and | |addbiblio.css tab style Severity|enhancement |minor Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36469 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 164178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164178&action=edit Bug 36469: Fix conflict between _header.scss and addbiblio.css tab style addbiblio.css adds padding to tab panes specific for that interface, and the header search form should not pick up that style. This patch adds some specificity to _header.scss to avoid unwanted padding. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Cataloging -> New record (using the basic MARC editor). - The style of the MARC edit form should look correct. - The header search form should look correct - Test other pages with tabs to confirm that there are no other unwanted side-effects, e.g. Circulation -> Check out; Advanced catalog search; Bibliographic detail page. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36469 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164178|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 164232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164232&action=edit Bug 36469: Fix conflict between _header.scss and addbiblio.css tab style addbiblio.css adds padding to tab panes specific for that interface, and the header search form should not pick up that style. This patch adds some specificity to _header.scss to avoid unwanted padding. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Cataloging -> New record (using the basic MARC editor). - The style of the MARC edit form should look correct. - The header search form should look correct - Test other pages with tabs to confirm that there are no other unwanted side-effects, e.g. Circulation -> Check out; Advanced catalog search; Bibliographic detail page. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36469 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35850 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Hey, I'm not 100% sure about this one. I believe this was introduced by bug 35850. Before 35850, the top search header was: <div id="header_search" role="tablist"> after bug 35850 is now <div id="header_search" class="toptabs"> which is triggering the following CSS rule .toptabs .tab-pane { padding: 1em; } Owen can you confirm if this is intentional? It feels unintentional and if that's the case, is adding more CSS the fix here? Additionally, current master record cataloguing has a big search header as well: http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl Is this also intentional? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850 [Bug 35850] Use template wrapper for tabs: Header search forms -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36469 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36469 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36469 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 35850 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36469 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.