[Bug 23226] New: Remove type attribute from script tags: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23226 Bug ID: 23226 Summary: Remove type attribute from script tags: Cataloging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 22956 This patch will remove the obsolete "type" attribute from <script> tags in the following cataloging templates: - intranet-tmpl\prog\en\modules\cataloguing\addbooks.tt - intranet-tmpl\prog\en\modules\cataloguing\z3950_auth_search.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22956 [Bug 22956] Omnibus: Remove type attribute from script tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23226 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23226 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91053&action=edit Bug 23226: Remove type attribute from script tags: Cataloging This patch removes the "type" attribute from <script> tags one cataloging and one authorities template. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Cataloging -> Cataloging home page - Cataloging -> Cataloging home page -> Search results - Authorities -> New authority -> New from Z39.50/SRU Validating the HTML source of any of these pages should return no errors related to the "type" attribute. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23226 Frédérik Chénier <frederik.chenier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23226 Frédérik Chénier <frederik.chenier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91053|0 |1 is obsolete| | --- Comment #2 from Frédérik Chénier <frederik.chenier@inlibro.com> --- Created attachment 91667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91667&action=edit Bug 23226: Remove type attribute from script tags: Cataloging This patch removes the "type" attribute from <script> tags one cataloging and one authorities template. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Cataloging -> Cataloging home page - Cataloging -> Cataloging home page -> Search results - Authorities -> New authority -> New from Z39.50/SRU Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23226 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23226 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91667|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91809&action=edit Bug 23226: Remove type attribute from script tags: Cataloging This patch removes the "type" attribute from <script> tags one cataloging and one authorities template. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Cataloging -> Cataloging home page - Cataloging -> Cataloging home page -> Search results - Authorities -> New authority -> New from Z39.50/SRU Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23226 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23226 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23226 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.03 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23226 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org