[Bug 16320] New: Refactor ILSDI_Services.t so it uses TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16320 Bug ID: 16320 Summary: Refactor ILSDI_Services.t so it uses TestBuilder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: gmcharlt@gmail.com ILSDI_Services.t needs a rewrite so it doesn't use fixed data or expects it from the DB. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16320 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Depends on| |16155 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155 [Bug 16155] Composite keys in TestBuilder and more -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16320 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 50531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50531&action=edit Bug 16320: Refactor ILSDI_Services.t so it uses TestBuilder This patch refactors the tests so they are corerctly built using TestBuilder and wrapper inside a DB transaction in a less ambiguous way. To test: - Verify that the tests pass with the patch: - Run: $ prove t/db_dependent/ILSDI_Services.t => SUCCESS: Tests pass - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16320 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |hector.hecaxmmx@gmail.com --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Hi Tomás Test pass successful but give me this Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 373. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 390. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 399. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 423. Is this Ok? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16320 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50531|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 50577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50577&action=edit Bug 16320: Refactor ILSDI_Services.t so it uses TestBuilder This patch refactors the tests so they are corerctly built using TestBuilder and wrapper inside a DB transaction in a less ambiguous way. To test: - Verify that the tests pass with the patch: - Run: $ prove t/db_dependent/ILSDI_Services.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16320 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 50578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50578&action=edit Bug 16320: [QA Follow-up] Remove warnings from ILSDI/Services.pm Removes: Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 373. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 390. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 399. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 423. Test plan: Run t/db_dependent/ILSDI_Services.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16320 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Héctor Eduardo Castro Avalos from comment #2)
Hi Tomás
Test pass successful but give me this Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 373. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 390. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 399. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 423.
Is this Ok?
Hector: Please add your signoff in order to get it thru QA. Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16320 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com Status|In Discussion |Needs Signoff CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16320 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- PatronNotFount -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16320 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16320 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50578|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 50579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50579&action=edit Bug 16320: [QA Follow-up] Remove warnings from ILSDI/Services.pm Removes: Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 373. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 390. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 399. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 423. Test plan: Run t/db_dependent/ILSDI_Services.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16320 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50577|0 |1 is obsolete| | --- Comment #8 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 50587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50587&action=edit [SIGNED-OFF]Bug 16320: Refactor ILSDI_Services.t so it uses TestBuilder This patch refactors the tests so they are corerctly built using TestBuilder and wrapper inside a DB transaction in a less ambiguous way. To test: - Verify that the tests pass with the patch: - Run: $ prove t/db_dependent/ILSDI_Services.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16320 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50579|0 |1 is obsolete| | --- Comment #9 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 50588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50588&action=edit [SIGNED-OFF]Bug 16320: [QA Follow-up] Remove warnings from ILSDI/Services.pm Removes: Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 373. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 390. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 399. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 423. Test plan: Run t/db_dependent/ILSDI_Services.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16320 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Thanks Hector and Tomas. Can pass QA now. @RM: This may go separately from 16155. Applies and passes both ways. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16320 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 50873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50873&action=edit Bug 16320: [QA Follow-up] Fix borrower attribute test in ILSDI_Services Since bug 12267 removed the password option, this test should be adjusted. Test plan: Run the test. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16320 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12267 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16320 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for the Koha 16.05 release. Thanks Tomas! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org