[Bug 16316] New: Make it possible to limit patron search to surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16316 Bug ID: 16316 Summary: Make it possible to limit patron search to surname Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: magnus@libriotech.no Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com I have a customer that wants to be able to limit a patron search to just searching for surnames. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16316 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16316 --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- Created attachment 50504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50504&action=edit Bug 16316 - Limit patron search to surname This patch makes it possible to limit a patron search to search just for surnames. To test: - Apply the patch - Add two patrons, called e.g. "John Doe" and "Doe John" - Go to Patrons in the Intranet - Make sure you have selected "Search fields" = Standard - Search for "john" and verify both patrons show up - Search for "doe" and verify both patrons show up - Set "Search fields" = Surname and search for "john". "Doe John" should show up, but not "John Doe" - Set "Search fields" = Surname and search for "doe". Neither "Doe John" nor "John Doe" should show up. Sponsored-by: Alingsås Public Library, Sweden -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16316 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> ---
- Set "Search fields" = Surname and search for "doe". Neither "Doe John" nor "John Doe" should show up.
Is this part of the test plan correct? Why should neither show up? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16316 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16316 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16316 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50504|0 |1 is obsolete| | --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- Created attachment 50536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50536&action=edit Bug 16316 - Limit patron search to surname This patch makes it possible to limit a patron search to search just for surnames. To test: - Apply the patch - Add two patrons, called e.g. "John Doe" and "Doe John" - Go to Patrons in the Intranet - Make sure you have selected "Search fields" = Standard - Search for "john" and verify both patrons show up - Search for "doe" and verify both patrons show up - Set "Search fields" = Surname and search for "john". "Doe John" should show up, but not "John Doe". - Set "Search fields" = Surname and search for "doe". "John Doe" should show up, but not "Doe John". Update: Revised the last point in the test plan. Sponsored-by: Alingsås Public Library, Sweden -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16316 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16316 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50536|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50537&action=edit [SIGNED-OFF] Bug 16316 - Limit patron search to surname This patch makes it possible to limit a patron search to search just for surnames. To test: - Apply the patch - Add two patrons, called e.g. "John Doe" and "Doe John" - Go to Patrons in the Intranet - Make sure you have selected "Search fields" = Standard - Search for "john" and verify both patrons show up - Search for "doe" and verify both patrons show up - Set "Search fields" = Surname and search for "john". "Doe John" should show up, but not "John Doe". - Set "Search fields" = Surname and search for "doe". "John Doe" should show up, but not "Doe John". Update: Revised the last point in the test plan. Sponsored-by: Alingsås Public Library, Sweden Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16316 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Magnus, please provide test coverage for the change in C4::Utils::DataTables::Members::search. It would be quite easy to do, this subroutine is already well covered. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16316 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16316 --- Comment #6 from Magnus Enger <magnus@libriotech.no> --- Created attachment 50712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50712&action=edit Bug 16316 - QA FOLLOWUP - Add tests Add 6 tests for searching by surname. To test, run: prove t/db_dependent/Utils/Datatables_Members.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16316 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16316 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50537|0 |1 is obsolete| | Attachment #50712|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50746&action=edit Bug 16316 - Limit patron search to surname This patch makes it possible to limit a patron search to search just for surnames. To test: - Apply the patch - Add two patrons, called e.g. "John Doe" and "Doe John" - Go to Patrons in the Intranet - Make sure you have selected "Search fields" = Standard - Search for "john" and verify both patrons show up - Search for "doe" and verify both patrons show up - Set "Search fields" = Surname and search for "john". "Doe John" should show up, but not "John Doe". - Set "Search fields" = Surname and search for "doe". "John Doe" should show up, but not "Doe John". Update: Revised the last point in the test plan. Sponsored-by: Alingsås Public Library, Sweden Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16316 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50747&action=edit Bug 16316 - QA FOLLOWUP - Add tests Add 6 tests for searching by surname. To test, run: prove t/db_dependent/Utils/Datatables_Members.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16316 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for the Koha 16.05 release. Thanks Magnus! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org