[Bug 40859] New: Item deletion is broken when using the linktools button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40859 Bug ID: 40859 Summary: Item deletion is broken when using the linktools button Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: matt.blenkinsop@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Comment from bug 37116 Go to: http://localhost:8081/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=1&itemnumber=1 click on the row, then "Delete item" You see an alert: "Are you sure you want to delete this item?" Click "OK" You then see the modal "Are you sure you want to delete this item?" Click "Delete item" => Nothing happens! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40859 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40859 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40859 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37115 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 [Bug 37115] Add the option to delete linked serials when deleting items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40859 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40859 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 186783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186783&action=edit Bug 40859: Restore deletion when using the 'linktools' button Test plan: 1) Go to: http://localhost:8081/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=1&itemnumber=1 2) Click on the row for the first item to get the linktool buttons 3) Click "Delete item" 4) Accept the "Are you sure you want to delete this item?" alert 5) Accept the modal 6) The page refreshes and the item is deleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40859 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- We don't need both confirmation. We should remove the alert (was it the behaviour before bug 37115?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40859 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40859 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40859 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 186823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186823&action=edit Bug 40859: (QA follow-up) Remove unnecessary alert -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40859 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- I am not sure this is directly caused by this patch or the precedent change, but I was suspecting the ".delete" to be too wide, and I caught this: 140 [%# Host item %] 141 <li 142 ><a href="additem.pl?op=edititem&biblionumber=[% item.biblionumber | uri %]&itemnumber=[% item.itemnumber | uri %]#edititem">Edit in host</a> &nb sp; 143 <a 144 class="delete" 145 href="/cgi-bin/koha/cataloguing/additem.pl?op=delinkitem&biblionumber=[% biblio.biblionumber | html %]&hostitemnumber=[% item.itemnumber | ht ml %]&searchid=[% searchid | html %]" 146 >Unlink</a 147 ></li 148 > The UI is broken: https://snipboard.io/l3bdgu.jpg And "Unlink" opens the modal. "Delete the item" does not work, but actually I don't think it should delete the item. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40859 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #4)
I am not sure this is directly caused by this patch or the precedent change, but I was suspecting the ".delete" to be too wide
Seems to be an existing bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40859 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is a little bit of an odd one: Bug 40859 - Item deletion is broken when using the linktools button 186783 - Bug 40859: Restore deletion when using the 'linktools' button 186823 - Bug 40859: (QA follow-up) Remove unnecessary alert Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 40859: Restore deletion when using the 'linktools' button Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js No changes -- Patch already applied. Applying: Bug 40859: (QA follow-up) Remove unnecessary alert Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js Falling back to patching base and 3-way merge... No changes -- Patch already applied. I can't find the bug number in the commits on main, but changes appear in main. I tracked it to bug 40908. Marking this as a duplicate. *** This bug has been marked as a duplicate of bug 40908 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org