[Bug 32806] New: Some Vue files need to be moved for better reusability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Bug ID: 32806 Summary: Some Vue files need to be moved for better reusability Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 32030 So far the Vue files are only used by the ERM module, but some needs to be move in a parent directory to make them reusable by another module. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146030&action=edit Bug 32806: Move Vue files for reusability -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustin.moyano@gmail.com, | |martin.renvoize@ptfs-europe | |.com, | |pedro.amorim@ptfs-europe.co | |m, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146033&action=edit Bug 32806: Rename main.js to erm.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146035&action=edit Bug 32806: Rename ERMHome and ERMMain to Home and Main We don't need to repeat "ERM" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146036&action=edit Bug 32806: Move routes.js to routes/erm.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32609 CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano@theke.io --- Comment #5 from Agustín Moyano <agustinmoyano@theke.io> --- Hi Jonathan, to reuse stuff I like your idea to create folders by type (routes, stores, components, ..). Maybe we can add another folder named "modules" where we place all "main.ts" files, renaming them as "erm.ts" or "import_sources.ts". Or, instead of creating a "modules" folder, we could have a single "main.ts" and make all modules in routes to lazy load ( https://router.vuejs.org/guide/advanced/lazy-loading.html ) About the components folder, in my implementation, I added a "shared" subfolder for all shared components, but I don't mind keeping them in the components folder directly. I loved the idea of generating the breadcrumbs from the router specification, but the definition of it was kind of confusing, and hard to follow, so I took your idea and changed it a little bit. I added a couple more shared components, one of them being the implementation of Datatables in Vue (called KohaTables). I see that you have here the "composable" folder where you call functions of Datatables, but I saw that the creators of Datatables had an implementation for Vue, so I thought it best to use that. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Agustín Moyano from comment #5)
Hi Jonathan, to reuse stuff I like your idea to create folders by type (routes, stores, components, ..).
Maybe we can add another folder named "modules" where we place all "main.ts" files, renaming them as "erm.ts" or "import_sources.ts". Or, instead of creating a "modules" folder, we could have a single "main.ts" and make all modules in routes to lazy load ( https://router.vuejs.org/guide/advanced/lazy-loading.html )
I think I quite like the idea to have them visible at the root instead of hiding in the sub directory, but I am not strongly attached to it.
About the components folder, in my implementation, I added a "shared" subfolder for all shared components, but I don't mind keeping them in the components folder directly.
Same as above, it was to make them more visible, but that one could consider it messy.
I loved the idea of generating the breadcrumbs from the router specification, but the definition of it was kind of confusing, and hard to follow, so I took your idea and changed it a little bit.
The breadcrumb for the ERM module is quite complex, hence the complexity of the file :) About your implementation, there is something weird, you don't define the routes, and "Add import source" leads to admin/import-sources.pl/add. Is that expected? On erm I've decided to rewrite the url and have something following the REST routes (/cgi-bin/koha/erm/eholdings/local/packages/add for instance)
I added a couple more shared components, one of them being the implementation of Datatables in Vue (called KohaTables). I see that you have here the "composable" folder where you call functions of Datatables, but I saw that the creators of Datatables had an implementation for Vue, so I thought it best to use that.
Yes but then you will need to reimplement all what we have in datatables.js, and I don't think that's something worthwhile (at least I would not consider it a priority for now). In your implementation there is problem with the pagination (NaN), the order by does not work, there is no column filtering, etc. I think we need to be consistent between the modules that are going to use Vue. We should apply the changes to the existing modules, then use them for the new ones. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Putting in discussion, but we need to move forward quickly here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- This looks really good. Had a look at Agustin's implementation, also looks really good. For discussion sake, here: https://gitlab.com/thekesolutions/Koha/-/tree/import_source_vue/koha-tmpl/in... I agree with everything and don't have much to add really, some thoughts at a glance: - Personally, I like Agustin's "modules" folder idea. - Not a huge fan of "fetch" folder, mostly the name, but don't have a great alternative for it either. - What about t/cypress? Should we prefix all module related tests with modulename and leave all tests inside integration folder where they currently live? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32609 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 [Bug 32609] Remove compiled files from src -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146337&action=edit Bug 32806: (follow-up) Rename main.js to erm.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146357&action=edit Bug 32806: Move main-erm.ts to modules/erm.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32607 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 [Bug 32607] Add import sources CRUD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #11 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Jonathan Druart from comment #6)
About the components folder, in my implementation, I added a "shared" subfolder for all shared components, but I don't mind keeping them in the components folder directly.
Same as above, it was to make them more visible, but that one could consider it messy.
I believe we can keep them at components folder
I loved the idea of generating the breadcrumbs from the router specification, but the definition of it was kind of confusing, and hard to follow, so I took your idea and changed it a little bit.
The breadcrumb for the ERM module is quite complex, hence the complexity of the file :) About your implementation, there is something weird, you don't define the routes, and "Add import source" leads to admin/import-sources.pl/add. Is that expected? On erm I've decided to rewrite the url and have something following the REST routes (/cgi-bin/koha/erm/eholdings/local/packages/add for instance)
I defined my routes in import-source/tree.js That definition gets imported to stores/menu.js, and when that happens the tree gets analyzed, and some attributes are added. from there, the menu store has actions that allow you to get the routes, left-hand submenu and breadcrums About the url, if I don't make admin/import-sources.pl the root of my routes, when users enter, they would see an empty page... I really don't want users to click on something to see the table.. the other routes depend on this one, so the /add and /:id gets appended
I added a couple more shared components, one of them being the implementation of Datatables in Vue (called KohaTables). I see that you have here the "composable" folder where you call functions of Datatables, but I saw that the creators of Datatables had an implementation for Vue, so I thought it best to use that.
Yes but then you will need to reimplement all what we have in datatables.js, and I don't think that's something worthwhile (at least I would not consider it a priority for now). In your implementation there is problem with the pagination (NaN), the order by does not work, there is no column filtering, etc.
Ok, but I still believe all logic of Datatables should be encapsulated by a single component... meaning that what it is in composables/datatables.js should be logic that belongs to a table component (Datatable, Kohatable, or whatever you believe best to call it). In that case, if somewhere in the future we want to replace Datatables with something else, there is a single place to touch and is more consistent with Vue's "spirit" of things
I think we need to be consistent between the modules that are going to use Vue. We should apply the changes to the existing modules, then use them for the new ones.
Agreed, I made my bug depend on this one, just to be in sync Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Agustín Moyano from comment #11)
(In reply to Jonathan Druart from comment #6)
The breadcrumb for the ERM module is quite complex, hence the complexity of the file :) About your implementation, there is something weird, you don't define the routes, and "Add import source" leads to admin/import-sources.pl/add. Is that expected? On erm I've decided to rewrite the url and have something following the REST routes (/cgi-bin/koha/erm/eholdings/local/packages/add for instance)
I defined my routes in import-source/tree.js
That definition gets imported to stores/menu.js, and when that happens the tree gets analyzed, and some attributes are added.
from there, the menu store has actions that allow you to get the routes, left-hand submenu and breadcrums
About the url, if I don't make admin/import-sources.pl the root of my routes, when users enter, they would see an empty page... I really don't want users to click on something to see the table.. the other routes depend on this one, so the /add and /:id gets appended
You need the RewriteRule in apache's config. Another thing is the translations, did you try if that works with your implementation? I don't mind replacing the breadcrumbs system we have for ERM, but to be honest I spent a lot of time to reach this point, and my I am not sure what you have now is ready to replace it. Feel free to provide an implementation for the ERM module to see if there is feature parity. https://snipboard.io/9f6qPL.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146337|0 |1 is obsolete| | Attachment #146357|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146465&action=edit Bug 32806: (follow-up) Rename main.js to erm.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146466&action=edit Bug 32806: Move main-erm.ts to modules/erm.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32939 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 [Bug 32939] Have a generic fetch function for POST and PUT requests in vue modules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Can we move forward here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32609 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146033|0 |1 is obsolete| | --- Comment #16 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 146619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146619&action=edit Bug 32806: Rename main.js to erm.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146035|0 |1 is obsolete| | --- Comment #17 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 146620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146620&action=edit Bug 32806: Rename ERMHome and ERMMain to Home and Main We don't need to repeat "ERM" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146036|0 |1 is obsolete| | --- Comment #18 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 146621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146621&action=edit Bug 32806: Move routes.js to routes/erm.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146465|0 |1 is obsolete| | --- Comment #19 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 146622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146622&action=edit Bug 32806: (follow-up) Rename main.js to erm.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146466|0 |1 is obsolete| | --- Comment #20 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 146623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146623&action=edit Bug 32806: Move main-erm.ts to modules/erm.ts Looks fine. Signed-off-by: LMSCloudPaulD <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146030|0 |1 is obsolete| | --- Comment #21 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 146626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146626&action=edit Bug 32806: Move Vue files for reusability Forgot one.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146619|0 |1 is obsolete| | --- Comment #22 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 146627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146627&action=edit Bug 32806: Rename main.js to erm.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146620|0 |1 is obsolete| | --- Comment #23 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 146628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146628&action=edit Bug 32806: Rename ERMHome and ERMMain to Home and Main We don't need to repeat "ERM" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146621|0 |1 is obsolete| | --- Comment #24 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 146629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146629&action=edit Bug 32806: Move routes.js to routes/erm.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146622|0 |1 is obsolete| | --- Comment #25 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 146630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146630&action=edit Bug 32806: (follow-up) Rename main.js to erm.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146623|0 |1 is obsolete| | --- Comment #26 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 146631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146631&action=edit Bug 32806: Move main-erm.ts to modules/erm.ts Looks fine. Signed-off-by: LMSCloudPaulD <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146626|0 |1 is obsolete| | --- Comment #27 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 146634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146634&action=edit Bug 32806: Move Vue files for reusability -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146627|0 |1 is obsolete| | --- Comment #28 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 146635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146635&action=edit Bug 32806: Rename main.js to erm.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146628|0 |1 is obsolete| | --- Comment #29 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 146636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146636&action=edit Bug 32806: Rename ERMHome and ERMMain to Home and Main We don't need to repeat "ERM" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146629|0 |1 is obsolete| | --- Comment #30 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 146637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146637&action=edit Bug 32806: Move routes.js to routes/erm.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146630|0 |1 is obsolete| | --- Comment #31 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 146638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146638&action=edit Bug 32806: (follow-up) Rename main.js to erm.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146631|0 |1 is obsolete| | --- Comment #32 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 146639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146639&action=edit Bug 32806: Move main-erm.ts to modules/erm.ts Looks fine. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #33 from David Nind <david@davidnind.com> --- Hi Paul. I think you may need to change the bug status to Signed Off - it looks like you have signed it off to me. Also, normally the signed off line is in all the patches. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146634|0 |1 is obsolete| | --- Comment #34 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 146647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146647&action=edit Bug 32806: Move Vue files for reusability Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146635|0 |1 is obsolete| | --- Comment #35 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 146648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146648&action=edit Bug 32806: Rename main.js to erm.js Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146636|0 |1 is obsolete| | --- Comment #36 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 146649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146649&action=edit Bug 32806: Rename ERMHome and ERMMain to Home and Main We don't need to repeat "ERM" Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146637|0 |1 is obsolete| | --- Comment #37 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 146650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146650&action=edit Bug 32806: Move routes.js to routes/erm.js Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146638|0 |1 is obsolete| | --- Comment #38 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 146651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146651&action=edit Bug 32806: (follow-up) Rename main.js to erm.js Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146639|0 |1 is obsolete| | --- Comment #39 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 146652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146652&action=edit Bug 32806: Move main-erm.ts to modules/erm.ts Looks fine. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #40 from Paul Derscheid <paul.derscheid@lmscloud.de> --- I hope that I fixed it now. Thanks David! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32923 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 [Bug 32923] x-koha-embed must a header of collectionFormat csv -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146647|0 |1 is obsolete| | Attachment #146648|0 |1 is obsolete| | Attachment #146649|0 |1 is obsolete| | Attachment #146650|0 |1 is obsolete| | Attachment #146651|0 |1 is obsolete| | Attachment #146652|0 |1 is obsolete| | --- Comment #41 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146661&action=edit Bug 32806: Move Vue files for reusability Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #42 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146662&action=edit Bug 32806: Rename main.js to erm.js Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #43 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146663&action=edit Bug 32806: Rename ERMHome and ERMMain to Home and Main We don't need to repeat "ERM" Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #44 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146664&action=edit Bug 32806: Move routes.js to routes/erm.js Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #45 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146665&action=edit Bug 32806: (follow-up) Rename main.js to erm.js Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #46 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146666&action=edit Bug 32806: Move main-erm.ts to modules/erm.ts Looks fine. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #47 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Patches rebased on top of bug 32898 and bug 32923. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|32607 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 [Bug 32607] Add import sources CRUD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|32939 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 [Bug 32939] Have generic fetch functions in vue modules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32939 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 [Bug 32939] Have generic fetch functions in vue modules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146661|0 |1 is obsolete| | --- Comment #48 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147241&action=edit Bug 32806: Move Vue files for reusability Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146662|0 |1 is obsolete| | --- Comment #49 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147242&action=edit Bug 32806: Rename main.js to erm.js Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146663|0 |1 is obsolete| | --- Comment #50 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147243&action=edit Bug 32806: Rename ERMHome and ERMMain to Home and Main We don't need to repeat "ERM" Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146664|0 |1 is obsolete| | --- Comment #51 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147244&action=edit Bug 32806: Move routes.js to routes/erm.js Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146665|0 |1 is obsolete| | --- Comment #52 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147245&action=edit Bug 32806: (follow-up) Rename main.js to erm.js Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146666|0 |1 is obsolete| | --- Comment #53 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147246&action=edit Bug 32806: Move main-erm.ts to modules/erm.ts Looks fine. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #54 from David Cook <dcook@prosentient.com.au> --- (In reply to Agustín Moyano from comment #11)
Ok, but I still believe all logic of Datatables should be encapsulated by a single component... meaning that what it is in composables/datatables.js should be logic that belongs to a table component (Datatable, Kohatable, or whatever you believe best to call it). In that case, if somewhere in the future we want to replace Datatables with something else, there is a single place to touch and is more consistent with Vue's "spirit" of things
Agreed. It seems like we've got quite a bit of duplicated code in the different components. I'm not sure that we need so many? I wonder if some things are components when they could be regular Javascript objects or JSON objects. Would need to take a deeper look to know for sure... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147241|0 |1 is obsolete| | --- Comment #55 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147299&action=edit Bug 32806: Move Vue files for reusability Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147242|0 |1 is obsolete| | --- Comment #56 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147300&action=edit Bug 32806: Rename main.js to erm.js Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147243|0 |1 is obsolete| | --- Comment #57 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147301&action=edit Bug 32806: Rename ERMHome and ERMMain to Home and Main We don't need to repeat "ERM" Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147244|0 |1 is obsolete| | --- Comment #58 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147302&action=edit Bug 32806: Move routes.js to routes/erm.js Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147245|0 |1 is obsolete| | --- Comment #59 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147303&action=edit Bug 32806: (follow-up) Rename main.js to erm.js Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147246|0 |1 is obsolete| | --- Comment #60 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147304&action=edit Bug 32806: Move main-erm.ts to modules/erm.ts Looks fine. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #61 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #62 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Bug 32806 depends on bug 32923, which changed state. Bug 32923 Summary: x-koha-embed must a header of collectionFormat csv https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com --- Comment #63 from Lucas Gass <lucas@bywatersolutions.com> --- Not needed in 22.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com --- Comment #64 from Andrew Nugged <nugged@gmail.com> --- Is this lost in this ticket or did I miss a dependency? Because I don't see any physical renaming for main.js -> erm.js and it fails to create a transitional piloting build for our production piloting library for 22.11.x (but I assume master branch too?): make[1]: *** No rule to make target 'koha-tmpl/intranet- tmpl/prog/js/vue/dist/erm.js', needed by 'pm_to_blib'. Stop. so this error means that the target is not present, and I noticed that the .../js/dist/ folder still contains main.*, but not erm.*. I did renaming additionally (this patch below), and the build was successful. --- koha-tmpl/intranet-tmpl/prog/js/vue/dist/{main.js => erm.js} | 0 .../prog/js/vue/dist/{main.js.LICENSE.txt => erm.js.LICENSE.txt} | 0 2 files changed, 0 insertions(+), 0 deletions(-) rename koha-tmpl/intranet-tmpl/prog/js/vue/dist/{main.js => erm.js} (100%) rename koha-tmpl/intranet-tmpl/prog/js/vue/dist/{main.js.LICENSE.txt => erm.js.LICENSE.txt} (100%) diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/dist/main.js b/koha-tmpl/intranet-tmpl/prog/js/vue/dist/erm.js similarity index 100% rename from koha-tmpl/intranet-tmpl/prog/js/vue/dist/main.js rename to koha-tmpl/intranet-tmpl/prog/js/vue/dist/erm.js diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/dist/main.js.LICENSE.txt b/koha-tmpl/intranet-tmpl/prog/js/vue/dist/erm.js.LICENSE.txt similarity index 100% rename from koha-tmpl/intranet-tmpl/prog/js/vue/dist/main.js.LICENSE.txt rename to koha-tmpl/intranet-tmpl/prog/js/vue/dist/erm.js.LICENSE.txt -- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This depends on bug 32609 which we haven't backported. Now.. I'm considering we perhaps should backport that to 22.11 for maintainability. I'll have a chat with Matt about this.. it's easy to miss these things and it falls on my bad tuition that he missed this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Bug 32806 depends on bug 32923, which changed state. Bug 32923 Summary: x-koha-embed must a header of collectionFormat csv https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This is an important release notes| |architectural improvement | |to aid in future | |maintenance and expansion | |of the Vue based modules | |(erm) not available in | |Koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Bug 32806 depends on bug 32923, which changed state. Bug 32923 Summary: x-koha-embed must a header of collectionFormat csv https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Bug 32806 depends on bug 32609, which changed state. Bug 32609 Summary: Remove compiled files from src https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org