[Bug 43237] New: 'Expand' column header doesn't appear consistently for collapsed responsive tables in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43237 Bug ID: 43237 Summary: 'Expand' column header doesn't appear consistently for collapsed responsive tables in the OPAC Initiative type: --- Sponsorship --- status: Product: Koha Version: 26.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: sbrown@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Depends on: 39698 Target Milestone: --- With the responsive tables introduced by Bug 39698, the Course Reserves table has an 'Expand' column header for the column with the '+' button, but others tables I've observed do not. All of them should have the 'Expand' header. Tables without the Expand header include: Holdings Patron's current checkouts Patron's current holds Patron's clubs Patron's checkout history Patron's search history Patron's charges (That list may not be exhaustive as I've only noted the tables that I've found are responsive.) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 [Bug 39698] Add option to expand responsive datatable rows by default -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43237 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41934 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43237 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|26.05 |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43237 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff Sponsorship status|--- |Sponsored Comma delimited| |Athens County Public list of Sponsors| |Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43237 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203804&action=edit Bug 43237: Add 'Expand' column header to all OPAC responsive DataTables This patch updates several templates in the OPAC so that when a responsive DataTable is partially collapsed, the column with the "+" buttons has "Expand" in the column header. To test, apply the patch and test tables on the affected pages, narrowing the page enough to confirm that when the table collapses, the last column has "Expand" in the header.: - Authorities search results - The details of a course reserve (with titles on reserve) - The holdings table on the bibliographic detail page - Search history - Most popular As a logged-in user: - User summary page (all tabs) - Curbside pickups (with at least one curbside pickup scheduled) - Checkout history - Suggestions - Tags In self-checkout: - The checkouts, holds, and charges tabs. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43237 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43237 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203804|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43237 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 203973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203973&action=edit Bug 43237: Add 'Expand' column header to all OPAC responsive DataTables This patch updates several templates in the OPAC so that when a responsive DataTable is partially collapsed, the column with the "+" buttons has "Expand" in the column header. To test, apply the patch and test tables on the affected pages, narrowing the page enough to confirm that when the table collapses, the last column has "Expand" in the header.: - Authorities search results - The details of a course reserve (with titles on reserve) - The holdings table on the bibliographic detail page - Search history - Most popular As a logged-in user: - User summary page (all tabs) - Curbside pickups (with at least one curbside pickup scheduled) - Checkout history - Suggestions - Tags In self-checkout: - The checkouts, holds, and charges tabs. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43237 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Couldn't get responsive "Expand" to appear (as not enough column data): - Authorities search results - Holdings table on a record page 2. Most popular: not sure how to get this to appear 3. User summary page - Article requests: - Enable ArticleRequests system preference - Place an article request 4. Curbside pickup: - Enable CurbsidePickup system preference - Configure: Administration > Patrons and circulation > Curbside pickups - Configure for Centerville: . Enable: ticked . Pickup interval: 5 . Maximum patrons per interval: 2 . Patron-scheduled pickup: ticked . Enable for waiting holds only: ticked . Curbside pickup hours: Add slots Monday to Friday from 8am to 5pm - Place a hold and check it in for koha so that it is waiting for pickup (I used CGI programming with Perl (11), 39999000000498) - Schedule the pickup: . Circulation > Holds and bookings > Curbside pickups . Schedule the pickup: Schedule pickup tab 5. Self-checkout: - Add a manual charge to koha's account and then pay it - Place a hold for koha in the staff interface - Check out an item to koha - Go to [OPACURL]/cgi-bin/koha/sco/sco-main.pl - Log in with koha and koha - Checkout item 39999000005134 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43237 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43237 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- To use t('Expand') for translation you need to call the helper, I think: Template/Plugin/I18N.pm ( [% USE I18N%] ) I did not follow all of the .inc to see if the parent template calls it. I do see it is missing in sco-main.tt, opac-topissues.tt, opac-tags.tt, and opac-suggestions.tt. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43237 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43237 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 204497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204497&action=edit Bug 43237: (follow-up) Adding [% PROCESS 'i18n.inc' %] to two templates which lack it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43237 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43237 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203973|0 |1 is obsolete| | Attachment #204497|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43237 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 206153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206153&action=edit Bug 43237: Add 'Expand' column header to all OPAC responsive DataTables This patch updates several templates in the OPAC so that when a responsive DataTable is partially collapsed, the column with the "+" buttons has "Expand" in the column header. To test, apply the patch and test tables on the affected pages, narrowing the page enough to confirm that when the table collapses, the last column has "Expand" in the header.: - Authorities search results - The details of a course reserve (with titles on reserve) - The holdings table on the bibliographic detail page - Search history - Most popular As a logged-in user: - User summary page (all tabs) - Curbside pickups (with at least one curbside pickup scheduled) - Checkout history - Suggestions - Tags In self-checkout: - The checkouts, holds, and charges tabs. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43237 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 206154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206154&action=edit Bug 43237: (follow-up) Adding [% PROCESS 'i18n.inc' %] to two templates which lack it Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43237 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43237 --- Comment #8 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org