[Bug 43117] New: t/Form_MessagingPreferences.t does not use Test::NoWarnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43117 Bug ID: 43117 Summary: t/Form_MessagingPreferences.t does not use Test::NoWarnings Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 34776 Target Milestone: --- From commit 6cc683b518223479f0c427a8305071fbd9581b5e Bug 34776: Unit tests -use Test::NoWarnings; -use Test::More tests => 2; +use Test::More tests => 1; +use Test::MockModule; +#use Test::NoWarnings; Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34776 [Bug 34776] Patron messaging preferences are lost when an error occurs during new account creation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43117 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|chris@bigballofwax.co.nz |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43117 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202193&action=edit Bug 43117: Adjust xt test to catch commented use Test::NoWarnings Patch from commit 383a673 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43117 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202194&action=edit Bug 43117: Restore use Test::NoWarnings From commit 6cc683b518223479f0c427a8305071fbd9581b5e Bug 34776: Unit tests -use Test::NoWarnings; -use Test::More tests => 2; +use Test::More tests => 1; +use Test::MockModule; +#use Test::NoWarnings; Test plan: Apply the first patch prove xt/use-test-no-warnings.t => FAIL Apply this patch prove xt/use-test-no-warnings.t => PASS prove t/Form_MessagingPreferences.t => PASS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43117 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43117 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202193|0 |1 is obsolete| | Attachment #202194|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43117 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 202195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202195&action=edit Bug 43117: Adjust xt test to catch commented use Test::NoWarnings Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43117 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 202196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202196&action=edit Bug 43117: Restore use Test::NoWarnings From commit 6cc683b518223479f0c427a8305071fbd9581b5e Bug 34776: Unit tests -use Test::NoWarnings; -use Test::More tests => 2; +use Test::More tests => 1; +use Test::MockModule; +#use Test::NoWarnings; Test plan: Apply the first patch prove xt/use-test-no-warnings.t => FAIL Apply this patch prove xt/use-test-no-warnings.t => PASS prove t/Form_MessagingPreferences.t => PASS Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43117 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43117 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43117 --- Comment #8 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org