[Bug 39930] New: Saved configuration states on tables cause extra columns to show
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Bug ID: 39930 Summary: Saved configuration states on tables cause extra columns to show Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: jrobb@sekls.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com This is hard to replicate but I did come across it on main in ktd. When "Save configuration state on page change" is enabled for a table, after an amount of time or some undetermined action, the table settings seem to go wonky. On the issues table at circ/circulation.pl for example, the grouping breaks and the sort_order and todays_or_previous_checkouts get revealed where they should be perma-hidden: Table showing columns that shouldn't be there: https://snipboard.io/TYL3Oe.jpg Table settings for that table: https://snipboard.io/kU7Tiw.jpg Column settings from local storage: https://snipboard.io/6aS8e4.jpg The steps that led to this were: 1. Set AlwaysLoadCheckoutsTable syspref to Do 2. Check out an item (39999000018516) to a patron (42) 3. Close the tab for a while (I didn't log out, just closed then reopened a few hours later) 4. Pull up the patron, extra mysterious columns have appeared This isn't isolated to the checkouts table, as we've come across it with saved reports and other tables that get saved states as well. Unchecking the save state box seems to avoid the problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 mteal@greenvillelibrary.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mteal@greenvillelibrary.org --- Comment #1 from mteal@greenvillelibrary.org --- We saw this in Acquisitions. When we search for Orders for a particular vendor, it shows a list of baskets. If you click on and open a basket, it correctly displays the orders table with the columns reflecting what is set up in Configuration. If you back arrow to get back to your list and select another basket, the columns remain correct. However, while you have a basket open, if you click on "Reopen basket", the Orders table displays with ALL the columns, even the ones selected to hide.
From that point on, it continues to show all the columns no matter what baskets I pull up. You have to log out of Koha and back in to get the columns to reset back to what's in Configuration. Unchecking Save configuration state on page change prevents the problem from happening.
-- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roman.dolny@jezuici.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | Severity|trivial |major CC| |jonathan.druart@gmail.com --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- I do recreate the problem on the orders table. When a basket is closed we lost 2 columns, DataTables cannot restore the state we previously stored (in localStorage) and use a default state: all columns displayed. I have not tried what Jason described on comment 0, but I guess it's a similar problem. It seems to be not trivial, at first glance I don't think we will be able to fix this globally, we will have to adjust the tables one by one. We will certainly one bug report per table. I was not aware of this bug, sorry to have missed it! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184625&action=edit Bug 39930: Fix SaveState on the orders table Test plan: Open and close a basket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- On the orders table the issue appears because we show/hide columns depending on some conditions (sysprefs or if the basket is closed/opened). DataTables cannot correctly restore the state because the number of columns stored in localStorage is different than the one we have one the table. The orders table is, I think, fixed by this patch. However I don't recreate the problem with the checkouts or reports. Could do try in a sandbox and provide a clear test plan to recreate the problem? Or give me another table where the problem appears? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Jason, would you be amenable to re-focusing this bug on just the acq orders table issue that Jonathan has recreated and patched? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 --- Comment #6 from Jason Robb <jrobb@sekls.org> --- (In reply to Andrew Fuerste-Henry from comment #5)
Jason, would you be amenable to re-focusing this bug on just the acq orders table issue that Jonathan has recreated and patched?
It's cool with me if it helps the fix for the orders table move along. I did go through the steps I listed in my original bug report with an up-to-date ktd and it's still happening for me on the checkouts table. I did steps 1-3, then left it overnight and when I pulled the table up in the morning the extra columns had appeared. Not sure if its related but I noticed in the DataTables documentation that the default value for stateDuration is 7200 so maybe 2 hours is the minimum amount of time that needs to elapse between steps 3 and 4 to see the issue? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jason Robb from comment #6)
(In reply to Andrew Fuerste-Henry from comment #5)
Jason, would you be amenable to re-focusing this bug on just the acq orders table issue that Jonathan has recreated and patched?
It's cool with me if it helps the fix for the orders table move along.
I did go through the steps I listed in my original bug report with an up-to-date ktd and it's still happening for me on the checkouts table. I did steps 1-3, then left it overnight and when I pulled the table up in the morning the extra columns had appeared.
Not sure if its related but I noticed in the DataTables documentation that the default value for stateDuration is 7200 so maybe 2 hours is the minimum amount of time that needs to elapse between steps 3 and 4 to see the issue?
Good catch, I have tried to set it to 60s and I do recreate the problem easily now. I will be back here soon. I think the only solution would be to extend the stateDuration value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED Summary|Saved configuration states |Saved configuration states |on tables cause extra |on tables are lost |columns to show |overnight -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40753 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #3)
Created attachment 184625 [details] [review] Bug 39930: Fix SaveState on the orders table
Test plan: Open and close a basket
Moved to bug 40753. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33484 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 [Bug 33484] Ability to remember user's selected table configuration and search filters for tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186139&action=edit Bug 39930: Prevent DT's state to be lost overnight The default value for stateDuration is 7200 (2h). Which means DataTables will ignore the saved state if reused after this delay. Additionally is causes problem on some tables where the default state is not restored and all columns are displayed.
Please note that the value is given in seconds. The value 0 is a special value
as it indicates that the state can be stored and retrieved indefinitely with no
time limit.
We are going to set it to 0 so that the state is only lost/reset after a logout Test plan: Ideally you can should edit this file and set saveState to 60 (seconds), so it's easy to test. Do not apply this patch and confirm that the state is not restored after either 60s or 2h (if you modified the file or not). It is a problem on the checkout list table as extra columns (like "Today's checkouts") are displayed. With this patch applied the state should be restored correctly. If you logout the state will be lost however. Ideally we might want to store user's preferences on the server. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184625|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Lin Wei <lin-wei.li@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Lin Wei <lin-wei.li@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186139|0 |1 is obsolete| | --- Comment #10 from Lin Wei <lin-wei.li@inLibro.com> --- Created attachment 186182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186182&action=edit Bug 39930: Prevent DT's state to be lost overnight The default value for stateDuration is 7200 (2h). Which means DataTables will ignore the saved state if reused after this delay. Additionally is causes problem on some tables where the default state is not restored and all columns are displayed.
Please note that the value is given in seconds. The value 0 is a special value
as it indicates that the state can be stored and retrieved indefinitely with no
time limit.
We are going to set it to 0 so that the state is only lost/reset after a logout Test plan: Ideally you can should edit this file and set saveState to 60 (seconds), so it's easy to test. Do not apply this patch and confirm that the state is not restored after either 60s or 2h (if you modified the file or not). It is a problem on the checkout list table as extra columns (like "Today's checkouts") are displayed. With this patch applied the state should be restored correctly. If you logout the state will be lost however. Ideally we might want to store user's preferences on the server. Signed-off-by: Ludovic Julien <ludovic.julien@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Ludovic <ludovic.julien@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ludovic.julien@inLibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186182|0 |1 is obsolete| | --- Comment #11 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 186238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186238&action=edit Bug 39930: Prevent DT's state to be lost overnight The default value for stateDuration is 7200 (2h). Which means DataTables will ignore the saved state if reused after this delay. Additionally is causes problem on some tables where the default state is not restored and all columns are displayed.
Please note that the value is given in seconds. The value 0 is a special value
as it indicates that the state can be stored and retrieved indefinitely with no
time limit.
We are going to set it to 0 so that the state is only lost/reset after a logout Test plan: Ideally you can should edit this file and set saveState to 60 (seconds), so it's easy to test. Do not apply this patch and confirm that the state is not restored after either 60s or 2h (if you modified the file or not). It is a problem on the checkout list table as extra columns (like "Today's checkouts") are displayed. With this patch applied the state should be restored correctly. If you logout the state will be lost however. Ideally we might want to store user's preferences on the server. Signed-off-by: Ludovic Julien <ludovic.julien@inLibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 --- Comment #13 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #14 from Mathieu Saby <mathsabypro@gmail.com> --- It is affecting our 24.11. Could it be pushed to 24.11.x ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Ashley Hernandez <ahernandez@ckls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ahernandez@ckls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- On it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|25.11.00,25.05.04 |25.11.00,25.05.04,24.11.10 released in| | --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Lucy Vaux-Harvey <lucy.vaux-harvey@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey@openfifth. | |co.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |Needs documenting --- Comment #17 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #18 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org