[Bug 25137] New: PatronSelfRegistrationLibraryList results in empty branch list on opac-memberentry.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 Bug ID: 25137 Summary: PatronSelfRegistrationLibraryList results in empty branch list on opac-memberentry.pl Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Putting any value into PatronSelfRegistrationLibraryList results in a completely empty branch list on opac-memberentry.pl for both self-reg and self-mod. To Test: - confirm you have a branch with code X - confirm PatronSelfRegistrationBorrowerUnwantedField and PatronSelfModificationBorrowerUnwantedField are empty - enter X in PatronSelfRegistrationLibraryList - go to cgi-bin/koha/opac-memberentry.pl (either as a logged in patron or as a self-reg patron) - confirm branch dropdown is empty - empty out PatronSelfRegistrationLibraryList - reload cgi-bin/koha/opac-memberentry.pl and confirm branches show Found this while trying to test a bug around this same syspref in 19.05, bug 25136 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |23084 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by commit 82716a01727f143ba2c167cd86233a531f330390 Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@bugs.koha-c | |ommunity.org Version|19.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102917&action=edit Bug 25137: (bug 23084 follow-up) Fix incorrect grep ternary condition The lack of parenthesis makes the condition evaluated wrong. Test plan: - confirm you have a branch with code X - enter X in PatronSelfRegistrationLibraryList - go to cgi-bin/koha/opac-memberentry.pl (either as a logged in patron or as a self-reg patron) - confirm branch dropdown is not empty and contain X - empty out PatronSelfRegistrationLibraryList - reload cgi-bin/koha/opac-memberentry.pl and confirm branches show -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- @QA I did check the other occurrences modified by bug 23084 and they appear correct. Another look would be good anyway! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Was the lack of () the reason? If that is the case perhaps C4/Utils/DataTables/Members.pm lines 59/60 Why write a logical test not surrounded by parenthesis? Tested, fix the error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102917|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 102921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102921&action=edit Bug 25137: (bug 23084 follow-up) Fix incorrect grep ternary condition The lack of parenthesis makes the condition evaluated wrong. Test plan: - confirm you have a branch with code X - enter X in PatronSelfRegistrationLibraryList - go to cgi-bin/koha/opac-memberentry.pl (either as a logged in patron or as a self-reg patron) - confirm branch dropdown is not empty and contain X - empty out PatronSelfRegistrationLibraryList - reload cgi-bin/koha/opac-memberentry.pl and confirm branches show Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Bernardo Gonzalez Kriegel from comment #4)
Was the lack of () the reason? If that is the case perhaps C4/Utils/DataTables/Members.pm lines 59/60
Why write a logical test not surrounded by parenthesis?
Tested, fix the error.
Good catch, you found a data leak issue :) Follow-up coming. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|PatronSelfRegistrationLibra |Wrong replacements of grep |ryList results in empty |by bug 23084 |branch list on | |opac-memberentry.pl | Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Wrong replacements of grep |PatronSelfRegistrationLibra |by bug 23084 |ryList results in empty | |branch list on | |opac-memberentry.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Opened bug 25142. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102921|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102951&action=edit Bug 25137: (bug 23084 follow-up) Fix incorrect grep ternary condition The lack of parenthesis makes the condition evaluated wrong. Test plan: - confirm you have a branch with code X - enter X in PatronSelfRegistrationLibraryList - go to cgi-bin/koha/opac-memberentry.pl (either as a logged in patron or as a self-reg patron) - confirm branch dropdown is not empty and contain X - empty out PatronSelfRegistrationLibraryList - reload cgi-bin/koha/opac-memberentry.pl and confirm branches show Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_candidate | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25136 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 [Bug 25136] PatronSelfRegistrationLibraryList controls both self-reg and self-modification -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #11 from Joy Nelson <joy@bywatersolutions.com> --- missing dependencies - not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 Bug 25137 depends on bug 23084, which changed state. Bug 23084 Summary: Replace grep {^$var$} with grep {$var eq $_} https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org