[Bug 10851] New: Add missing statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Bug ID: 10851 Summary: Add missing statuses Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com The serial module provide some status for serials. The missing status usually is not enough to describe the real status. We will suggest to add 4 new statuses for missing serials: never receipt, sold out, defective or lost. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, I think maybe check the status names with a native speaker? I couldn't make sense of defective :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20936&action=edit Bug 10851: Serials - Add missing statuses 4 new missing statuses is added by this patch: never receipt, sold out, defective or lost. These status have the same behavior than the simple Missing status. Test plan: - Find a serial to claim. - Modify the status of this serial with one of these new statuses. - Try to find it with the "serials to claim" search. - Verify that the status is displayed on the serial module pages and on the OPAC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #1)
Hi Jonathan, I think maybe check the status names with a native speaker? I couldn't make sense of defective :(
What do you propose? I had a choice with defective, faulty, flawed, cracked, etc. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- What about damaged? And I think maybe Never received? But I think we really need a native speaker here :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to Jonathan Druart from comment #3)
(In reply to Katrin Fischer from comment #1)
Hi Jonathan, I think maybe check the status names with a native speaker? I couldn't make sense of defective :(
What do you propose? I had a choice with defective, faulty, flawed, cracked, etc. :)
I see what you were looking for. How about "damaged"? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20936|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20958&action=edit Bug 10851: Serials - Add missing statuses 4 new missing statuses is added by this patch: never received, sold out, damaged or lost. These status have the same behavior than the simple Missing status. Test plan: - Find a serial to claim. - Modify the status of this serial with one of these new statuses. - Try to find it with the "serials to claim" search. - Verify that the status is displayed on the serial module pages and on the OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Jared Camins-Esakov from comment #5)
What do you propose? I had a choice with defective, faulty, flawed, cracked, etc. :)
I see what you were looking for. How about "damaged"?
Go for "damaged"! Last patch replaces "defective" with "damaged" and "never receipt" with "never received". Thank you Katrin & Jared! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #8 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply When did the bot|2013-09-29 00:00:00 |2013-10-27 last check this| | --- Comment #9 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 10851: Serials - Add missing statuses Using index info to reconstruct a base tree... M C4/Serials.pm M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt M koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt M koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt M koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging C4/Serials.pm Patch failed at 0001 Bug 10851: Serials - Add missing statuses The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20958|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22460&action=edit Bug 10851: Serials - Add missing statuses -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22460|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22593&action=edit Bug 10851: Serials - Add missing statuses 4 new missing statuses is added by this patch: never received, sold out, damaged or lost. These status have the same behavior than the simple Missing status. Test plan: - Find a serial to claim. - Modify the status of this serial with one of these new statuses. - Try to find it with the "serials to claim" search. - Verify that the status is displayed on the serial module pages and on the OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #12 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to Jonathan Druart from comment #11)
Created attachment 22593 [details] [review] Bug 10851: Serials - Add missing statuses
4 new missing statuses is added by this patch: never received, sold out, damaged or lost.
These status have the same behavior than the simple Missing status.
Test plan: - Find a serial to claim. - Modify the status of this serial with one of these new statuses. - Try to find it with the "serials to claim" search. - Verify that the status is displayed on the serial module pages and on the OPAC.
Hi I'm not sure to understand "sold out". I suppose you mean sold by the library to a user? If your goal was to make available for serial issues the same kind of status as we have for monographs, don't you think a "withdrawn" status could be interesting too? But maybe it is the idea behind "Missing (damaged)" ? Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 --- Comment #13 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Other points: If the meaning of "Missing" before your patch was always "never received", maybe you should rename "Missing" into "Missing (never received)", instead of creating a new one? If I understand well,the new statuses (except "never received") are supposed to be assigned to an issue that was fist received, and later disapeared from collection for some reason. I think this could be written somewhere, for ex. in online help. And the manual could be improved too. I think your patch could be useful, but I would prefer to have the opinion of somebody with a strong knowledge of Serial module. As I'm not at all an Serials expert, I don't feel confident enough to sign off or not. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to mathieu saby from comment #12)
I'm not sure to understand "sold out". I suppose you mean sold by the library to a user?
No, the serial has not been received because it is sold out (ie. the publisher has sold all serials). (In reply to mathieu saby from comment #13)
Other points: If the meaning of "Missing" before your patch was always "never received", maybe you should rename "Missing" into "Missing (never received)", instead of creating a new one?
Maybe yes, maybe no. Maybe some libraries would like not to give a specific reason and to keep the generic one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 --- Comment #15 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to Jonathan Druart from comment #14)
(In reply to mathieu saby from comment #12)
I'm not sure to understand "sold out". I suppose you mean sold by the library to a user?
No, the serial has not been received because it is sold out (ie. the publisher has sold all serials).
Ahh, it means "en rupture de stock". OK! I need to improve my english ;-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 nicolas <nicolas.bravais@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nicolas.bravais@gmail.com --- Comment #16 from nicolas <nicolas.bravais@gmail.com> --- Patch apply correctly (tested with all the new status in OPAC, "serials to claim" and on the serials module page) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22593|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24119&action=edit Bug 10851: Serials - Add missing statuses 4 new missing statuses is added by this patch: never received, sold out, damaged or lost. These status have the same behavior than the simple Missing status. Test plan: - Find a serial to claim. - Modify the status of this serial with one of these new statuses. - Try to find it with the "serials to claim" search. - Verify that the status is displayed on the serial module pages and on the OPAC. Signed-off-by: Nicolas Bravais <nicolas.bravais@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, I have some fails in the QA script, but not sure what it means: FAIL C4/Serials.pm OK pod OK forbidden patterns FAIL valid Useless use of a constant (43) in void context Useless use of a constant (41) in void context Useless use of a constant (44) in void context Useless use of a constant (42) in void context Useless use of a constant (4) in void context OK critic Could you take a look? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24593&action=edit Bug 10851: FIX QA issues This patch fixes following warnings: FAIL C4/Serials.pm FAIL valid Useless use of a constant (43) in void context Useless use of a constant (41) in void context Useless use of a constant (44) in void context Useless use of a constant (42) in void context Useless use of a constant (4) in void context -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry Jonathan, but there is a problem: - I have a subscription with 3 issues: - Arrived - Missing (sold out) - Expected When I go to the staff detail page, 2 issues are shown in the subscription tab. Only the "Arrived" status displays, the other status that should be "Missing (sold out)" is empty. On the OPAC detail page the display is ok. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Everything else I checked so far was ok, copying my testing notes here for later use :) Checked: - Receiving issues, setting and unsetting new status - Display on serial summary page - Display on subscription detail page, issues tab - Display on OPAC and staff detail pages, subscription tab OPAC: ok Staff: NOT OK - Missing status not shown - Claiming issues, filtering and status display -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24736&action=edit Bug 10851: (follow-up) FIX bad c/p (variable name) In catalogue.detail.tt, a wrong variable loop was used. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #20)
When I go to the staff detail page, 2 issues are shown in the subscription tab. Only the "Arrived" status displays, the other status that should be "Missing (sold out)" is empty. On the OPAC detail page the display is ok.
Hi Katrin, I used a bad variable name, sorry. It should be fixed with the follow-up. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24119|0 |1 is obsolete| | Attachment #24593|0 |1 is obsolete| | Attachment #24736|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24987&action=edit [PASSED QA] Bug 10851: Serials - Add missing statuses 4 new missing statuses is added by this patch: never received, sold out, damaged or lost. These status have the same behavior than the simple Missing status. Test plan: - Find a serial to claim. - Modify the status of this serial with one of these new statuses. - Try to find it with the "serials to claim" search. - Verify that the status is displayed on the serial module pages and on the OPAC. Signed-off-by: Nicolas Bravais <nicolas.bravais@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24988&action=edit [PASSED QA] Bug 10851: FIX QA issues This patch fixes following warnings: FAIL C4/Serials.pm FAIL valid Useless use of a constant (43) in void context Useless use of a constant (41) in void context Useless use of a constant (44) in void context Useless use of a constant (42) in void context Useless use of a constant (4) in void context Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24989&action=edit [PASSED QA] Bug 10851: (follow-up) FIX bad c/p (variable name) In catalogue.detail.tt, a wrong variable loop was used. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> APatches pass QA script and tests. Additional tests done: - Receiving issues, setting and unsetting new status - Display on serial summary page - Display on subscription detail page, issues tab - Display on OPAC and staff detail pages, subscription tab OPAC: ok Staff: ok - Claiming issues, filtering and status display -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #27 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 --- Comment #28 from Galen Charlton <gmcharlt@gmail.com> --- I don't like the way serials.status uses magic numbers, so I've opened bug 11682. Comments welcome. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11682 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11689 --- Comment #29 from Jonathan Druart <jonathan.druart@biblibre.com> --- This enhancement introduced an issue, please see bug 11689. Patch coming soon. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fcapovilla@live.ca --- Comment #30 from Frédérick Capovilla <fcapovilla@live.ca> --- *** Bug 11822 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org