[Bug 6520] New: Items don't display when viewing staged records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Bug #: 6520 Summary: Items don't display when viewing staged records Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Staff Client AssignedTo: paul.poulain@biblibre.com ReportedBy: jcamins@cpbibliography.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com When you view a staged record, even if you're adding items, the items don't show up because they're no longer included in the bib record's marc. They should be added in for display purposes. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.6 |master --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- This bug is still valid in master as of 3.12 beta1. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37310&action=edit Bug 6520: Display items for staged record When records are imported into Koha, the items is stored into the import_items table. This marcxml in this table is never retrieved to display items. Test plan: 1/ Import a records with items 2/ Before importing the batch into the catalog, you can see the marc of the records, in the table below. 3/ Verify that the items is correctly displayed. QA note: This patch does not provide test for new subroutines but the module (C4::ImportBatch) is not tested at all and it will be time consuming to provide them. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37310|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37311&action=edit Bug 6520: Display items for staged record When records are imported into Koha, the items is stored into the import_items table. This marcxml in this table is never retrieved to display items. Test plan: 1/ Import a records with items 2/ Before importing the batch into the catalog, you can see the marc of the records, in the table below. 3/ Verify that the items is correctly displayed. QA note: This patch does not provide test for new subroutines but the module (C4::ImportBatch) is not tested at all and it will be time consuming to provide them. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff Client |Tools CC| |jonathan.druart@biblibre.co | |m Assignee|paul.poulain@biblibre.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37311|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 37344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37344&action=edit Bug 6520: Display items for staged record When records are imported into Koha, the items is stored into the import_items table. This marcxml in this table is never retrieved to display items. Test plan: 1/ Import a records with items 2/ Before importing the batch into the catalog, you can see the marc of the records, in the table below. 3/ Verify that the items is correctly displayed. QA note: This patch does not provide test for new subroutines but the module (C4::ImportBatch) is not tested at all and it will be time consuming to provide them. Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Status|Signed Off |Needs Signoff --- Comment #5 from Nicole C. Engard <nengard@gmail.com> --- Processing files before patches |========================>| 2 / 2 (100.00%) Processing files after patches |========================>| 2 / 2 (100.00%) OK C4/ImportBatch.pm OK critic OK forbidden patterns OK pod OK valid OK catalogue/showmarc.pl OK critic OK forbidden patterns OK pod OK valid -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I found t/db_dependent/ImportBatch.t, but it only includes 5 tests. Maybe they could be a starting point? I am a bit worried by the mismatch of the MARC view with the new diff view. Could we also include the item information in the new diff view? Please read 'Failed QA' as 'Asking for feedback' - tests looking ok so far :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37540&action=edit Bug 6520: Display items for staged record - diff view This patchs adds the item information in the diff view. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37544&action=edit Bug 6520: Add unit test for C4::ImportBatch::GetRecordFromImportBiblio -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 37552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37552&action=edit [PASSED QA] Bug 6520: Display items for staged record When records are imported into Koha, the items is stored into the import_items table. This marcxml in this table is never retrieved to display items. Test plan: 1/ Import a records with items 2/ Before importing the batch into the catalog, you can see the marc of the records, in the table below. 3/ Verify that the items is correctly displayed. QA note: This patch does not provide test for new subroutines but the module (C4::ImportBatch) is not tested at all and it will be time consuming to provide them. Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 37553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37553&action=edit [PASSED QA] Bug 6520: Display items for staged record - diff view This patchs adds the item information in the diff view. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 37554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37554&action=edit [PASSED QA] Bug 6520: Add unit test for C4::ImportBatch::GetRecordFromImportBiblio Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37344|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37544|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37540|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org