[Bug 21304] New: Update two-column templates with Bootstrap grid: Catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Bug ID: 21304 Summary: Update two-column templates with Bootstrap grid: Catalog Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 20654 This patch will convert even more acquisitions templates to use the Bootstrap grid: - ISBDdetail.tt - MARCdetail.tt - detail.tt - imageviewer.tt - issuehistory.tt - labeledMARCdetail.tt - moredetail.tt - results.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 78343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78343&action=edit Bug 21304: Update two-column templates with Bootstrap grid: Catalog This patch modifies several catalog templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Catalog -> Search - Search results - Bibliographic details - MARC details (viewMARC preference enabled) - Labeled MARC details (viewLabeledMARC preference enabled) - ISBD (viewISBD preference enabled) - Items - Checkout history -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Cab Vinton <bibliwho@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho@gmail.com --- Comment #2 from Cab Vinton <bibliwho@gmail.com> --- Created attachment 78375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78375&action=edit Next record glitch All looks good except for the Return to Results display. For all examples Next Record is offset on the next line rather than on the same line as Previous Record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 78437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78437&action=edit Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 pierre-marc.thibault@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-marc.thibault@inlibr | |o.com --- Comment #4 from pierre-marc.thibault@inlibro.com --- Created attachment 78491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78491&action=edit Next button of the controls in an awkward position. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 pierre-marc.thibault@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from pierre-marc.thibault@inlibro.com --- Controls have been tested with the first and last result. The next button is still in an awkward position when the size is small. When the Next button is inactive and its area become bigger, not all the area is colored in grey because the grey area width is fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 pierre-marc.thibault@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from pierre-marc.thibault@inlibro.com --- Sorry. I assumed CSS files has been changed while SCSS has been and oversee your mention to regenerate CSS. Tests will be redo to validate the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 --- Comment #7 from pierre-marc.thibault@inlibro.com --- Created attachment 78494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78494&action=edit Previous and Next buttons a little hidden at a certain size. There is no longer a problem with the Next button at an awkward position. However, when the browser reach a certain size, the buttons text Previous and Next can be partially covered. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 pierre-marc.thibault@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78343|0 |1 is obsolete| | Attachment #78437|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79184&action=edit Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78343|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78343|0 |1 is obsolete| | Attachment #79184|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 80405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80405&action=edit Bug 21304: Update two-column templates with Bootstrap grid: Catalog This patch modifies several catalog templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Catalog -> Search - Search results - Bibliographic details - MARC details (viewMARC preference enabled) - Labeled MARC details (viewLabeledMARC preference enabled) - ISBD (viewISBD preference enabled) - Items - Checkout history -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 80406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80406&action=edit Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80405|0 |1 is obsolete| | Attachment #80406|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 81192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81192&action=edit Bug 21304: Update two-column templates with Bootstrap grid: Catalog This patch modifies several catalog templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Catalog -> Search - Search results - Bibliographic details - MARC details (viewMARC preference enabled) - Labeled MARC details (viewLabeledMARC preference enabled) - ISBD (viewISBD preference enabled) - Items - Checkout history - Rota (stock rotation) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 81193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81193&action=edit Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 --- Comment #13 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 81192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81192 Bug 21304: Update two-column templates with Bootstrap grid: Catalog Review of attachment 81192: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21304&attachment=81192) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt @@ +620,5 @@
+ </div> <!-- /.col-sm-10.col-sm-push-2 --> + + <div class="col-sm-2 col-sm-pull-10"> + <aside> + [% INCLUDE 'admin-menu.inc' %]
This should be facets.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #14 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 82179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82179&action=edit Search results There is a glitch in search results, see screenshot -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81192|0 |1 is obsolete| | Attachment #81193|0 |1 is obsolete| | --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82186&action=edit Bug 21304: Update two-column templates with Bootstrap grid: Catalog This patch modifies several catalog templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Catalog -> Search - Search results - Bibliographic details - MARC details (viewMARC preference enabled) - Labeled MARC details (viewLabeledMARC preference enabled) - ISBD (viewISBD preference enabled) - Items - Checkout history - Rota (stock rotation) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82187&action=edit Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Josef Moravec from comment #14)
There is a glitch in search results, see screenshot
I've fixed the facet.inc error in the newly-added patches, but I haven't addressed this issue. I think this problem only happens after you've changed the width of the browser and buttons in the toolbar have wrapped to a new line. I think this is a relatively uncommon sequence of events, and a page refresh fixes it. This problem needs to be fixed globally for every page which has a floating toolbar (see also Bug 21751). I'm leaning towards suggesting we accept this glitch and work on a follow-up, but I understand if y'all disagree. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21948 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 [Bug 21948] Clean up style of item detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22032 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22032 [Bug 22032] Improve local cover image tab on detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82186|0 |1 is obsolete| | Attachment #82187|0 |1 is obsolete| | --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84704&action=edit Bug 21304: Update two-column templates with Bootstrap grid: Catalog This patch modifies several catalog templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Catalog -> Search - Search results - Bibliographic details - MARC details (viewMARC preference enabled) - Labeled MARC details (viewLabeledMARC preference enabled) - ISBD (viewISBD preference enabled) - Items - Checkout history - Rota (stock rotation) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84705&action=edit Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84704|0 |1 is obsolete| | Attachment #84705|0 |1 is obsolete| | --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 85980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85980&action=edit Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85980|0 |1 is obsolete| | --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86015&action=edit Bug 21304: Update two-column templates with Bootstrap grid: Catalog This patch modifies several catalog templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Catalog -> Search - Search results - Bibliographic details - MARC details (viewMARC preference enabled) - Labeled MARC details (viewLabeledMARC preference enabled) - ISBD (viewISBD preference enabled) - Items - Checkout history - Rota (stock rotation) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86016&action=edit Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86015|0 |1 is obsolete| | Attachment #86016|0 |1 is obsolete| | --- Comment #23 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 86022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86022&action=edit Bug 21304: Update two-column templates with Bootstrap grid: Catalog This patch modifies several catalog templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Catalog -> Search - Search results - Bibliographic details - MARC details (viewMARC preference enabled) - Labeled MARC details (viewLabeledMARC preference enabled) - ISBD (viewISBD preference enabled) - Items - Checkout history - Rota (stock rotation) Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 --- Comment #24 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 86023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86023&action=edit Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result. Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86022|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 86126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86126&action=edit Bug 21304: Update two-column templates with Bootstrap grid: Catalog This patch modifies several catalog templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Catalog -> Search - Search results - Bibliographic details - MARC details (viewMARC preference enabled) - Labeled MARC details (viewLabeledMARC preference enabled) - ISBD (viewISBD preference enabled) - Items - Checkout history - Rota (stock rotation) Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86023|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 86127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86127&action=edit Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Failed QA --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- After applying I get a JS error on search results: TypeError: c is null[Learn More] hc-sticky_18.1200027.js:11:4777 And I have no button to select records in the search results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 --- Comment #28 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86753&action=edit Bug 21304: (follow-up) Correct hc-sticky configuration This patch corrects the element passed to the hc-sticky plugin to define which element the floating toolbar sticks to. To test, apply the patch and perform a search in the staff client which will return multiple results. Confirm that scrolling down the page triggers the floating toolbar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #29 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org