[Bug 23253] New: OpacNavRight does not display if opacuserlogin disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 Bug ID: 23253 Summary: OpacNavRight does not display if opacuserlogin disabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Bug 22318 moved the content of OpacNavRight to a 'news' item to aid in translatability. C4/Auth.pm still looks for the OpacNavRight system preference to determine if there is content opac-main.tt checks the value form C4/Auth.pm to set the correct spans To recreate: 1 - Add a news items with location 'OpacNavRight' 2 - View the catalog, it should show correctly 3 - Disable opacuserlogin 4 - The news item no longer appears 5 - git grep OpacNavRight 6 - Note occurrences of reference to the system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22318 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 [Bug 22318] Extend Koha news feature to include other content areas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91996&action=edit Bug 23253: (bug 22318 follow-up) Fix OpacNavRight even if opacuserlogin is off There are other occurrences of OpavNavRight that bug 22318 forgot to adjust to use the news system instead of the syspref. Test plan: - turn off opacuserlogin - create a news for OpacNavRight - go to the opac main page => Confirm that the OpacNavRight content is displayed correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91997&action=edit Bug 23253: Fix OpacNavRight for self reg by email The code expects to display OpacNavRight content at the bottom of the login form when a user just registered. Test plan: - Turn PatronSelfRegistrationVerifyByEmail on - Register a patron - Confirm by clicking on the link you received by email (or see the message_queue table) => The OpacNavRight content should be displayed QA Note: This code smells, the code in the pl should not be needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@bugs.koha-c | |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91996|0 |1 is obsolete| | Attachment #91997|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92034&action=edit Bug 23253: (bug 22318 follow-up) Fix OpacNavRight even if opacuserlogin is off There are other occurrences of OpavNavRight that bug 22318 forgot to adjust to use the news system instead of the syspref. Test plan: - turn off opacuserlogin - create a news for OpacNavRight - go to the opac main page => Confirm that the OpacNavRight content is displayed correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92035&action=edit Bug 23253: Fix OpacNavRight for self reg by email The code expects to display OpacNavRight content at the bottom of the login form when a user just registered. Test plan: - Turn PatronSelfRegistrationVerifyByEmail on - Register a patron - Confirm by clicking on the link you received by email (or see the message_queue table) => The OpacNavRight content should be displayed QA Note: This code smells, the code in the pl should not be needed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92034|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92035|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 92194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92194&action=edit Bug 23253: (bug 22318 follow-up) Fix OpacNavRight even if opacuserlogin is off There are other occurrences of OpavNavRight that bug 22318 forgot to adjust to use the news system instead of the syspref. Test plan: - turn off opacuserlogin - create a news for OpacNavRight - go to the opac main page => Confirm that the OpacNavRight content is displayed correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 92195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92195&action=edit Bug 23253: Fix OpacNavRight for self reg by email The code expects to display OpacNavRight content at the bottom of the login form when a user just registered. Test plan: - Turn PatronSelfRegistrationVerifyByEmail on - Register a patron - Confirm by clicking on the link you received by email (or see the message_queue table) => The OpacNavRight content should be displayed QA Note: This code smells, the code in the pl should not be needed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|OpacNavRight does not |OpacNavRight does not |display if opacuserlogin |display correctly for |disabled |opacuserlogin disabled or | |self registration --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I actually think the follow-up would have made a separate bug ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92194|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92210&action=edit Bug 23253: (bug 22318 follow-up) Fix OpacNavRight even if opacuserlogin is off There are other occurrences of OpavNavRight that bug 22318 forgot to adjust to use the news system instead of the syspref. Test plan: - turn off opacuserlogin - create a news for OpacNavRight - go to the opac main page => Confirm that the OpacNavRight content is displayed correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92195|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92211&action=edit Bug 23253: Fix OpacNavRight for self reg by email The code expects to display OpacNavRight content at the bottom of the login form when a user just registered. Test plan: - Turn PatronSelfRegistrationVerifyByEmail on - Register a patron - Confirm by clicking on the link you received by email (or see the message_queue table) => The OpacNavRight content should be displayed QA Note: This code smells, the code in the pl should not be needed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.03 released in| | --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- no backported needed for 18.11.x, missing dependency. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org