[Bug 23455] New: Patron Card printing from Patron Lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23455 Bug ID: 23455 Summary: Patron Card printing from Patron Lists Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger@foundations.edu Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Koha gives the ability to print Patron cards from the Patron Lists tool. To recreate 1. Go to a Patron List, use Actions 2. choose Print Patron Cards. 3. Once a layout and template have been chosen, Koha gives the box to Print Patron cards, but this box is empty. No PDF is loaded or displayed and there are no options within this screen. Using the Patron Card creator and choosing a Patron List does work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23455 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23455 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org Severity|normal |major --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Broken feature - confirmed. Funnily, there is no error in the plack-error-log or the console, the xhr request response is: Click on the link to download the patron cards from the patron list. label_patronlist_1.pdf But we are not seeing it. Adding Owen as I tihnk this might be an issue template/Javascript side? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23455 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron Card printing from |Patron card printing from |Patron Lists |Patron lists is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23455 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|cnighswonger@foundations.ed |oleonard@myacpl.org |u | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Git bisect blames me and Bug 20650. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23455 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Bad Owen ;) Do you have an idea what's going on? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23455 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23455 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23455 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92239&action=edit Bug 23455: Patron card printing from Patron lists is broken This patch makes a few corrections to the process of printing patron cards from the patron lists page. These changes are necessitated by Bug 20650: Changes to the markup in patroncards/print.tt were not reflected in the JavaScript in patron_lists/lists.tt. Also fixed: A missing quotation mark, a missing semicolon, and incorrect template variable filter. To test, apply the patch and go to Tools -> Patron lists. - Click the "Actions" menu corresponding to a patron list. - Select "Print patron cards." - In the "Print patron cards" modal, click the "Export" button. - The modal should reload with a link to download a patron card PDF. The link should work correctly. https://bugs.koha-community.org/show_bug.cgi?id=23445 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23455 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23455 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92239|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92245&action=edit Bug 23455: Patron card printing from Patron lists is broken This patch makes a few corrections to the process of printing patron cards from the patron lists page. These changes are necessitated by Bug 20650: Changes to the markup in patroncards/print.tt were not reflected in the JavaScript in patron_lists/lists.tt. Also fixed: A missing quotation mark, a missing semicolon, and incorrect template variable filter. To test, apply the patch and go to Tools -> Patron lists. - Click the "Actions" menu corresponding to a patron list. - Select "Print patron cards." - In the "Print patron cards" modal, click the "Export" button. - The modal should reload with a link to download a patron card PDF. The link should work correctly. https://bugs.koha-community.org/show_bug.cgi?id=23445 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23455 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wonder if we could do without the: Click on the link to download the patron cards from the patron list And Instead just add a "Download.... to the displayed link. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23455 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23455 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92245|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 92257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92257&action=edit Bug 23455: Patron card printing from Patron lists is broken This patch makes a few corrections to the process of printing patron cards from the patron lists page. These changes are necessitated by Bug 20650: Changes to the markup in patroncards/print.tt were not reflected in the JavaScript in patron_lists/lists.tt. Also fixed: A missing quotation mark, a missing semicolon, and incorrect template variable filter. To test, apply the patch and go to Tools -> Patron lists. - Click the "Actions" menu corresponding to a patron list. - Select "Print patron cards." - In the "Print patron cards" modal, click the "Export" button. - The modal should reload with a link to download a patron card PDF. The link should work correctly. https://bugs.koha-community.org/show_bug.cgi?id=23445 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23455 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Depends on| |20650 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20650 [Bug 20650] Switch single-column templates to Bootstrap grid: Various, part 3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23455 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23455 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23455 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.03 released in| | --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23455 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.09 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org