[Bug 27522] New: Adding new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Bug ID: 27522 Summary: Adding new itemtype info image to carredart Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: vfaafia29@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #1 from Victoria Faafia <vfaafia29@gmail.com> --- Created attachment 115642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115642&action=edit adding itemtype image -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Victoria Faafia <vfaafia29@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Victoria Faafia <vfaafia29@gmail.com> --- Bug 27522: Adding new itemtype info image to carredart Test Plan 1. Go to Administration>Item Types>Modify Item Type 2. Under carredart you should see an info item type -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As the itemtype images can be displayed in the OPAC and in the staff interface we currently need to add them in 2 places as one cannot access the image files of the other. Can you also add the files to koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/carredart please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115706&action=edit Bug 27522: (follow-up) Add copy of image to carredart icons in the OPAC https://bugs.koha-community.org/show_bug.cgi?id=27505 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115706|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115707&action=edit Bug 27522: (follow-up) Add copy of image to carredart icons in the OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |vfaafia29@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #6 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115749&action=edit Bug 27522: Adding new itemtype info image to carredart Test Plan 1. Go to Administration>Item Types>Modify Item Type 2. Under carredart you should see an info item type Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115707|0 |1 is obsolete| | --- Comment #7 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115750&action=edit Bug 27522: (follow-up) Add copy of image to carredart icons in the OPAC Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off --- Comment #8 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works as described. Test Plan 1. Go to Administration>item types>modify item type 2. There should be an info item type under the carredart 3. Modify the item type so one of the new icons is used 4. Search for an item using the above item type 5. Check that the icon displays properly in both the staff client and OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115749|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115843&action=edit Bug 27522: Adding new itemtype info image to carredart Test Plan 1. Go to Administration>Item Types>Modify Item Type 2. Under carredart you should see an info item type Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115750|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115844&action=edit Bug 27522: (follow-up) Add copy of image to carredart icons in the OPAC Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Victoria, Aleisha or someone else - as these don't appear to belong to the original carredart item set (I believe this came from a library in Nimes - bug 5640)- where were these new icons taken from? Do we need to add any license information? I think it would be good to document the source here or in the commit message. As they don't perfectly fit the style, maybe we should put them on a separate tab? Sorry if I missed something! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 122933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122933&action=edit Bug 27522: (follow-up) Adding new itemtype info image to carredart This patch adds a new version of the info icon which was created from scratch based on the previous version's design. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115642|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115843|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 123164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123164&action=edit Bug 27522: Adding new itemtype info image to carredart Test Plan 1. Go to Administration>Item Types>Modify Item Type 2. Under carredart you should see an info item type Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115844|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 123165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123165&action=edit Bug 27522: (follow-up) Add copy of image to carredart icons in the OPAC Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 123166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123166&action=edit Bug 27522: (follow-up) Adding new itemtype info image to carredart This patch adds a new version of the info icon which was created from scratch based on the previous version's design. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Adding new itemtype info |Add a new itemtype info |image to carredart |image to carredart -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122933|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |jonathan.druart+koha@gmail. | |com --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #11)
Victoria, Aleisha or someone else - as these don't appear to belong to the original carredart item set (I believe this came from a library in Nimes - bug 5640)- where were these new icons taken from? Do we need to add any license information? I think it would be good to document the source here or in the commit message. As they don't perfectly fit the style, maybe we should put them on a separate tab?
Sorry if I missed something!
Has this been answered? It's not clear to me from where are these icons coming and what is the license. Please clarify. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I understood it that Owen did a new version of the image from scratch in his 3rd patch, but didn't want the work before to be lost. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- They are binary files, and if we don't know their origin I don't see how it could be useful to keep them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- It was not my intention that both versions of the image be kept in the git history. I should have obsoleted the older patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|Passed QA |In Discussion --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Can we squash and clarify in the commit message what's happening here? It seems that the icons were part of Koha (bug 5640) but have been removed (inadvertently) and so we are adding them back? But with a modified version because we didn't know what was the license? Aleisha, do you remember the origin of this bug report? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123164|0 |1 is obsolete| | Attachment #123165|0 |1 is obsolete| | Attachment #123166|0 |1 is obsolete| | --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 123457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123457&action=edit Bug 27522: Adding new itemtype info image to carredart This patch adds an "info" icon to the carredart icon set. It was created from scratch for Koha based on an earlier patch by Victoria Faafia. Test Plan: 1. Go to Administration > Item Types > Modify Item Type 2. Under carredart you should see an "info" item type icon. Assign it to an item type. 3. Go to Administration -> System preferences and make sure that OpacAdvSearchOptions and AdvancedSearchTypes have item type searches enabled. 4. In the OPAC and staff interface, view the advanced search page and confirm that the new icon appears. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #22 from Aleisha Amohia <aleisha@catalyst.net.nz> --- These icons were designed by a Catalyst Academy student (Victoria, who opened the bug report), and she designed them as part of her contribution to the Academy. They are free to use for Koha's image sets. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- So now we have 2 versions, the one from Victoria and the one from Owen. Do we need both? Why is it named "carredart"? Initially it's coming from bug 5640 for "Carré d'Art" (museum) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123457|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123165|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123164|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- I've removed my patch and returned the old ones. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #23)
Why is it named "carredart"? Initially it's coming from bug 5640 for "Carré d'Art" (museum)
This is waiting for an answer. Aleisha, maybe? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #26 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Jonathan Druart from comment #25)
(In reply to Jonathan Druart from comment #23)
Why is it named "carredart"? Initially it's coming from bug 5640 for "Carré d'Art" (museum)
This is waiting for an answer. Aleisha, maybe?
That's the name on the item types icon tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA Keywords|release-notes-needed | --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I am really sorry, I got confused and was confusing! I thought we were adding a new set of icons. I have no idea how I understood that, everything is clear when reading the commit message and bug title: we are only adding a new 'info' icon to the existing "carredart" set. Sorry everybody! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27505 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Text to go in the| |This enhancement adds a release notes| |info image to the carredart | |icon set for item types. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org