[Bug 24546] New: Club/Hold.t has a wrong call to build_sample_item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546 Bug ID: 24546 Summary: Club/Hold.t has a wrong call to build_sample_item Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org In t/db_dependent/Koha/Club/Hold.t: my $item1 = $builder->build_sample_item({ branchcode => $library->branchcode }); my $item2 = $builder->build_sample_item({ branchcode => $library->branchcode }); build_sample_item takes either "library" or the item's attributes. branchcode is not part of the item's table, so what those 2 lines are trying to acchieve is wrong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19618 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Coming from commit 474eca3dbcabe40eead066c3221d4984b0b890b4 Bug 19618: Add tests Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 [Bug 19618] Add 'Club Holds' feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98160&action=edit Bug 24546: Fix intentions of build_sample_item in Club/Hold.t In t/db_dependent/Koha/Club/Hold.t: my $item1 = $builder->build_sample_item({ branchcode => $library->branchcode }); my $item2 = $builder->build_sample_item({ branchcode => $library->branchcode }); build_sample_item takes either "library" or the item's attributes. branchcode is not part of the item's table, so what those 2 lines are trying to acchieve is wrong. Test plan: % prove t/db_dependent/Koha/Club/Hold.t must return green before and after this patch Note that this patch also remove an uneeded debugging statement. This has been caught by bug 24363. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |jonathan.druart@bugs.koha-c | |ommunity.org Blocks| |24363 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 [Bug 24363] Datepicker calendar is not always sexy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98160|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 98216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98216&action=edit Bug 24546: Fix intentions of build_sample_item in Club/Hold.t In t/db_dependent/Koha/Club/Hold.t: my $item1 = $builder->build_sample_item({ branchcode => $library->branchcode }); my $item2 = $builder->build_sample_item({ branchcode => $library->branchcode }); build_sample_item takes either "library" or the item's attributes. branchcode is not part of the item's table, so what those 2 lines are trying to acchieve is wrong. Test plan: % prove t/db_dependent/Koha/Club/Hold.t must return green before and after this patch Note that this patch also remove an uneeded debugging statement. This has been caught by bug 24363. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98216|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 98227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98227&action=edit Bug 24546: Fix intentions of build_sample_item in Club/Hold.t In t/db_dependent/Koha/Club/Hold.t: my $item1 = $builder->build_sample_item({ branchcode => $library->branchcode }); my $item2 = $builder->build_sample_item({ branchcode => $library->branchcode }); build_sample_item takes either "library" or the item's attributes. branchcode is not part of the item's table, so what those 2 lines are trying to acchieve is wrong. Test plan: % prove t/db_dependent/Koha/Club/Hold.t must return green before and after this patch Note that this patch also remove an uneeded debugging statement. This has been caught by bug 24363. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #6 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies for 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org