https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98160|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 98216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98216&action=edit Bug 24546: Fix intentions of build_sample_item in Club/Hold.t In t/db_dependent/Koha/Club/Hold.t: my $item1 = $builder->build_sample_item({ branchcode => $library->branchcode }); my $item2 = $builder->build_sample_item({ branchcode => $library->branchcode }); build_sample_item takes either "library" or the item's attributes. branchcode is not part of the item's table, so what those 2 lines are trying to acchieve is wrong. Test plan: % prove t/db_dependent/Koha/Club/Hold.t must return green before and after this patch Note that this patch also remove an uneeded debugging statement. This has been caught by bug 24363. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.