[Bug 32771] New: Standardize structure around action fieldsets in serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 Bug ID: 32771 Summary: Standardize structure around action fieldsets in serials Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 32746 Blocks: 32744 As per Bug 32744: Fieldsets with the class "action" should be placed outside of the fieldset containing the main body of the form. This report covers templates in serials. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32744 [Bug 32744] [OMNIBUS] Standardize structure around action fieldsets https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 [Bug 32746] Standardize structure around action fieldsets in acquisitions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 145930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145930&action=edit Bug 32771: Standardize structure around action fieldsets in serials This patch updates serials templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and rebuild the staff interface CSS. Go to serials and check the following pages to confirm that changes to form structure look correct: - Navigate directly to /cgi-bin/koha/serials/serials-search.pl - Check the form on this page. - Perform a subscription search. On the search results page, check the sidebar form. - Click "Manage numbering patterns" in the left-hand sidebar menu. - Click "New numbering pattern" and check the forms on that page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- I think there is another fieldset that has been missed as the sidebar on serials-search is still inside the main form fieldset - see lines 434-440 in serials-search.tt Does this need amending as well or is this not subject to the same standardized structure? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145930|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 146038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146038&action=edit Bug 32771: Standardize structure around action fieldsets in serials This patch updates serials templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and rebuild the staff interface CSS. Go to serials and check the following pages to confirm that changes to form structure look correct: - Navigate directly to /cgi-bin/koha/serials/serials-search.pl - Check the form on this page. - Perform a subscription search. On the search results page, check the sidebar form. - Click "Manage numbering patterns" in the left-hand sidebar menu. - Click "New numbering pattern" and check the forms on that page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146038|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 146449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146449&action=edit Bug 32771: Standardize structure around action fieldsets in serials This patch updates serials templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and rebuild the staff interface CSS. Go to serials and check the following pages to confirm that changes to form structure look correct: - Navigate directly to /cgi-bin/koha/serials/serials-search.pl - Check the form on this page. - Perform a subscription search. On the search results page, check the sidebar form. - Click "Manage numbering patterns" in the left-hand sidebar menu. - Click "New numbering pattern" and check the forms on that page. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146449|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 147362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147362&action=edit Bug 32771: Standardize structure around action fieldsets in serials This patch updates serials templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and rebuild the staff interface CSS. Go to serials and check the following pages to confirm that changes to form structure look correct: - Navigate directly to /cgi-bin/koha/serials/serials-search.pl - Check the form on this page. - Perform a subscription search. On the search results page, check the sidebar form. - Click "Manage numbering patterns" in the left-hand sidebar menu. - Click "New numbering pattern" and check the forms on that page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147362|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 148514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148514&action=edit Bug 32771: Standardize structure around action fieldsets in serials This patch updates serials templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and rebuild the staff interface CSS. Go to serials and check the following pages to confirm that changes to form structure look correct: - Navigate directly to /cgi-bin/koha/serials/serials-search.pl - Check the form on this page. - Perform a subscription search. On the search results page, check the sidebar form. - Click "Manage numbering patterns" in the left-hand sidebar menu. - Click "New numbering pattern" and check the forms on that page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 Bug 32771 depends on bug 32746, which changed state. Bug 32746 Summary: Standardize structure around action fieldsets in acquisitions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org