[Bug 15432] New: t/db_dependent/Letters.t depends on external data/configuration
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15432 Bug ID: 15432 Summary: t/db_dependent/Letters.t depends on external data/configuration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org To reproduce: - Set system preference LetterLog to 'Don't log' - prove t/db_dependent/Letters.t - Result: Fails on test 62 - Successfully sent claim - Set system preference LetterLog to 'Log - Test again - Result: Pass OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15432 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |veron@veron.ch |y.org | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15432 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 46006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46006&action=edit Bug 15432: t/db_dependent/Letters.t depends on external data/configuration To test: - Set system preference LetterLog to 'Don't log' - prove t/db_dependent/Letters.t - Result: Fails on test 62 - Successfully sent claim - Apply patch - Test again - Result: Pass OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15432 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Blocks| |15429 Status|NEW |Needs Signoff Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15429 [Bug 15429] sub _parseletter should not change referenced values -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15432 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15432 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46006|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46070&action=edit Bug 15432: t/db_dependent/Letters.t depends on external data/configuration To test: - Set system preference LetterLog to 'Don't log' - prove t/db_dependent/Letters.t - Result: Fails on test 62 - Successfully sent claim - Apply patch - Test again - Result: Pass OK Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: removed the bug reference, not needed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15432 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |veron@veron.ch Status|Signed Off |Passed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Trivial, skipping QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15432 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46070|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46071&action=edit Bug 15432: t/db_dependent/Letters.t depends on external data/configuration To test: - Set system preference LetterLog to 'Don't log' - prove t/db_dependent/Letters.t - Result: Fails on test 62 - Successfully sent claim - Apply patch - Test again - Result: Pass OK Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: removed the bug reference, not needed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15432 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15429 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15429 [Bug 15429] sub _parseletter should not change referenced values -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15432 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master, thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15432 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15432 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org