[Bug 15373] New: Zip should be ZIP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373 Bug ID: 15373 Summary: Zip should be ZIP Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org ZIP is an acronym (Zone Improvement Plan) so Zip should be replaced to ZIP in OPAC and Staff Interface -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 45679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45679&action=edit Bug 15373: Changing Zip to ZIP on OPAC and Intranet To test: 1) Login to OPAC --> You personal details. 2) Ensure it says 'ZIP/Postal Code' under Main Address, Alternate Address and Alternate Contact 3) Login to Staff interface --> Go to a member's page (ie koha/members/memberentry.pl) --> Details. 4) Ensure it says 'ZIP/Postal Code' under Alternate address and Alternative contact 5) Click Edit 6) Ensure it says 'ZIP/Postal Code' under Main Address, Alternate Address and Alternate Contact -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373 Barry Cannon <bc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |bc@interleaf.ie --- Comment #2 from Barry Cannon <bc@interleaf.ie> --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373 Barry Cannon <bc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45679|0 |1 is obsolete| | --- Comment #3 from Barry Cannon <bc@interleaf.ie> --- Created attachment 45727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45727&action=edit Signed-off patch for 15373 Error with the previous comment, there is no conflict. Patch appears to apply and work as described. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373 Barry Cannon <bc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think small mistake here - switching to Signed off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have found more occurrences in the following files: koha-tmpl/intranet-tmpl/prog/en/columns.def koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt reports/borrowers_stats.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373 --- Comment #6 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 45872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45872&action=edit Bug 15373: More changes of Zip to ZIP on intranet To test: - Log in to Staff Interface, go to Administration, Libraries and Groups (cgi-bin/koha/admin/branches.pl). Click 'New library' and confirm that it says 'ZIP/Postal Code:' in the form. - Go back to Administration, Cities and towns (cgi-bin/koha/admin/cities.pl). Confirm it says 'ZIP/Postal code' in table heading. Click 'New city' and confirm it says 'ZIP/Postal code:' in form - Go back to Administration, Global system preferences, I18L/L10N (cgi-bin/koha/admin/preferences.pl?tab=i18n_l10n). Under AddressFormat, confirm all available options say '[ZIP/Postal Code]' - Go to Reports, Patrons (cgi-bin/koha/reports/borrowers_stats.pl). Confirm it says 'ZIP/Postal code' under Title - Go to Tools, Batch patron modification (cgi-bin/koha/tools/modborrowers.pl), enter any card number and click 'Continue'. Confirm it says 'ZIP/Postal code' in the table of patron details, and in the form to edit -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|oleonard@myacpl.org |aleishaamohia@hotmail.com CC| |mtompset@hotmail.com Patch complexity|--- |String patch --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- This is not an enhancement. It is annoying that enhancement is the default, and we sometimes forget to check for it. This is a string correction. Simple enough to check. I have confirmed that all instances seem to be dealt with. Now to follow test plan. Aleisha, if you are submitting the patch, please remember to take the bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45727|0 |1 is obsolete| | --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 46045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46045&action=edit Bug 15373: Changing Zip to ZIP on OPAC and Intranet To test: 1) Login to OPAC --> You personal details. 2) Ensure it says 'ZIP/Postal Code' under Main Address, Alternate Address and Alternate Contact 3) Login to Staff interface --> Go to a member's page (ie koha/members/memberentry.pl) --> Details. 4) Ensure it says 'ZIP/Postal Code' under Alternate address and Alternative contact 5) Click Edit 6) Ensure it says 'ZIP/Postal Code' under Main Address, Alternate Address and Alternate Contact Signed-off-by: Barry Cannon <bc@interleaf.ie> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Tested together with second patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45872|0 |1 is obsolete| | --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 46046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46046&action=edit Bug 15373: More changes of Zip to ZIP on intranet To test: - Log in to Staff Interface, go to Administration, Libraries and Groups (cgi-bin/koha/admin/branches.pl). Click 'New library' and confirm that it says 'ZIP/Postal Code:' in the form. - Go back to Administration, Cities and towns (cgi-bin/koha/admin/cities.pl). Confirm it says 'ZIP/Postal code' in table heading. Click 'New city' and confirm it says 'ZIP/Postal code:' in form - Go back to Administration, Global system preferences, I18L/L10N (cgi-bin/koha/admin/preferences.pl?tab=i18n_l10n). Under AddressFormat, confirm all available options say '[ZIP/Postal Code]' - Go to Reports, Patrons (cgi-bin/koha/reports/borrowers_stats.pl). Confirm it says 'ZIP/Postal code' under Title - Go to Tools, Batch patron modification (cgi-bin/koha/tools/modborrowers.pl), enter any card number and click 'Continue'. Confirm it says 'ZIP/Postal code' in the table of patron details, and in the form to edit Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Tested together with first patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46045|0 |1 is obsolete| | Attachment #46046|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46068&action=edit Bug 15373: Changing Zip to ZIP on OPAC and Intranet To test: 1) Login to OPAC --> You personal details. 2) Ensure it says 'ZIP/Postal Code' under Main Address, Alternate Address and Alternate Contact 3) Login to Staff interface --> Go to a member's page (ie koha/members/memberentry.pl) --> Details. 4) Ensure it says 'ZIP/Postal Code' under Alternate address and Alternative contact 5) Click Edit 6) Ensure it says 'ZIP/Postal Code' under Main Address, Alternate Address and Alternate Contact Signed-off-by: Barry Cannon <bc@interleaf.ie> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Tested together with second patch. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46069&action=edit Bug 15373: More changes of Zip to ZIP on intranet To test: - Log in to Staff Interface, go to Administration, Libraries and Groups (cgi-bin/koha/admin/branches.pl). Click 'New library' and confirm that it says 'ZIP/Postal Code:' in the form. - Go back to Administration, Cities and towns (cgi-bin/koha/admin/cities.pl). Confirm it says 'ZIP/Postal code' in table heading. Click 'New city' and confirm it says 'ZIP/Postal code:' in form - Go back to Administration, Global system preferences, I18L/L10N (cgi-bin/koha/admin/preferences.pl?tab=i18n_l10n). Under AddressFormat, confirm all available options say '[ZIP/Postal Code]' - Go to Reports, Patrons (cgi-bin/koha/reports/borrowers_stats.pl). Confirm it says 'ZIP/Postal code' under Title - Go to Tools, Batch patron modification (cgi-bin/koha/tools/modborrowers.pl), enter any card number and click 'Continue'. Confirm it says 'ZIP/Postal code' in the table of patron details, and in the form to edit Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Tested together with first patch. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master, thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15373 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #14 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org