https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|Reverse payment permission |Permission for voiding | |payments --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- With bug 20629 the option to reverse payments will be gone. I am changing this to be a permission for the replacement: voiding payments. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24849 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24849 [Bug 24849] Permissions checks are missing in borracount controller -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |cubingguy714@gmail.com |ity.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 --- Comment #2 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 169109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169109&action=edit Bug 17473: Add void payment permission To test: 1. Apply patch, updatedatabase, restart_all 2. Search for staff patron 3. More -> Set permissions 4. Check - Staff access, allows viewing of catalogue in staff interface - Add, modify and view patron information - Manage patrons fines and fee 5. Notice under Manage patrons fines and fee there is a new permission "Voiding Payments" 6. Sign into staff interface as your selected staff patron 7. Search for a non-staff patron -> Accounting 8. Click 'Create manual invoice', add an amount and click 'Save and pay' -> 'Confirm' 9. Go to transactions and notice the option to Void payment appears 10. Go back to your staff patron's permission and unselect 'Voiding Payments' 11. Go to your non-staff patron and notice the option to void payments is gone -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169109|0 |1 is obsolete| | --- Comment #3 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 169310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169310&action=edit Bug 17473: Add void payment permission To test: 1. Apply patch, updatedatabase, restart_all 2. Search for staff patron 3. More -> Set permissions 4. Check - Staff access, allows viewing of catalogue in staff interface - Add, modify and view patron information - Manage patrons fines and fee 5. Notice under Manage patrons fines and fee there is a new permission "Voiding Payments" 6. Sign into staff interface as your selected staff patron 7. Search for a non-staff patron -> Accounting 8. Click 'Create manual invoice', add an amount and click 'Save and pay' -> 'Confirm' 9. Go to transactions and notice the option to Void payment appears 10. Go back to your staff patron's permission and unselect 'Voiding Payments' 11. Go to your non-staff patron and notice the option to void payments is gone -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 169384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169384&action=edit Bug 17473: (follow-up) add semicolon after use Modern::Perl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 --- Comment #7 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 169387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169387&action=edit Bug 17473: (follow-up) add semicolon after use Modern::Perl Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169386|0 |1 is obsolete| | --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174943&action=edit Bug 17473: Add void payment permission To test: 1. Apply patch, updatedatabase, restart_all 2. Search for staff patron 3. More -> Set permissions 4. Check - Staff access, allows viewing of catalogue in staff interface - Add, modify and view patron information - Manage patrons fines and fee 5. Notice under Manage patrons fines and fee there is a new permission "Voiding Payments" 6. Sign into staff interface as your selected staff patron 7. Search for a non-staff patron -> Accounting 8. Click 'Create manual invoice', add an amount and click 'Save and pay' -> 'Confirm' 9. Go to transactions and notice the option to Void payment appears 10. Go back to your staff patron's permission and unselect 'Voiding Payments' 11. Go to your non-staff patron and notice the option to void payments is gone Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Capitalization + (10, 'void_payment', 'Voiding Payments'), + $dbh->do(q{ + INSERT IGNORE permissions (module_bit, code, description) VALUES + (10, 'void_payment', 'Voiding Payments') Etc. For Koha we have decided to only upper-case names and the first word. Please check coding guidelines for more information. 2) This is missing a server side check. I believe we also need to check for this permission server side and maybe in the API. I would be OK to handle the API on a separate bug if there is no veto, but would like to see a re-worked patch with fixed capitalization and the server side check looked into. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 3) Database update Oh! While you are on it, please update the atomicupate to use the recent template. The success message should be after both SQL statements or they each should have one. They should use say_success. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174943|0 |1 is obsolete| | --- Comment #14 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 182922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182922&action=edit Bug 17473: Add void payment permission -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 --- Comment #15 from Eric Garcia <cubingguy714@gmail.com> --- (In reply to Katrin Fischer from comment #11)

1) Capitalization

+ (10, 'void_payment', 'Voiding Payments'),

+ $dbh->do(q{ + INSERT IGNORE permissions (module_bit, code, description) VALUES + (10, 'void_payment', 'Voiding Payments')

Etc.

Fixed.

For Koha we have decided to only upper-case names and the first word. Please check coding guidelines for more information.

2) This is missing a server side check.

I believe this should be done in a separate bug because we do not have check for payout, refund, discount, etc. in boraccount.pl. Thoughts?

I believe we also need to check for this permission server side and maybe in the API.

I would be OK to handle the API on a separate bug if there is no veto, but would like to see a re-worked patch with fixed capitalization and the server side check looked into.

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- This has been sitting for almost a yea, resetting to 'Needs Sign off' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 David Flater <flaterdavid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |flaterdavid@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.