https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 --- Comment #15 from Eric Garcia <cubingguy714@gmail.com> --- (In reply to Katrin Fischer from comment #11)
1) Capitalization
+ (10, 'void_payment', 'Voiding Payments'),
+ $dbh->do(q{ + INSERT IGNORE permissions (module_bit, code, description) VALUES + (10, 'void_payment', 'Voiding Payments')
Etc.
Fixed.
For Koha we have decided to only upper-case names and the first word. Please check coding guidelines for more information.
2) This is missing a server side check.
I believe this should be done in a separate bug because we do not have check for payout, refund, discount, etc. in boraccount.pl. Thoughts?
I believe we also need to check for this permission server side and maybe in the API.
I would be OK to handle the API on a separate bug if there is no veto, but would like to see a re-worked patch with fixed capitalization and the server side check looked into.
-- You are receiving this mail because: You are watching all bug changes.