[Bug 40379] New: t/db_dependent/www tests generate warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40379 Bug ID: 40379 Summary: t/db_dependent/www tests generate warnings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Blocks: 25515 03:17:21 koha_1 | Warning: <retrieval> element has non-unique value in 'name' key attribute: F at t/db_dependent/www/auth_values_input_www.t line 36. 03:17:21 koha_1 | Warning: <retrieval> element has non-unique value in 'name' key attribute: B at t/db_dependent/www/auth_values_input_www.t line 36. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 [Bug 25515] [OMNIBUS] Remove warnings and errors from tests output -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40379 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184081&action=edit Bug 40379: Remove warnings from t/db_dependent/www XMLin complains because there are several nodes with the same name attribute. Not sure what is correct or not, but we actually cannot use the admin/DBMS user to login to the Koha interface. We use KOHA_USER env var or default to 'koha'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40379 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|chris@bigballofwax.co.nz |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40379 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40379 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184081|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 184282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184282&action=edit Bug 40379: Remove warnings from t/db_dependent/www XMLin complains because there are several nodes with the same name attribute. Not sure what is correct or not, but we actually cannot use the admin/DBMS user to login to the Koha interface. We use KOHA_USER env var or default to 'koha'. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40379 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- t/db_dependent/www/batch.t 1..25 ok 1 - connect to intranet ok 2 - login to staff interface ok 3 - load main page Link not found at /usr/share/koha/t/lib/Mocks/Zebra.pm line 171. ok 4 - no warnings # Looks like your test exited with 255 just after 4. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40379 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- $agent->follow_link_ok( { url_regex => qr/cataloging-home/i }, 'open caaloging module' ); Whats happening here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40379 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40379 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Marcel de Rooy from comment #3)
t/db_dependent/www/batch.t 1..25 ok 1 - connect to intranet ok 2 - login to staff interface ok 3 - load main page Link not found at /usr/share/koha/t/lib/Mocks/Zebra.pm line 171. ok 4 - no warnings # Looks like your test exited with 255 just after 4.
It's passing for me. (In reply to Marcel de Rooy from comment #4)
$agent->follow_link_ok( { url_regex => qr/cataloging-home/i }, 'open caaloging module' );
Whats happening here?
The test is hitting the mainpage then search for the "Cataloging" link (you should see /cgi-bin/koha/cataloguing/cataloging-home.pl) What about the other tests? Maybe it's a problem with the changes made here, and the credentials used by the tests to connect to the interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40379 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #5)
(In reply to Marcel de Rooy from comment #3)
t/db_dependent/www/batch.t 1..25 ok 1 - connect to intranet ok 2 - login to staff interface ok 3 - load main page Link not found at /usr/share/koha/t/lib/Mocks/Zebra.pm line 171. ok 4 - no warnings # Looks like your test exited with 255 just after 4.
It's passing for me.
(In reply to Marcel de Rooy from comment #4)
$agent->follow_link_ok( { url_regex => qr/cataloging-home/i }, 'open caaloging module' );
Whats happening here?
The test is hitting the mainpage then search for the "Cataloging" link (you should see /cgi-bin/koha/cataloguing/cataloging-home.pl)
What about the other tests? Maybe it's a problem with the changes made here, and the credentials used by the tests to connect to the interface.
I am having issues with batch.t and search_utf8.t. The other ones are fine. Still looking.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40379 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40379 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184282|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 184423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184423&action=edit Bug 40379: Remove warnings from t/db_dependent/www XMLin complains because there are several nodes with the same name attribute. Not sure what is correct or not, but we actually cannot use the admin/DBMS user to login to the Koha interface. We use KOHA_USER env var or default to 'koha'. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40379 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #6)
I am having issues with batch.t and search_utf8.t. The other ones are fine. Still looking..
Passing QA. My issues are related to my setup and security. Code looks fine to me, the other ones pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40379 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40379 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40379 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40379 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25515 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 [Bug 25515] [OMNIBUS] Remove warnings and errors from tests output -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40379 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40444 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40444 [Bug 40444] Add a test to ensure all Perl test files use Test::NoWarnings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40379 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40379 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40379 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply easy on 24.11.x, lets not backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40379 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #12 from David Nind <david@davidnind.com> --- Test suite, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org