[Bug 38503] New: Add a Cypress task to generate objects based on its swagger def spec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Bug ID: 38503 Summary: Add a Cypress task to generate objects based on its swagger def spec Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org We have TestBuilder for the Perl tests. However for the Cypress tests we have to: 1. either mock all the routes (which is painful and time-consuming), 2. or rely on the existing data in DB (which will produce failures if data has been inserted, and tests will have to cleanup before/after, which is painful, time-consuming and not robust) We should have a way to generate objects easily, in order to mock the response of a GET route easily. We can actually rely on the swagger spec files (the definition file) to generate random data and mock the response of routes. The first intended goal is to provide tests for the tables (bug 38461) and allow future enhancements in this area (see dependent bugs of bug 36640). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, | |matt.blenkinsop@ptfs-europe | |.com, | |paul.derscheid@lmscloud.de, | |pedro.amorim@ptfs-europe.co | |m, tomascohen@gmail.com Blocks| |38461 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 [Bug 38461] Table features needs to be covered by e2e tests - Cypress -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174872&action=edit Bug 38503: Read patron swagger spec file and implement buildSamplePatron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174873&action=edit Bug 38503: Implement a plural form - buildSamplePatrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174874&action=edit Bug 38503: Same for libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174875&action=edit Bug 38503: Have a generic buildSampleObject[s] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174876&action=edit Bug 38503: Allow to pass values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174884&action=edit Bug 38503: Deal with types that can be "null" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174885&action=edit Bug 38503: Generate correct values for date and date-time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174921&action=edit Bug 38503: [DO NOT PUSH] (follow-up) Generate correct values for date and date-time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174921|0 |1 is obsolete| | --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174922&action=edit Bug 38503: [DO NOT PUSH] (follow-up) Upgrade @vue/cli-service for compat with node v22 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Sorry, forgot to edit the commit message the first time. So for compatibility with node v22, I just upgraded @vue/cli-service to its latest version. To reproduce: 1) Make sure you are on node v22 2) Apply the patch interactively without the updated lockfile 3) Run `yarn install` 4) Observe error: kohadev-koha@kohadevbox:koha(bug_38503)$ yarn install yarn install v1.22.22 [1/4] Resolving packages... [2/4] Fetching packages... error @achrinza/node-ipc@9.2.5: The engine "node" is incompatible with this module. Expected version "8 || 9 || 10 || 11 || 12 || 13 || 14 || 15 || 16 || 17 || 18". Got "22.11.0" error Found incompatible module. info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command. 5) Apply the last patch as well 6) Observe success kohadev-koha@kohadevbox:koha(bug_38503)$ yarn install yarn install v1.22.22 [1/4] Resolving packages... [2/4] Fetching packages... [3/4] Linking dependencies... warning "@redocly/cli > redoc > @cfaester/enzyme-adapter-react-18@0.8.0" has unmet peer dependency "enzyme@^3.11.0". warning " > eslint-config-prettier@9.1.0" has unmet peer dependency "eslint@>=7.0.0". warning " > eslint-plugin-prettier@5.1.3" has unmet peer dependency "eslint@>=8.0.0". warning " > eslint-plugin-prettier@5.1.3" has unmet peer dependency "prettier@>=3.0.0". warning "swagger-cli > @apidevtools/swagger-cli > @apidevtools/swagger-parser@10.1.0" has unmet peer dependency "openapi-types@>=7". [4/4] Building fresh packages... Done in 303.71s. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Does this really depend on vue-cli? - I upgraded node to v22 - applied all patches - removed vue-cli and babel deps - sudo yarn install --modules-folder /kohadevbox/node_modules and t/cypress/integration/t/mockData.ts ran after doing the same removals as: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174858&action=diff cypress output confirms it's using node 22 Is there anything else to test? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 175173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175173&action=edit Bug 38503: Do not list the objects No need to list all the objects, just retrieve the spec depending on the "object" var we pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175173|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 175175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175175&action=edit Bug 38503: Do not list the objects No need to list all the objects, just retrieve the spec depending on the "object" var we pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Ready to go as a first step. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29285 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174872|0 |1 is obsolete| | --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175212&action=edit Bug 38503: Read patron swagger spec file and implement buildSamplePatron Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174873|0 |1 is obsolete| | --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175213&action=edit Bug 38503: Implement a plural form - buildSamplePatrons Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174874|0 |1 is obsolete| | --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175214&action=edit Bug 38503: Same for libraries Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174875|0 |1 is obsolete| | --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175215&action=edit Bug 38503: Have a generic buildSampleObject[s] Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174876|0 |1 is obsolete| | --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175216&action=edit Bug 38503: Allow to pass values Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174884|0 |1 is obsolete| | --- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175217&action=edit Bug 38503: Deal with types that can be "null" Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174885|0 |1 is obsolete| | --- Comment #21 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175218&action=edit Bug 38503: Generate correct values for date and date-time Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174922|0 |1 is obsolete| | --- Comment #22 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175219&action=edit Bug 38503: [DO NOT PUSH] (follow-up) Upgrade @vue/cli-service for compat with node v22 Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175175|0 |1 is obsolete| | --- Comment #23 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175220&action=edit Bug 38503: Do not list the objects No need to list all the objects, just retrieve the spec depending on the "object" var we pass. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 --- Comment #24 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175221&action=edit Bug 38503: [PROPOSAL] deps: remove @vue/cli-service & babel They really don't seem needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 --- Comment #25 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175222&action=edit Bug 38503: [DO NOT PUSH] Update yarn.lock for the previous [PROPOSAL] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #26 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It works! :) 150 runs done. Without @vue/cli-service and babel. I'm also hammering bug 38461 tests. So it really really looks like cli-service isn't a dependency. Hence the two last commits added to remove them. It also works with @vue/cli-service and babel not removed. -----
Bug 38503: [DO NOT PUSH] (follow-up) Upgrade @vue/cli-service for compat with node v22
Assuming it's confirmed we don't need vue/cli-service & babel: The commit above would not be needed. But it worth mentioning that it had an issue for future node package stuff: It's a [DO NOT PUSH] commit that had the task of updating deps. So that update will be lost. We can't have anything meaningful in yarn.lock with the current workflow. (which seems to be good btw) If only an RM/RMaint touches yark.lock then dependency updates need to be done in package.json. Not only to work in our workflow but also to document accurately that we need more recent deps. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 --- Comment #27 from Victor Grousset/tuxayo <victor@tuxayo.net> --- additional info: still works if forgetting to upgrade node from 18 to 22. That's still a good opportunity to upgrade though. (to test, edit version in /etc/apt/sources.list.d/nodesource.list and then `sudo apt update;sudo install nodejs`) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- This patch should be moved to its own bug report. "Bug 38503: [PROPOSAL] deps: remove @vue/cli-service & babel" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175219|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175221|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175222|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175212|0 |1 is obsolete| | --- Comment #29 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175888&action=edit Bug 38503: Read patron swagger spec file and implement buildSamplePatron Test plan: 1. Install deps sudo yarn install --modules-folder /kohadevbox/node_modules 2. Run tests cypress run --config video=false --spec t/cypress/integration/t/mockData.ts Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175213|0 |1 is obsolete| | --- Comment #30 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175889&action=edit Bug 38503: Implement a plural form - buildSamplePatrons Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175214|0 |1 is obsolete| | --- Comment #31 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175890&action=edit Bug 38503: Same for libraries Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175215|0 |1 is obsolete| | --- Comment #32 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175891&action=edit Bug 38503: Have a generic buildSampleObject[s] Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175216|0 |1 is obsolete| | --- Comment #33 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175892&action=edit Bug 38503: Allow to pass values Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175217|0 |1 is obsolete| | --- Comment #34 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175893&action=edit Bug 38503: Deal with types that can be "null" Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175218|0 |1 is obsolete| | --- Comment #35 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175894&action=edit Bug 38503: Generate correct values for date and date-time Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175220|0 |1 is obsolete| | --- Comment #36 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175895&action=edit Bug 38503: Do not list the objects No need to list all the objects, just retrieve the spec depending on the "object" var we pass. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 --- Comment #37 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175896&action=edit Bug 38503: [DO NOT PUSH] yarn.lock changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 --- Comment #38 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Jonathan Druart from comment #28)
This patch should be moved to its own bug report. "Bug 38503: [PROPOSAL] deps: remove @vue/cli-service & babel"
Moved to Bug 38770. And not added as a dependency because there is no sign it's needed for the test plan to work (unless steps were missing?) ---- test plan added in 1st commit ---- yarn.lock changes commit added -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175888|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176073&action=edit Bug 38503: Read patron swagger spec file and implement buildSamplePatron Test plan: 1. Install deps sudo yarn install --modules-folder /kohadevbox/node_modules 2. Run tests cypress run --config video=false --spec t/cypress/integration/t/mockData.ts Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175889|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176074&action=edit Bug 38503: Implement a plural form - buildSamplePatrons Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175890|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176075&action=edit Bug 38503: Same for libraries Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175891|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176076&action=edit Bug 38503: Have a generic buildSampleObject[s] Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175892|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176077&action=edit Bug 38503: Allow to pass values Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175893|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176078&action=edit Bug 38503: Deal with types that can be "null" Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175894|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176079&action=edit Bug 38503: Generate correct values for date and date-time Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175895|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176080&action=edit Bug 38503: Do not list the objects No need to list all the objects, just retrieve the spec depending on the "object" var we pass. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175896|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176081&action=edit Bug 38503: [DO NOT PUSH] yarn.lock changes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #48 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- This is a great step forward, nice approach. All works as expected, mocking endpoints is easy now :) Passing QA Minor niggle.. we need some good release notes for this one and good developer documentation somewhere to encourage it's adoption. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This provides utilities for release notes| |Cypress tests to generate | |JavaScript objects directly | |from the API definitions. | |They contain example data | |and can then be using to | |easily mock API responses | |in tests. --- Comment #49 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
Minor niggle.. we need some good release notes for this one
Here is a first try.
and good developer documentation somewhere to encourage it's adoption.
There doesn't seem to be documentation for Cypress tests for now ^^" . Much less for mocking API responses where this would fit well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 --- Comment #50 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Thanks :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 --- Comment #51 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- *** Bug 36607 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 --- Comment #53 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176775&action=edit Bug 38503: Merge the module.exports We redefine it and so the query/mysql plugin is not available It fixes csrf.ts 14:36:17 koha_1 | The task 'query' was not handled in the setupNodeEvents method. The following tasks are registered: buildSampleObject, buildSampleObjects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176775|0 |1 is obsolete| | --- Comment #54 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176776&action=edit Bug 38503: Merge the module.exports We redefine it and so the query/mysql plugin is not available It fixes csrf.ts 14:36:17 koha_1 | The task 'query' was not handled in the setupNodeEvents method. The following tasks are registered: buildSampleObject, buildSampleObjects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 --- Comment #55 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176792&action=edit Bug 38503: Do not generate too long strings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please set status to PQA when you attach follow-ups for me to push. Helps me keep on top of things. Last 2 patches picked for main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 --- Comment #57 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40169 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40169 [Bug 40169] Cypress tests - mockData should not replace "_id" fields if passed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |david@davidnind.com Status|Needs documenting |RESOLVED --- Comment #58 from David Nind <david@davidnind.com> --- Test suite changes, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org