[Bug 10233] New: Toolbar background missing from staff client catalogue page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10233 Bug ID: 10233 Summary: Toolbar background missing from staff client catalogue page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au Currently, the toolbar containing the buttons "New Record" and "Z39.50 search" is missing a background. Before we moved from YUI to Bootstrap, there was an extra div#toolbar wrapping the button group, but that appears to have vanished (and with it the background). We might be able to just change the current id from "newmenuc" to "toolbar", since the javascript that touched "newmenuc" seems to have been removed from the page as well (since it cleared the newmenuc div so that the plain html could be replaced with yui buttons). However, I'm loathe to do that without making sure that no existing functionality would break from doing that. It might be an idea to just wrap that div with a div#toolbar again to get that background back. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10233 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10233 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18115&action=edit Bug 10233 - Toolbar background missing from staff client catalogue page The toolbar on the cataloging home page lacks the standard toolbar id, resulting in an inconsistent appearance. This patch adds the correct id. To test, apply the patch, clear your browser cache, and view the cataloging home page (cataloguing/addbooks.pl). The toolbar should look like other toolbars in Koha (for instance, members/members-home.pl). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10233 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18115|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 18122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18122&action=edit [SIGNED-OFF] Bug 10233 - Toolbar background missing from staff client catalogue page The toolbar on the cataloging home page lacks the standard toolbar id, resulting in an inconsistent appearance. This patch adds the correct id. To test, apply the patch, clear your browser cache, and view the cataloging home page (cataloguing/addbooks.pl). The toolbar should look like other toolbars in Koha (for instance, members/members-home.pl). Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10233 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nengard@gmail.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10233 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10233 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18122|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 18128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18128&action=edit [PASSED QA] Bug 10233 - Toolbar background missing from staff client catalogue page The toolbar on the cataloging home page lacks the standard toolbar id, resulting in an inconsistent appearance. This patch adds the correct id. To test, apply the patch, clear your browser cache, and view the cataloging home page (cataloguing/addbooks.pl). The toolbar should look like other toolbars in Koha (for instance, members/members-home.pl). Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template change only, no string changed involved. Works as described. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10233 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org