[Bug 9923] New: correction of a bug due to bz 7129
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9923 Bug ID: 9923 Summary: correction of a bug due to bz 7129 Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: christophe.croullebois@biblibre.com Created attachment 16858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16858&action=edit proposed patch the patch 7129 introduces a bug if the unitprice is 0.0000. Instead of showing in this case the 'ecost' if there is not 'unitprice', it shows 0.00 and the 'Actual cost' must be manually entered. The line : if ( @$results[0]->{'unitprice'} == 0 ) { @$results[0]->{'unitprice'} = ''; was wrote in this perspective. But sprintf ( "%.2f", with '' or 0 or any string will return 0.00 and then, in the .tt 'unitprice' exists so we have the bad result. Jared Camins-Esakov : If this is fixing a bug caused by 7129 it should be moved to a new bug, which can be set straight to So I create this one and mark it as "Passed QA.". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9923 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9923 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9923 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9923 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7129 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9923 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9923 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Does not apply to 3.10.x or 3.8.x please resubmit if it is needed on those branches -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9923 --- Comment #3 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 18060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18060&action=edit [3.10.x] Bug 9923 - correction of a bug due to bz 7129 Patch rebased for 3.10.x. Also applies on 3.8.x. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9923 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Applied cleanly to 3.10.x will be in 3.10.6. Still conflicts for 3.8.x -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9923 --- Comment #5 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 18131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18131&action=edit patch rebased for 3.8.x Hi Chris, I have added a line in the comment. rebased for 3.8.x thx -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9923 --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.13 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org