[Bug 23674] New: Allowing editable notes when posting Payments/Writeoffs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Bug ID: 23674 Summary: Allowing editable notes when posting Payments/Writeoffs Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org It would be nice if a librarian forgot to add a note to a payment/write-off/manual invoice transaction, or if a note was added at time of transaction, that this note is editable. Currently, this is not something that can be edited, therefore, a librarian would have to remove the entire transaction to edit the note. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 22185 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|18.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Agreed. The Transactions table on boraccount.pl should allow one to add notes and/or edit existing notes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org --- Comment #3 from George Williams (NEKLS) <george@nekls.org> --- It's not a bad idea, but, as a system administrator for 51 libraries all using 1 shared Koha, I would want some control over who was able to edit notes. We use custom jQuery to add usernames and branchcodes to all notes so any staff member can easily look at an accountline and know who created it an where so that they don't have to run a report to see, for example, if someone at another library did a writeoff without permission from the library that owns that accountline. If anyone can edit any note, it makes it possible for someone to edit out the history of any undeserved writeoffs or credits they've created. I would want to be able to control who can edit the accountlines notes. A staff permission would be preferable, but a system preference would work too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|aleisha@catalyst.net.nz | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Azucena Aguayo <azucena.aguayo@uvu.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |azucena.aguayo@uvu.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allowing editable notes |Allowing editable notes on |when posting |all entries in patron |Payments/Writeoffs |Transactions table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Changed the bug title to reflect a broadened scope. Every accountlines entry has a notes field, so why not just put an Edit Note option on every line in the Transactions table. As George says, we'd want access to that button to be tied to a specific permission. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb@sekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31337 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24597 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Wally DesChamps <wdeschamps@prospertx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wdeschamps@prospertx.gov --- Comment #5 from Wally DesChamps <wdeschamps@prospertx.gov> --- Yes. Ability to add and edit notes is needed. Ability to extend "permissions" to that module for making/editing notes (and/or like in the Messages on patron's accounts where it gives the librarian, date, and time for the message when entered or edited) would be excellent, too [especially for the big wigs, like George ;-)] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 168035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168035&action=edit Bug 23674: Add ability to add a note to APPLY DISCOUNT To test: 1. APPLY PATCH and restart_all 2. Apply a manual invoice to a patron account. 3. Go to the patron record -> accounting -> transaction tab 4. Look for the 'Apply discount' button. 5. When the 'Apply discount' modal appears notcie the 'Note' field. 6. Add a note, make sure it gets applied to this accountline. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 168036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168036&action=edit Bug 23674: Add ability to add a note to pay individual fine from paycollect.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168036|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allowing editable notes on |Allowing notes on all |all entries in patron |entries in patron |Transactions table |Transactions table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Place where we need to have the ability to add a note: Pay individual Write-off individual Void Issue refund Issue payout Apply discount -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #9 from Sam Lau <samalau@gmail.com> --- Created attachment 168174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168174&action=edit Bug 23674: Add ability to add a note to pay individual and write-off individual To test: 1) Apply manual invoice to a patron account 2) Go to the patron record -> accounting -> transaction tab 3) Look for the "Pay" button under the actions column. Click this 4) Notice no place to enter note 5) Click the "Write off" button. Notice there is no place to enter note 6) Apply patch, restart_all 7) Notice that a "Note: " input appears in both the 'Pay' and 'Write off' tabs. 8) Write a not in the pay tab and confirm. Make sure this not shows up in the table. 9) Add another invoice and then test the note functionallity for the write-offs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #10 from Sam Lau <samalau@gmail.com> --- Created attachment 168177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168177&action=edit Bug 23674: Add ability to add a note to issue refund -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #11 from Sam Lau <samalau@gmail.com> --- Created attachment 168178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168178&action=edit Bug 23674: Add ability to add a note to issue payout To test: 1) Apply patch, restart_all 2) From patron accounting page -> Create manual credit. Put in some amount and press add credit. 3) Under the actions column, select 'Issue Payout' 4) You can now enter a note. Type something in and press confirm. 5) Ensure the note shows up in the note column. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #12 from Sam Lau <samalau@gmail.com> --- Created attachment 168180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168180&action=edit Bug 23674: Add ability to add note to void payment To test: 1) From patron accounting page -> Create manual credit. Put in some amount and press add credit. 2) Under the actions column, select "Void" 3) Notice no option for a note. Press cancel 4) Apply patch, restart_all 5) Press void again. This time, you should see a modal that gives you the option to type in a note. 6) Type something in and select submit. 7) Ensure the note shows up in the note column. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |samalau@gmail.com |ity.org | CC| |samalau@gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- *** Bug 24597 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37211 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 [Bug 37211] All notes in the patron Transactions table should be editable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168177|0 |1 is obsolete| | --- Comment #14 from Sam Lau <samalau@gmail.com> --- Created attachment 168213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168213&action=edit Bug 23674: Add ability to add a note to issue refund To test: 1) Apply patch, restart_all 2) From patron accounting page -> Create manual invoice. Enter some amount and select save and pay. Press confirm. 3) In the transactions tab, for the invoice you just created, under the actions column select issue refund. 4) This should open a modal with the ability to enter a note for the refund. Type in a note and confirm. 5) Ensure the note correctly shows in the table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 168329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168329&action=edit Bug 23674: Add ability to add note to canceled charge To test, with this patchset applied: 1) From patron accounting page -> Add a manual invoice 2) Under the transaction tab click 'Cancel charge' 3) You should see a modal that gives you the option to type in a note. 4) Type something in and select submit. 5) Ensure the note shows up in the note column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 168330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168330&action=edit Bug 23674: Fix duplicate ID's and label -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Keywords| |Academy, Sandbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168035|0 |1 is obsolete| | Attachment #168174|0 |1 is obsolete| | Attachment #168178|0 |1 is obsolete| | Attachment #168180|0 |1 is obsolete| | Attachment #168213|0 |1 is obsolete| | Attachment #168329|0 |1 is obsolete| | Attachment #168330|0 |1 is obsolete| | --- Comment #17 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 169782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169782&action=edit Bug 23674: Add ability to add a note to APPLY DISCOUNT To test: 1. APPLY PATCH and restart_all 2. Apply a manual invoice to a patron account. 3. Go to the patron record -> accounting -> transaction tab 4. Look for the 'Apply discount' button. 5. When the 'Apply discount' modal appears notcie the 'Note' field. 6. Add a note, make sure it gets applied to this accountline. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #18 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 169783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169783&action=edit Bug 23674: Add ability to add a note to pay individual and write-off individual To test: 1) Apply manual invoice to a patron account 2) Go to the patron record -> accounting -> transaction tab 3) Look for the "Pay" button under the actions column. Click this 4) Notice no place to enter note 5) Click the "Write off" button. Notice there is no place to enter note 6) Apply patch, restart_all 7) Notice that a "Note: " input appears in both the 'Pay' and 'Write off' tabs. 8) Write a not in the pay tab and confirm. Make sure this not shows up in the table. 9) Add another invoice and then test the note functionallity for the write-offs. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #19 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 169784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169784&action=edit Bug 23674: Add ability to add a note to issue payout To test: 1) Apply patch, restart_all 2) From patron accounting page -> Create manual credit. Put in some amount and press add credit. 3) Under the actions column, select 'Issue Payout' 4) You can now enter a note. Type something in and press confirm. 5) Ensure the note shows up in the note column. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #20 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 169785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169785&action=edit Bug 23674: Add ability to add note to void payment To test: 1) From patron accounting page -> Create manual credit. Put in some amount and press add credit. 2) Under the actions column, select "Void" 3) Notice no option for a note. Press cancel 4) Apply patch, restart_all 5) Press void again. This time, you should see a modal that gives you the option to type in a note. 6) Type something in and select submit. 7) Ensure the note shows up in the note column. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #21 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 169786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169786&action=edit Bug 23674: Add ability to add a note to issue refund To test: 1) Apply patch, restart_all 2) From patron accounting page -> Create manual invoice. Enter some amount and select save and pay. Press confirm. 3) In the transactions tab, for the invoice you just created, under the actions column select issue refund. 4) This should open a modal with the ability to enter a note for the refund. Type in a note and confirm. 5) Ensure the note correctly shows in the table. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #22 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 169787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169787&action=edit Bug 23674: Add ability to add note to canceled charge To test, with this patchset applied: 1) From patron accounting page -> Add a manual invoice 2) Under the transaction tab click 'Cancel charge' 3) You should see a modal that gives you the option to type in a note. 4) Type something in and select submit. 5) Ensure the note shows up in the note column. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #23 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 169788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169788&action=edit Bug 23674: Fix duplicate ID's and label Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roman.dolny@jezuici.pl --- Comment #24 from Roman Dolny <roman.dolny@jezuici.pl> --- Test notes: Test for "Bug 23674: Add ability to add a note to issue payout" works as described at the end, with full patchset. QA script: WARN members/boraccount.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 45, now: 46) WARN members/cancel-charge.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 4, now: 6) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #25 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Patch no longer applies due to Bootstrap 5 changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #26 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174300&action=edit Bug 23674: Account for Bootstrap5 changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169782|0 |1 is obsolete| | --- Comment #27 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174301&action=edit Bug 23674: Add ability to add a note to APPLY DISCOUNT To test: 1. APPLY PATCH and restart_all 2. Apply a manual invoice to a patron account. 3. Go to the patron record -> accounting -> transaction tab 4. Look for the 'Apply discount' button. 5. When the 'Apply discount' modal appears notcie the 'Note' field. 6. Add a note, make sure it gets applied to this accountline. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169783|0 |1 is obsolete| | --- Comment #28 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174302&action=edit Bug 23674: Add ability to add a note to pay individual and write-off individual To test: 1) Apply manual invoice to a patron account 2) Go to the patron record -> accounting -> transaction tab 3) Look for the "Pay" button under the actions column. Click this 4) Notice no place to enter note 5) Click the "Write off" button. Notice there is no place to enter note 6) Apply patch, restart_all 7) Notice that a "Note: " input appears in both the 'Pay' and 'Write off' tabs. 8) Write a not in the pay tab and confirm. Make sure this not shows up in the table. 9) Add another invoice and then test the note functionallity for the write-offs. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169784|0 |1 is obsolete| | --- Comment #29 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174303&action=edit Bug 23674: Add ability to add a note to issue payout To test: 1) Apply patch, restart_all 2) From patron accounting page -> Create manual credit. Put in some amount and press add credit. 3) Under the actions column, select 'Issue Payout' 4) You can now enter a note. Type something in and press confirm. 5) Ensure the note shows up in the note column. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169785|0 |1 is obsolete| | --- Comment #30 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174304&action=edit Bug 23674: Add ability to add note to void payment To test: 1) From patron accounting page -> Create manual credit. Put in some amount and press add credit. 2) Under the actions column, select "Void" 3) Notice no option for a note. Press cancel 4) Apply patch, restart_all 5) Press void again. This time, you should see a modal that gives you the option to type in a note. 6) Type something in and select submit. 7) Ensure the note shows up in the note column. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169786|0 |1 is obsolete| | --- Comment #31 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174305&action=edit Bug 23674: Add ability to add a note to issue refund To test: 1) Apply patch, restart_all 2) From patron accounting page -> Create manual invoice. Enter some amount and select save and pay. Press confirm. 3) In the transactions tab, for the invoice you just created, under the actions column select issue refund. 4) This should open a modal with the ability to enter a note for the refund. Type in a note and confirm. 5) Ensure the note correctly shows in the table. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169787|0 |1 is obsolete| | --- Comment #32 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174306&action=edit Bug 23674: Add ability to add note to canceled charge To test, with this patchset applied: 1) From patron accounting page -> Add a manual invoice 2) Under the transaction tab click 'Cancel charge' 3) You should see a modal that gives you the option to type in a note. 4) Type something in and select submit. 5) Ensure the note shows up in the note column. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169788|0 |1 is obsolete| | --- Comment #33 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174307&action=edit Bug 23674: Fix duplicate ID's and label Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174300|0 |1 is obsolete| | --- Comment #34 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174308&action=edit Bug 23674: Account for Bootstrap5 changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Mirjam Vantieghem <mirjam.vantieghem@etf.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirjam.vantieghem@etf.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38843 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174301|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 177225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177225&action=edit Bug 23674: Add ability to add a note to APPLY DISCOUNT To test: 1. APPLY PATCH and restart_all 2. Apply a manual invoice to a patron account. 3. Go to the patron record -> accounting -> transaction tab 4. Look for the 'Apply discount' button. 5. When the 'Apply discount' modal appears notcie the 'Note' field. 6. Add a note, make sure it gets applied to this accountline. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174302|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 177226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177226&action=edit Bug 23674: Add ability to add a note to pay individual and write-off individual To test: 1) Apply manual invoice to a patron account 2) Go to the patron record -> accounting -> transaction tab 3) Look for the "Pay" button under the actions column. Click this 4) Notice no place to enter note 5) Click the "Write off" button. Notice there is no place to enter note 6) Apply patch, restart_all 7) Notice that a "Note: " input appears in both the 'Pay' and 'Write off' tabs. 8) Write a not in the pay tab and confirm. Make sure this not shows up in the table. 9) Add another invoice and then test the note functionallity for the write-offs. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174303|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 177227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177227&action=edit Bug 23674: Add ability to add a note to issue payout To test: 1) Apply patch, restart_all 2) From patron accounting page -> Create manual credit. Put in some amount and press add credit. 3) Under the actions column, select 'Issue Payout' 4) You can now enter a note. Type something in and press confirm. 5) Ensure the note shows up in the note column. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174304|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 177228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177228&action=edit Bug 23674: Add ability to add note to void payment To test: 1) From patron accounting page -> Create manual credit. Put in some amount and press add credit. 2) Under the actions column, select "Void" 3) Notice no option for a note. Press cancel 4) Apply patch, restart_all 5) Press void again. This time, you should see a modal that gives you the option to type in a note. 6) Type something in and select submit. 7) Ensure the note shows up in the note column. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174305|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 177229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177229&action=edit Bug 23674: Add ability to add a note to issue refund To test: 1) Apply patch, restart_all 2) From patron accounting page -> Create manual invoice. Enter some amount and select save and pay. Press confirm. 3) In the transactions tab, for the invoice you just created, under the actions column select issue refund. 4) This should open a modal with the ability to enter a note for the refund. Type in a note and confirm. 5) Ensure the note correctly shows in the table. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174306|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 177230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177230&action=edit Bug 23674: Add ability to add note to canceled charge To test, with this patchset applied: 1) From patron accounting page -> Add a manual invoice 2) Under the transaction tab click 'Cancel charge' 3) You should see a modal that gives you the option to type in a note. 4) Type something in and select submit. 5) Ensure the note shows up in the note column. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174307|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 177231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177231&action=edit Bug 23674: Fix duplicate ID's and label Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174308|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 177232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177232&action=edit Bug 23674: Account for Bootstrap5 changes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #43 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 177233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177233&action=edit Bug 23674: (QA follow-up) Re-introduce cud-cancel op Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA --- Comment #44 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- This is a nice enhancements, makes the UI consistent and clean. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177225|0 |1 is obsolete| | --- Comment #45 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178059&action=edit Bug 23674: Add ability to add a note to APPLY DISCOUNT To test: 1. APPLY PATCH and restart_all 2. Apply a manual invoice to a patron account. 3. Go to the patron record -> accounting -> transaction tab 4. Look for the 'Apply discount' button. 5. When the 'Apply discount' modal appears notcie the 'Note' field. 6. Add a note, make sure it gets applied to this accountline. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177226|0 |1 is obsolete| | --- Comment #46 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178060&action=edit Bug 23674: Add ability to add a note to pay individual and write-off individual To test: 1) Apply manual invoice to a patron account 2) Go to the patron record -> accounting -> transaction tab 3) Look for the "Pay" button under the actions column. Click this 4) Notice no place to enter note 5) Click the "Write off" button. Notice there is no place to enter note 6) Apply patch, restart_all 7) Notice that a "Note: " input appears in both the 'Pay' and 'Write off' tabs. 8) Write a not in the pay tab and confirm. Make sure this not shows up in the table. 9) Add another invoice and then test the note functionallity for the write-offs. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177227|0 |1 is obsolete| | --- Comment #47 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178061&action=edit Bug 23674: Add ability to add a note to issue payout To test: 1) Apply patch, restart_all 2) From patron accounting page -> Create manual credit. Put in some amount and press add credit. 3) Under the actions column, select 'Issue Payout' 4) You can now enter a note. Type something in and press confirm. 5) Ensure the note shows up in the note column. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177228|0 |1 is obsolete| | --- Comment #48 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178062&action=edit Bug 23674: Add ability to add note to void payment To test: 1) From patron accounting page -> Create manual credit. Put in some amount and press add credit. 2) Under the actions column, select "Void" 3) Notice no option for a note. Press cancel 4) Apply patch, restart_all 5) Press void again. This time, you should see a modal that gives you the option to type in a note. 6) Type something in and select submit. 7) Ensure the note shows up in the note column. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177229|0 |1 is obsolete| | --- Comment #49 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178063&action=edit Bug 23674: Add ability to add a note to issue refund To test: 1) Apply patch, restart_all 2) From patron accounting page -> Create manual invoice. Enter some amount and select save and pay. Press confirm. 3) In the transactions tab, for the invoice you just created, under the actions column select issue refund. 4) This should open a modal with the ability to enter a note for the refund. Type in a note and confirm. 5) Ensure the note correctly shows in the table. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177230|0 |1 is obsolete| | --- Comment #50 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178064&action=edit Bug 23674: Add ability to add note to canceled charge To test, with this patchset applied: 1) From patron accounting page -> Add a manual invoice 2) Under the transaction tab click 'Cancel charge' 3) You should see a modal that gives you the option to type in a note. 4) Type something in and select submit. 5) Ensure the note shows up in the note column. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177231|0 |1 is obsolete| | --- Comment #51 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178065&action=edit Bug 23674: Fix duplicate ID's and label Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177232|0 |1 is obsolete| | --- Comment #52 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178066&action=edit Bug 23674: Account for Bootstrap5 changes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177233|0 |1 is obsolete| | --- Comment #53 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178067&action=edit Bug 23674: (QA follow-up) Re-introduce cud-cancel op Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #54 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Rebased with auto_rebase.pl script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #55 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry Lucas, can you have another go? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23674: Add ability to add a note to APPLY DISCOUNT Applying: Bug 23674: Add ability to add a note to pay individual and write-off individual Applying: Bug 23674: Add ability to add a note to issue payout Applying: Bug 23674: Add ability to add note to void payment error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt). error: could not build fake ancestor Patch failed at 0001 Bug 23674: Add ability to add note to void payment hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-23674-Add-ability-to-add-note-to-void-payment-u228tvwc.patch I recently had this issue on another patch and it applied nicely from a remote branch. Happy to try that here as well if you want to provide a link. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178059|0 |1 is obsolete| | --- Comment #56 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178791&action=edit Bug 23674: Add ability to add a note to APPLY DISCOUNT To test: 1. APPLY PATCH and restart_all 2. Apply a manual invoice to a patron account. 3. Go to the patron record -> accounting -> transaction tab 4. Look for the 'Apply discount' button. 5. When the 'Apply discount' modal appears notcie the 'Note' field. 6. Add a note, make sure it gets applied to this accountline. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178060|0 |1 is obsolete| | --- Comment #57 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178792&action=edit Bug 23674: Add ability to add a note to pay individual and write-off individual To test: 1) Apply manual invoice to a patron account 2) Go to the patron record -> accounting -> transaction tab 3) Look for the "Pay" button under the actions column. Click this 4) Notice no place to enter note 5) Click the "Write off" button. Notice there is no place to enter note 6) Apply patch, restart_all 7) Notice that a "Note: " input appears in both the 'Pay' and 'Write off' tabs. 8) Write a not in the pay tab and confirm. Make sure this not shows up in the table. 9) Add another invoice and then test the note functionallity for the write-offs. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178061|0 |1 is obsolete| | --- Comment #58 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178793&action=edit Bug 23674: Add ability to add a note to issue payout To test: 1) Apply patch, restart_all 2) From patron accounting page -> Create manual credit. Put in some amount and press add credit. 3) Under the actions column, select 'Issue Payout' 4) You can now enter a note. Type something in and press confirm. 5) Ensure the note shows up in the note column. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178062|0 |1 is obsolete| | --- Comment #59 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178794&action=edit Bug 23674: Add ability to add note to void payment To test: 1) From patron accounting page -> Create manual credit. Put in some amount and press add credit. 2) Under the actions column, select "Void" 3) Notice no option for a note. Press cancel 4) Apply patch, restart_all 5) Press void again. This time, you should see a modal that gives you the option to type in a note. 6) Type something in and select submit. 7) Ensure the note shows up in the note column. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178063|0 |1 is obsolete| | --- Comment #60 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178795&action=edit Bug 23674: Add ability to add a note to issue refund To test: 1) Apply patch, restart_all 2) From patron accounting page -> Create manual invoice. Enter some amount and select save and pay. Press confirm. 3) In the transactions tab, for the invoice you just created, under the actions column select issue refund. 4) This should open a modal with the ability to enter a note for the refund. Type in a note and confirm. 5) Ensure the note correctly shows in the table. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178064|0 |1 is obsolete| | --- Comment #61 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178796&action=edit Bug 23674: Add ability to add note to canceled charge To test, with this patchset applied: 1) From patron accounting page -> Add a manual invoice 2) Under the transaction tab click 'Cancel charge' 3) You should see a modal that gives you the option to type in a note. 4) Type something in and select submit. 5) Ensure the note shows up in the note column. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178065|0 |1 is obsolete| | --- Comment #62 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178797&action=edit Bug 23674: Fix duplicate ID's and label Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178066|0 |1 is obsolete| | --- Comment #63 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178798&action=edit Bug 23674: Account for Bootstrap5 changes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178067|0 |1 is obsolete| | --- Comment #64 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178799&action=edit Bug 23674: (QA follow-up) Re-introduce cud-cancel op Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #65 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Trivial rebase this time. Can be reset to PQA I think. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds the release notes| |ability to set notes on all | |actions in the transaction | |table on the staff | |interface. Staff can now | |add notes when applying | |discounts, paying | |individual fines, writing | |off individual fines, | |issuing a payouts, voiding | |payments, issuing refunds, | |and cancelling charges. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #66 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I did some testing in the GUI on this patch set and come back with some questions: 1) Partial payment and refund - Create a manual invoice, 10.00 - Pay using the pay button in the transactions table, 1:00 + note - Payment note is empty when checking the payments tab: It looks like the note used there now and the existing payment notes use different fields - should we not use the same for the payment note no matter where it's paid from? - Now issuing a refund explodes into: Exception 'Koha::Exceptions::ParameterTooHigh' thrown 'Amount to payout (3.00) is higher than amountoutstanding (0)' at /usr/share/perl5/Exception/Class/Base.pm line 88 - new bug? 2) Manual invoice + discount - Create a manual invoice, 10.00 - Apply discount: 1.00 The note field is before the amount, on the other forms it's the last input field on the form. Should we move it to make it more consistent? Can you please check? Void, refund and cancel all worked as expected in testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #67 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
- Create a manual invoice, 10.00 - Pay using the pay button in the transactions table, 1:00 + note - Payment note is empty when checking the payments tab: It looks like the note used there now and the existing payment notes use different fields - should we not use the same for the payment note no matter where it's paid from? - Now issuing a refund explodes into: Exception 'Koha::Exceptions::ParameterTooHigh' thrown 'Amount to payout (3.00) is higher than amountoutstanding (0)' at /usr/share/perl5/Exception/Class/Base.pm line 88 - new bug?
Part of this is a new bug, it happens without this patchset applied: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39219 I'll look into why the note is empty. Thanks, Cait! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #68 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
- Payment note is empty when checking the payments tab: It looks like the note used there now and the existing payment notes use different fields - should we not use the same for the payment note no matter where it's paid from?
I think its the same accountline note and we should display it on the payment tab if it exists. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #69 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178884&action=edit Bug 23674: Display note of the pay.tt when it exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #70 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
- Create a manual invoice, 10.00 - Apply discount: 1.00 The note field is before the amount, on the other forms it's the last input field on the form. Should we move it to make it more consistent?
Yes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #71 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178885&action=edit Bug 23674: Add note field the last field in discount modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #72 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I think I've addressed all your concerns here? Setting back to PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #73 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass (lukeg) from comment #68)
- Payment note is empty when checking the payments tab: It looks like the note used there now and the existing payment notes use different fields - should we not use the same for the payment note no matter where it's paid from?
I think its the same accountline note and we should display it on the payment tab if it exists.
I think if we also have a payment note, it's a little confusing that it's not available on paying. And having 2 notes later (adding the payment note) is not ideal. If we start out with this, we will have a bit of a mixed data situation later. I'd like to get another set of eyes if possible on the notes for payment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy, Sandbox | --- Comment #74 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #73)
(In reply to Lucas Gass (lukeg) from comment #68)
- Payment note is empty when checking the payments tab: It looks like the note used there now and the existing payment notes use different fields - should we not use the same for the payment note no matter where it's paid from?
I think its the same accountline note and we should display it on the payment tab if it exists.
I think if we also have a payment note, it's a little confusing that it's not available on paying. And having 2 notes later (adding the payment note) is not ideal. If we start out with this, we will have a bit of a mixed data situation later. I'd like to get another set of eyes if possible on the notes for payment.
I re-tested and I think I got it now - the payment note and the note from transactions are indeed the same field in the database: accountlines.note. I have a feeling that the notes fields for paying and writeoff on the 'Make a payment' tab could also need some thought, but that's out of scope here! Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #75 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Koha collecto <koha@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@collecto.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #76 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m --- Comment #77 from Lisette Scheer <lisette@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #74)
(In reply to Katrin Fischer from comment #73)
(In reply to Lucas Gass (lukeg) from comment #68)
- Payment note is empty when checking the payments tab: It looks like the note used there now and the existing payment notes use different fields - should we not use the same for the payment note no matter where it's paid from?
I think its the same accountline note and we should display it on the payment tab if it exists.
I think if we also have a payment note, it's a little confusing that it's not available on paying. And having 2 notes later (adding the payment note) is not ideal. If we start out with this, we will have a bit of a mixed data situation later. I'd like to get another set of eyes if possible on the notes for payment.
I re-tested and I think I got it now - the payment note and the note from transactions are indeed the same field in the database: accountlines.note.
I have a feeling that the notes fields for paying and writeoff on the 'Make a payment' tab could also need some thought, but that's out of scope here!
Thanks!
At some point peviously that note was the new note associated with the 'payment' account line. Now it always prompts you after you select pay, so I'm not sure if we should still call the column 'payment note" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40795 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40795 [Bug 40795] Fix +add note function on payment table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Stephanie <sbaker@aclsys.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbaker@aclsys.org --- Comment #78 from Stephanie <sbaker@aclsys.org> --- Currently, staff can add a note when selecting "Write off selected" or by editing each item individually after the write-off. However, there is no option to add a note when using "Write off all." It would be helpful to have the ability to add a note at the time of using the "Write off all" function, to ensure consistent documentation and save staff time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #79 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Stephanie from comment #78)
Currently, staff can add a note when selecting "Write off selected" or by editing each item individually after the write-off. However, there is no option to add a note when using "Write off all."
It would be helpful to have the ability to add a note at the time of using the "Write off all" function, to ensure consistent documentation and save staff time.
Hi Stephanie, since this has already been pushed and released - can you please file a new bug for this so it is more visible? Closed bugs get hidden from searches for one reason. You can use the "depends on" to still link to this bug report which will also email everyone on this one. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org