[Bug 20191] New: OAI/Server.t still fails on slow servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 Bug ID: 20191 Summary: OAI/Server.t still fails on slow servers Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 18794 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18794 [Bug 18794] OAI/Server.t fails on slow servers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- https://jenkins.koha-community.org/job/Koha_Master_D8/lastCompletedBuild/con... # Failed test 'ListIdentifiers with resumptionToken 2' # at t/db_dependent/OAI/Server.t line 153. # Structures begin differing at: # $got->{ListIdentifiers}{header}[2]{datestamp} = '2018-02-13T17:46:23Z' # $expected->{ListIdentifiers}{header}[2]{datestamp} = '2018-02-13T17:46:22Z' # PARAM:--- # resumptionToken: marcxml/6/1970-01-01T00:00:00Z/2018-02-13T23:59:59Z//0/0 # verb: ListIdentifiers # EXPECTED:--- # ListIdentifiers: # header: # - datestamp: 2018-02-13T17:46:22Z # identifier: TEST:686 # - datestamp: 2018-02-13T17:46:22Z # identifier: TEST:687 # - datestamp: 2018-02-13T17:46:22Z # identifier: TEST:688 # resumptionToken: # content: marcxml/9/1970-01-01T00:00:00Z/2018-02-13T23:59:59Z//0/0 # cursor: 9 # request: http://localhost # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd # RESPONSE:--- # ListIdentifiers: # header: # - datestamp: 2018-02-13T17:46:22Z # identifier: TEST:686 # - datestamp: 2018-02-13T17:46:22Z # identifier: TEST:687 # - datestamp: 2018-02-13T17:46:23Z # identifier: TEST:688 # resumptionToken: # content: marcxml/9/1970-01-01T00:00:00Z/2018-02-13T23:59:59Z//0/0 # cursor: 9 # request: http://localhost # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd # Failed test 'ListRecords marcxml with resumptionToken 2' # at t/db_dependent/OAI/Server.t line 153. # Structures begin differing at: # $got->{ListRecords}{record}[2]{header}{datestamp} = '2018-02-13T17:46:23Z' # $expected->{ListRecords}{record}[2]{header}{datestamp} = '2018-02-13T17:46:22Z' # PARAM:--- # resumptionToken: marcxml/6/1970-01-01T00:00:00Z/2018-02-13T23:59:59Z//0/0 # verb: ListRecords # EXPECTED:--- # ListRecords: # record: # - header: # datestamp: 2018-02-13T17:46:22Z # identifier: TEST:686 # metadata: # record: # controlfield: # content: ' lng' # tag: 008 # datafield: # - ind1: ' ' # ind2: ' ' # subfield: # code: a # content: Title 6 # tag: 245 # - ind1: ' ' # ind2: ' ' # subfield: # - code: c # content: 686 # - code: d # content: 586 # tag: 999 # leader: 00126 a2200061 4500 # xmlns: http://www.loc.gov/MARC21/slim # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd # - header: # datestamp: 2018-02-13T17:46:22Z # identifier: TEST:687 # metadata: # record: # controlfield: # content: ' lng' # tag: 008 # datafield: # - ind1: ' ' # ind2: ' ' # subfield: # code: a # content: Title 7 # tag: 245 # - ind1: ' ' # ind2: ' ' # subfield: # - code: c # content: 687 # - code: d # content: 587 # tag: 999 # leader: 00126 a2200061 4500 # xmlns: http://www.loc.gov/MARC21/slim # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd # - header: # datestamp: 2018-02-13T17:46:22Z # identifier: TEST:688 # metadata: # record: # controlfield: # content: ' lng' # tag: 008 # datafield: # - ind1: ' ' # ind2: ' ' # subfield: # code: a # content: Title 8 # tag: 245 # - ind1: ' ' # ind2: ' ' # subfield: # - code: c # content: 688 # - code: d # content: 588 # tag: 999 # leader: 00126 a2200061 4500 # xmlns: http://www.loc.gov/MARC21/slim # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd # resumptionToken: # content: marcxml/9/1970-01-01T00:00:00Z/2018-02-13T23:59:59Z//0/0 # cursor: 9 # request: http://localhost # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd # RESPONSE:--- # ListRecords: # record: # - header: # datestamp: 2018-02-13T17:46:22Z # identifier: TEST:686 # metadata: # record: # controlfield: # content: ' lng' # tag: 008 # datafield: # - ind1: ' ' # ind2: ' ' # subfield: # code: a # content: Title 6 # tag: 245 # - ind1: ' ' # ind2: ' ' # subfield: # - code: c # content: 686 # - code: d # content: 586 # tag: 999 # leader: 00126 a2200061 4500 # xmlns: http://www.loc.gov/MARC21/slim # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd # - header: # datestamp: 2018-02-13T17:46:22Z # identifier: TEST:687 # metadata: # record: # controlfield: # content: ' lng' # tag: 008 # datafield: # - ind1: ' ' # ind2: ' ' # subfield: # code: a # content: Title 7 # tag: 245 # - ind1: ' ' # ind2: ' ' # subfield: # - code: c # content: 687 # - code: d # content: 587 # tag: 999 # leader: 00126 a2200061 4500 # xmlns: http://www.loc.gov/MARC21/slim # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd # - header: # datestamp: 2018-02-13T17:46:23Z # identifier: TEST:688 # metadata: # record: # controlfield: # content: ' lng' # tag: 008 # datafield: # - ind1: ' ' # ind2: ' ' # subfield: # code: a # content: Title 8 # tag: 245 # - ind1: ' ' # ind2: ' ' # subfield: # - code: c # content: 688 # - code: d # content: 588 # tag: 999 # leader: 00126 a2200061 4500 # xmlns: http://www.loc.gov/MARC21/slim # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd # resumptionToken: # content: marcxml/9/1970-01-01T00:00:00Z/2018-02-13T23:59:59Z//0/0 # cursor: 9 # request: http://localhost # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd # Failed test 'ListRecords oai_dc with resumptionToken 2' # at t/db_dependent/OAI/Server.t line 153. # Structures begin differing at: # $got->{ListRecords}{record}[2]{header}{datestamp} = '2018-02-13T17:46:23Z' # $expected->{ListRecords}{record}[2]{header}{datestamp} = '2018-02-13T17:46:22Z' # PARAM:--- # resumptionToken: oai_dc/6/1970-01-01T00:00:00Z/2018-02-13T23:59:59Z//0/0 # verb: ListRecords # EXPECTED:--- # ListRecords: # record: # - header: # datestamp: 2018-02-13T17:46:22Z # identifier: TEST:686 # metadata: # oai_dc:dc: # dc:language: lng # dc:title: Title 6 # dc:type: {} # xmlns:dc: http://purl.org/dc/elements/1.1/ # xmlns:oai_dc: http://www.openarchives.org/OAI/2.0/oai_dc/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/oai_dc/ http://www.openarchives.org/OAI/2.0/oai_dc.xsd # - header: # datestamp: 2018-02-13T17:46:22Z # identifier: TEST:687 # metadata: # oai_dc:dc: # dc:language: lng # dc:title: Title 7 # dc:type: {} # xmlns:dc: http://purl.org/dc/elements/1.1/ # xmlns:oai_dc: http://www.openarchives.org/OAI/2.0/oai_dc/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/oai_dc/ http://www.openarchives.org/OAI/2.0/oai_dc.xsd # - header: # datestamp: 2018-02-13T17:46:22Z # identifier: TEST:688 # metadata: # oai_dc:dc: # dc:language: lng # dc:title: Title 8 # dc:type: {} # xmlns:dc: http://purl.org/dc/elements/1.1/ # xmlns:oai_dc: http://www.openarchives.org/OAI/2.0/oai_dc/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/oai_dc/ http://www.openarchives.org/OAI/2.0/oai_dc.xsd # resumptionToken: # content: oai_dc/9/1970-01-01T00:00:00Z/2018-02-13T23:59:59Z//0/0 # cursor: 9 # request: http://localhost # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd # RESPONSE:--- # ListRecords: # record: # - header: # datestamp: 2018-02-13T17:46:22Z # identifier: TEST:686 # metadata: # oai_dc:dc: # dc:language: lng # dc:title: Title 6 # dc:type: {} # xmlns:dc: http://purl.org/dc/elements/1.1/ # xmlns:oai_dc: http://www.openarchives.org/OAI/2.0/oai_dc/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/oai_dc/ http://www.openarchives.org/OAI/2.0/oai_dc.xsd # - header: # datestamp: 2018-02-13T17:46:22Z # identifier: TEST:687 # metadata: # oai_dc:dc: # dc:language: lng # dc:title: Title 7 # dc:type: {} # xmlns:dc: http://purl.org/dc/elements/1.1/ # xmlns:oai_dc: http://www.openarchives.org/OAI/2.0/oai_dc/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/oai_dc/ http://www.openarchives.org/OAI/2.0/oai_dc.xsd # - header: # datestamp: 2018-02-13T17:46:23Z # identifier: TEST:688 # metadata: # oai_dc:dc: # dc:language: lng # dc:title: Title 8 # dc:type: {} # xmlns:dc: http://purl.org/dc/elements/1.1/ # xmlns:oai_dc: http://www.openarchives.org/OAI/2.0/oai_dc/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/oai_dc/ http://www.openarchives.org/OAI/2.0/oai_dc.xsd # resumptionToken: # content: oai_dc/9/1970-01-01T00:00:00Z/2018-02-13T23:59:59Z//0/0 # cursor: 9 # request: http://localhost # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd # Looks like you failed 3 tests of 29. [17:46:24] t/db_dependent/OAI/Server.t .................................... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I did not manage to mock DateTime->now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- https://jenkins.koha-community.org/job/Koha_Master_D8/363/ https://jenkins.koha-community.org/job/Koha_Master_D8/367/ https://jenkins.koha-community.org/job/Koha_17.05_D8/78/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 71673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71673&action=edit Bug 20191: Make OAI/Server.t tests use timestamps from the DB Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- + Koha::Biblio::Metadatas->search({ biblionumber => $biblionumber }) Should use ->find instead, with (biblionumber, 'marcxml', 'MARC21'), do not you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71816&action=edit Bug 20191: Use find with unique key combination To prevent unexpected issues later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- still fails: https://jenkins.koha-community.org/job/Koha_Master_D8/377/console -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- and again: https://jenkins.koha-community.org/job/Koha_Master_D8/381/console -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I tried with Time::Fake but failed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 72009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72009&action=edit Bug 20191: Try and fix random failure from Server.t - v3... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is my try with Time::Fake, what's wrong? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I use `stress -c 4` to recreate the failures. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- These tests are constantly failing, I am going to remove them once and for all if these random failures are not fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #14)
These tests are constantly failing, I am going to remove them once and for all if these random failures are not fixed.
The HTTP::OAI::Header grabs gmtime() which could change between the creation time and the call time... How about this impending counter patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 --- Comment #16 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73669&action=edit Bug 20191: Use Test::MockTime to hold time still The problem is the calls to HTTP::OAI::Header, etc. may reference gmtime which is continually changing by the second. By forcing time to lock for all the tests, except the last one, we can be assured things should not fail. TEST PLAN --------- install libtest-mocktime-perl apply only this patch restart_all in kshell, prove t/db_dependent/OAI/Server.t run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71673|0 |1 is obsolete| | Attachment #71816|0 |1 is obsolete| | Attachment #72009|0 |1 is obsolete| | Attachment #73669|0 |1 is obsolete| | --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 73684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73684&action=edit Bug 20191: Use Test::MockTime to hold time still The problem is the calls to HTTP::OAI::Header, etc. may reference gmtime which is continually changing by the second. By forcing time to lock for all the tests, except the last one, we can be assured things should not fail. TEST PLAN --------- install libtest-mocktime-perl apply the patch restart_all in kshell, prove t/db_dependent/OAI/Server.t run koha qa test tools Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 73685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73685&action=edit Bug 20191: (QA follow-up) Require Jessie's Test::MockTime Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen@gmail.com |mtompset@hotmail.com Version|unspecified |master Keywords|additional_work_needed |dependency QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I tested with Mark's patch using 'stress -c 4' on a 2 cores kohadevbox (cpu load above 3). I managed to reproduce the issue without the patch, and can confirm the patch deals with the problem correctly. The solution is the right one too, one we talked about but didn't find the spot in which environment was leaking inside the tests. Good catch Mark! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Excellent Mark! It works great thanks a lot! Note for later: Maybe we should replace our mock of DateTime->now with this new module. Pushed to master for 18.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org