http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38324&action=edit Bug 10976: Fix typo itemtype vs itemtypes When creating a new report, the limit step let you choose itype|itemtype. But it should be itype|itemtypes. If you try to create a guided report and you choose this option as a limit, you will get a warning on saving it: Errors found when processing parameters for report: itype: The authorized value category (itemtype) you selected does not exist. Looking at the code: reports/guided_reports.pl l.657 elsif ( $authorised_value eq "itemtypes" ) { Test plan: 0/ Don't apply the patch 1/ Create a guided report, select Koha itemtype as a limit(step 4) 2/ Confirm you get the error when saving 3/ Apply the patch and repeat step 1 4/ There is no error and the report should work correctly -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Marc Véron from comment #2)

I can not trigger the error after test plan #2 (without patch).

Marc, Have you gone to the last step "Save your custom report"? Give a name to the report and click "save report". -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Marc Véron from comment #4)

Testing (without patch)

Home > Reports > Guided reports wizard Button [Bulid new] Step 1: Choose Circulaton , Not public Step 2: Report type Tabular Step 3: Choose some columns from Biblioitems and add them Step 4: Check "Koha itemtype" (BK), Check Type (issue)

Here check 'Koha itemtype' but don't choose a value. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 38657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38657&action=edit [Signed-off] Bug 10976: Fix typo itemtype vs itemtypes When creating a new report, the limit step let you choose itype|itemtype. But it should be itype|itemtypes. If you try to create a guided report and you choose this option as a limit, you will get a warning on saving it: Errors found when processing parameters for report: itype: The authorized value category (itemtype) you selected does not exist. Looking at the code: reports/guided_reports.pl l.657 elsif ( $authorised_value eq "itemtypes" ) { Test plan: 0/ Don't apply the patch 1/ Create a guided report, select Koha itemtype as a limit(step 4) 2/ Confirm you get the error when saving 3/ Apply the patch and repeat step 1 4/ There is no error and the report should work correctly Tested with steps in comment #4/#5, error is gone after applying patch. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38657|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38786&action=edit [PASSED QA] Bug 10976: Fix typo itemtype vs itemtypes When creating a new report, the limit step let you choose itype|itemtype. But it should be itype|itemtypes. If you try to create a guided report and you choose this option as a limit, you will get a warning on saving it: Errors found when processing parameters for report: itype: The authorized value category (itemtype) you selected does not exist. Looking at the code: reports/guided_reports.pl l.657 elsif ( $authorised_value eq "itemtypes" ) { Test plan: 0/ Don't apply the patch 1/ Create a guided report, select Koha itemtype as a limit(step 4) 2/ Confirm you get the error when saving 3/ Apply the patch and repeat step 1 4/ There is no error and the report should work correctly Tested with steps in comment #4/#5, error is gone after applying patch. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes.