[Bug 28363] New: Always use semicolon when preference CSVDelimiter is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28363 Bug ID: 28363 Summary: Always use semicolon when preference CSVDelimiter is missing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Some places use comma as value when preference CSVDelimiter is missing or empty.
From installer/data/mysql/mandatory/sysprefs.sql whe see that defaut install value is semicolon.
This patch sets semicolon when preference CSVDelimiter is missing. "We are perl, we love semicolon ;)" Test plan : 1) With SQL, set system preference 'CSVdelimiter' to empty string. 2) Create CSV export in impacted pages 3) Check columns are separated by semicolon character -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28363 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28327 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 [Bug 28327] System preference CSVdelimiter special case for tabulation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28363 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28363 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28363 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 121039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121039&action=edit Bug 28363: Always use semicolon when preference CSVDelimiter is missing Some places use comma as value when preference CSVDelimiter is missing or empty.
From installer/data/mysql/mandatory/sysprefs.sql whe see that default install value is semicolon.
This patch sets semicolon when preference CSVDelimiter is missing. "We are perl, we love semicolon ;)" Test plan : 1) With SQL, set system preference 'CSVdelimiter' to empty string. 2) Create CSV export in impacted pages 3) Check columns are separated by semicolon character https://bugs.koha-community.org/show_bug.cgi?id=28327 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28363 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- It seems strange to me to default to a semicolon. Shouldn't the default for Comma Separated Values be a comma? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28363 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- In this case we change value in installer. I propose a quick vote : comma or semicolon ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28363 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comma makes sense I guess - I believe this would be the case now mostly? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28363 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ah HEA says : https://hea.koha-community.org/systempreferences delimiter says : - semicolon : 8925 - comma 607 CSVDelimiter has only 19 comma. But we can argue only a few install change default value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28363 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Fridolin Somers from comment #5)
Ah HEA says : https://hea.koha-community.org/systempreferences
delimiter says : - semicolon : 8925 - comma 607
CSVDelimiter has only 19 comma.
But we can argue only a few install change default value.
Rereading the bug I am happy with semicolon as it appears the most consistent choice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28363 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- (In reply to Fridolin Somers from comment #5)
But we can argue only a few install change default value.
Exactly. I don't know why we don't have a more normal default value... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28363 Bug 28363 depends on bug 28327, which changed state. Bug 28327 Summary: System preference CSVdelimiter special case for tabulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28363 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- This has been fixed by Bug 28327 *** This bug has been marked as a duplicate of bug 28327 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org