[Bug 30725] New: BatchDeleteItem job param named wrongly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30725 Bug ID: 30725 Summary: BatchDeleteItem job param named wrongly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org It is clearly a copy and paste error, but the parameter is called 'record_ids' when it should be 'item_ids'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30725 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30710 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30710 [Bug 30710] Background tasks can be called multiple times on batch item deletion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30725 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28445 CC| |fridolin.somers@biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 [Bug 28445] Use the task queue for the batch delete and update items tool -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30725 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30725 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 135179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135179&action=edit Bug 30725: Rename BatchDeleteItem job param from record_ids to item_ids It is clearly a copy and paste error, but the parameter is called 'record_ids' when it should be 'item_ids'. Test plan : Run prove t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t Perform a batch items deletion via staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30725 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30725 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Then do the same with BatchUpdateItem I bet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30725 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30725 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135179|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 135442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135442&action=edit Bug 30725: Rename BatchDeleteItem job param from record_ids to item_ids It is clearly a copy and paste error, but the parameter is called 'record_ids' when it should be 'item_ids'. Test plan : Run prove t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t Perform a batch items deletion via staff interface Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30725 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes using koha-testing-docker: - Before applying the patch, I tested Tools > Batch item deletion using these item barcodes for Intermediate Perl (http://127.0.0.1:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=126): 39999000005134 39999000005110 39999000005158 39999000005097 ==> Items successfully deleted. - After applying the patch, I tested with these barcodes for Perl template toolkit (http://127.0.0.1:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=255): 39999000011111 39999000011135 39999000011074 39999000011098 ==> Items successfully deleted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30725 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I was using "record" as a generic term, not related to bibliographic records. If you really want to adjust it, then you should fix BatchUpdateItem as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30725 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Failed QA |RESOLVED --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #5)
I was using "record" as a generic term, not related to bibliographic records. If you really want to adjust it, then you should fix BatchUpdateItem as well.
Fair point. Even "item" can be considered as a generic term for an object in a list. It works, we should not touch it. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org