[Bug 40918] New: Invoice Adjustment Reason always "No reason" even if report shows a saved reason
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40918 Bug ID: 40918 Summary: Invoice Adjustment Reason always "No reason" even if report shows a saved reason Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: lisette@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. Go to Acquisition. 2. Create a vendor. 3. Click "Receive Shipment" 4. Enter an invoice number and save. 5. Go to Administration->Authorized Values->Add A Category 6. Name it ADJ_REASON 7. Put in 2 options 8. Go to invoices in Aqusition 9. Add an adjustment (enter an amount and select a reason, then save) 10. The reason is set to "no reason" 11. Go to reports 12. new sql report select * from aqinvoice_adjustments 13. Run the report and see your reason is saved. 14. go back to the invoice and click save adjustments 15. run the report again, see there's no longer a reason. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40918 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This reads like a data loss bug, upping severity. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40918 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Depends on| |38714 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- There is a foo here... Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714 [Bug 38714] Adjust templates for prettier -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40918 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40918 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187458&action=edit Bug 40918: Fix invoice adjustement reason selection From commit 46f7158f44ced21571dc9deef9ca240fc34a8e6b Bug 38714: acqui/invoice.tt Debugging stuff left, sorry! Test plan: 1. Go to Acquisition. 2. Create a vendor. 3. Click "Receive Shipment" 4. Enter an invoice number and save. 5. Go to Administration->Authorized Values->Add A Category 6. Name it ADJ_REASON 7. Put in 2 options 8. Go to invoices in Aqusition 9. Add an adjustment (enter an amount and select a reason, then save) 10. The reason is set to "no reason" 11. Go to reports 12. new sql report select * from aqinvoice_adjustments 13. Run the report and see your reason is saved. 14. go back to the invoice and click save adjustments 15. Run the report and see your reason is saved. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40918 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression, | |rel_25_05_candidate Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | CC| |me@paulderscheid.xyz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40918 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187458|0 |1 is obsolete| | --- Comment #4 from Eric Phetteplace <ephetteplace@cca.edu> --- Created attachment 187502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187502&action=edit Bug 40918: Fix invoice adjustement reason selection From commit 46f7158f44ced21571dc9deef9ca240fc34a8e6b Bug 38714: acqui/invoice.tt Debugging stuff left, sorry! Test plan: 1. Go to Acquisition. 2. Create a vendor. 3. Click "Receive Shipment" 4. Enter an invoice number and save. 5. Go to Administration->Authorized Values->Add A Category 6. Name it ADJ_REASON 7. Put in 2 options 8. Go to invoices in Aqusition 9. Add an adjustment (enter an amount and select a reason, then save) 10. The reason is set to "no reason" 11. Go to reports 12. new sql report select * from aqinvoice_adjustments 13. Run the report and see your reason is saved. 14. go back to the invoice and click save adjustments 15. Run the report and see your reason is saved. Signed-off-by: Eric Phetteplace <ephetteplace@cca.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40918 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace@cca.edu Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40918 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187502|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187666&action=edit Bug 40918: Fix invoice adjustement reason selection From commit 46f7158f44ced21571dc9deef9ca240fc34a8e6b Bug 38714: acqui/invoice.tt Debugging stuff left, sorry! Test plan: 1. Go to Acquisition. 2. Create a vendor. 3. Click "Receive Shipment" 4. Enter an invoice number and save. 5. Go to Administration->Authorized Values->Add A Category 6. Name it ADJ_REASON 7. Put in 2 options 8. Go to invoices in Aqusition 9. Add an adjustment (enter an amount and select a reason, then save) 10. The reason is set to "no reason" 11. Go to reports 12. new sql report select * from aqinvoice_adjustments 13. Run the report and see your reason is saved. 14. go back to the invoice and click save adjustments 15. Run the report and see your reason is saved. Signed-off-by: Eric Phetteplace <ephetteplace@cca.edu> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40918 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40918 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40918 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40918 Azucena Aguayo <azucena.aguayo@uvu.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |azucena.aguayo@uvu.edu --- Comment #7 from Azucena Aguayo <azucena.aguayo@uvu.edu> --- Will this get backported to 25.05? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40918 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40918 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40918 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 38714 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40918 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_25_05_candidate | CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40918 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #10 from David Nind <david@davidnind.com> --- Bug fix, no change to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org