[Bug 40292] New: SQL syntax error when upgrading to 25.05 on MariaDB 10.3, RENAME COLUMN unsupported
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Bug ID: 40292 Summary: SQL syntax error when upgrading to 25.05 on MariaDB 10.3, RENAME COLUMN unsupported Change sponsored?: --- Product: Koha Version: 25.05 Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs@lists.koha-community.org Reporter: paul.derscheid@lmscloud.de QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com Got this report on Mattermost for 25.05: Configurando koha-common (25.05.01-1) ... Upgrading database schema for biblio Upgrade to 24.12.00.042 [07:56:03]: Bug 39838 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39838) - Rename alias_id -> vendor_alias_id ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'COLUMN alias_id TO vendor_alias_id' at line 1 at /usr/share/koha/lib/C4/Installer.pm line 825 After investigation and confirmation, the usage of RENAME COLUMN is the problem. This syntax is unsupported in versions of MariaDB prior to 10.5.3, here's the relevant documentation for reference: mariadb dot com/docs/server/reference/sql-statements/data-definition/alter/alter-table#rename-column The solution is to fix the usage of RENAME COLUMN in the current db_revs and to write a coding guideline and a QA test to accompany it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #1 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 183706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183706&action=edit Bug 40292: Prevent SQL syntax error when upgrading to 25.05 on MariaDB 10.3 - Change `RENAME COLUMN <OLD> TO <NEW>` to `CHANGE COLUMN <OLD> <NEW> <DATATYPE (required for this syntax)>`. To test (assuming ktd): 1. Checkout upstream/24.11.x 2. Start ktd with `KOHA_IMAGE=24.11-bullseye(-arm64) DB_IMAGE=mariadb:10.3 ktd up -d` 3. Checkout upstream/main 4. Run updatedatabase in the Koha container 5. Observe the error regarding the unsupported syntax. 6. Tear everything down again: ktd down 7. Repeat 1-2. 8. Once started up, checkout upstream/main 9. Apply the patch on top of it 10. Run updatedatabase in the Koha container 11. Observe a successful upgrade 12. Sign off Side Note: I tested this against upstream/25.05.x, but this patch is based on main. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40295 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #2 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
The solution is to fix the usage of RENAME COLUMN in the current db_revs and to write a coding guideline and a QA test to accompany it.
For 2nd point: alternative/complement (much wider scope of the checks even if it's later in the workflow): Bug 40295 - Add CI job Koha_Main_MariaDB_update but with lowest MariaDB version (10.3) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |paul.derscheid@lmscloud.de |ity.org | CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- we need a test for this (qa and ideally xt as well) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183706|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183747&action=edit Bug 40292: Prevent SQL syntax error when upgrading to 25.05 on MariaDB 10.3 - Change `RENAME COLUMN <OLD> TO <NEW>` to `CHANGE COLUMN <OLD> <NEW> <DATATYPE (required for this syntax)>`. To test (assuming ktd): 1. Checkout upstream/24.11.x 2. Start ktd with `KOHA_IMAGE=24.11-bullseye(-arm64) DB_IMAGE=mariadb:10.3 ktd up -d` 3. Checkout upstream/main 4. Run updatedatabase in the Koha container 5. Observe the error regarding the unsupported syntax. 6. Tear everything down again: ktd down 7. Repeat 1-2. 8. Once started up, checkout upstream/main 9. Apply the patch on top of it 10. Run updatedatabase in the Koha container 11. Observe a successful upgrade 12. Sign off Side Note: I tested this against upstream/25.05.x, but this patch is based on main. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Status|Needs Signoff |Signed Off QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183748&action=edit Bug 40292: (follow-up) Add xt test to prevent future occurences Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183747|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 183749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183749&action=edit Bug 40292: Prevent SQL syntax error when upgrading to 25.05 on MariaDB 10.3 - Change `RENAME COLUMN <OLD> TO <NEW>` to `CHANGE COLUMN <OLD> <NEW> <DATATYPE (required for this syntax)>`. To test (assuming ktd): 1. Checkout upstream/24.11.x 2. Start ktd with `KOHA_IMAGE=24.11-bullseye(-arm64) DB_IMAGE=mariadb:10.3 ktd up -d` 3. Checkout upstream/main 4. Run updatedatabase in the Koha container 5. Observe the error regarding the unsupported syntax. 6. Tear everything down again: ktd down 7. Repeat 1-2. 8. Once started up, checkout upstream/main 9. Apply the patch on top of it 10. Run updatedatabase in the Koha container 11. Observe a successful upgrade 12. Sign off Side Note: I tested this against upstream/25.05.x, but this patch is based on main. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183748|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 183750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183750&action=edit Bug 40292: (follow-up) Add xt test to prevent future occurences Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Working on QA script addition -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- hold up! vendor_alias_id is loosing auto_increment after doing a diff on `describe aqbookseller_aliases;` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Thanks tuxayo, I overlooked that we need to seemingly specify everything as in mariadb com /docs/server/reference/sql-statements/data-definition/alter/alter-table#change-column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- With such changes you should run misc4dev/run_tests.pl with --run-db-upgrade-only -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #12 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 183754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183754&action=edit Bug 40292: Specify full datatypes as required for CHANGE COLUMN To test: 1. Follow the original test plan and compare the resulting tables to: MariaDB [koha_kohadev]> desc additional_field_values; +-----------+--------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +-----------+--------------+------+-----+---------+----------------+ | id | int(11) | NO | PRI | NULL | auto_increment | | field_id | int(11) | NO | MUL | NULL | | | record_id | int(11) | NO | | NULL | | | value | varchar(255) | NO | | | | +-----------+--------------+------+-----+---------+----------------+ 4 rows in set (0.003 sec) MariaDB [koha_kohadev]> desc aqbookseller_aliases; +-----------+--------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +-----------+--------------+------+-----+---------+----------------+ | alias_id | int(11) | NO | PRI | NULL | auto_increment | | vendor_id | int(11) | NO | MUL | NULL | | | alias | varchar(255) | NO | | NULL | | +-----------+--------------+------+-----+---------+----------------+ 3 rows in set (0.004 sec) MariaDB [koha_kohadev]> desc aqbookseller_interfaces; +---------------+--------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +---------------+--------------+------+-----+---------+----------------+ | interface_id | int(11) | NO | PRI | NULL | auto_increment | | vendor_id | int(11) | NO | MUL | NULL | | | type | varchar(80) | YES | | NULL | | | name | varchar(255) | NO | | NULL | | | uri | mediumtext | YES | | NULL | | | login | varchar(255) | YES | | NULL | | | password | mediumtext | YES | | NULL | | | account_email | mediumtext | YES | | NULL | | | notes | longtext | YES | | NULL | | +---------------+--------------+------+-----+---------+----------------+ 9 rows in set (0.003 sec) The Type field should be the only deviation from the previous version, Null and Extra should be identical. 2. Run misc4dev/run_tests.pl --run-db-upgrade-only 3. Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Tests are also picky about COMMENT perl /kohadevbox/misc4dev/run_tests.pl --run-db-compare-only --compare-with v24.11.00 And CHANGE COLUMN also requires them ^^" Follow-up coming. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 183775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183775&action=edit Bug 40292: Specify full datatypes and comment as required for CHANGE COLUMN To test: 1. Follow the original test plan and compare the resulting tables to: MariaDB [koha_kohadev]> desc additional_field_values; +-----------+--------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +-----------+--------------+------+-----+---------+----------------+ | id | int(11) | NO | PRI | NULL | auto_increment | | field_id | int(11) | NO | MUL | NULL | | | record_id | int(11) | NO | | NULL | | | value | varchar(255) | NO | | | | +-----------+--------------+------+-----+---------+----------------+ 4 rows in set (0.003 sec) MariaDB [koha_kohadev]> desc aqbookseller_aliases; +-----------+--------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +-----------+--------------+------+-----+---------+----------------+ | alias_id | int(11) | NO | PRI | NULL | auto_increment | | vendor_id | int(11) | NO | MUL | NULL | | | alias | varchar(255) | NO | | NULL | | +-----------+--------------+------+-----+---------+----------------+ 3 rows in set (0.004 sec) MariaDB [koha_kohadev]> desc aqbookseller_interfaces; +---------------+--------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +---------------+--------------+------+-----+---------+----------------+ | interface_id | int(11) | NO | PRI | NULL | auto_increment | | vendor_id | int(11) | NO | MUL | NULL | | | type | varchar(80) | YES | | NULL | | | name | varchar(255) | NO | | NULL | | | uri | mediumtext | YES | | NULL | | | login | varchar(255) | YES | | NULL | | | password | mediumtext | YES | | NULL | | | account_email | mediumtext | YES | | NULL | | | notes | longtext | YES | | NULL | | +---------------+--------------+------+-----+---------+----------------+ 9 rows in set (0.003 sec) The Type field should be the only deviation from the previous version, Null and Extra should be identical. 2. Run misc4dev/run_tests.pl --run-db-upgrade-only 3. Sign off Co-authored-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183750|0 |1 is obsolete| | --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 183777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183777&action=edit Bug 40292: (follow-up) Add xt test to prevent future occurences Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183749|0 |1 is obsolete| | --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 183778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183778&action=edit Bug 40292: Prevent SQL syntax error when upgrading to 25.05 on MariaDB 10.3 - Change `RENAME COLUMN <OLD> TO <NEW>` to `CHANGE COLUMN <OLD> <NEW> <DATATYPE (required for this syntax)>`. To test (assuming ktd): 1. Checkout upstream/24.11.x 2. Start ktd with `KOHA_IMAGE=24.11-bullseye(-arm64) DB_IMAGE=mariadb:10.3 ktd up -d` 3. Checkout upstream/main 4. Run updatedatabase in the Koha container 5. Observe the error regarding the unsupported syntax. 6. Tear everything down again: ktd down 7. Repeat 1-2. 8. Once started up, checkout upstream/main 9. Apply the patch on top of it 10. Run updatedatabase in the Koha container 11. Observe a successful upgrade 12. Sign off Side Note: I tested this against upstream/25.05.x, but this patch is based on main. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183775|0 |1 is obsolete| | --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 183779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183779&action=edit Bug 40292: Specify full datatypes and comment as required for CHANGE COLUMN To test: 1. Follow the original test plan and compare the resulting tables to: MariaDB [koha_kohadev]> desc additional_field_values; +-----------+--------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +-----------+--------------+------+-----+---------+----------------+ | id | int(11) | NO | PRI | NULL | auto_increment | | field_id | int(11) | NO | MUL | NULL | | | record_id | int(11) | NO | | NULL | | | value | varchar(255) | NO | | | | +-----------+--------------+------+-----+---------+----------------+ 4 rows in set (0.003 sec) MariaDB [koha_kohadev]> desc aqbookseller_aliases; +-----------+--------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +-----------+--------------+------+-----+---------+----------------+ | alias_id | int(11) | NO | PRI | NULL | auto_increment | | vendor_id | int(11) | NO | MUL | NULL | | | alias | varchar(255) | NO | | NULL | | +-----------+--------------+------+-----+---------+----------------+ 3 rows in set (0.004 sec) MariaDB [koha_kohadev]> desc aqbookseller_interfaces; +---------------+--------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +---------------+--------------+------+-----+---------+----------------+ | interface_id | int(11) | NO | PRI | NULL | auto_increment | | vendor_id | int(11) | NO | MUL | NULL | | | type | varchar(80) | YES | | NULL | | | name | varchar(255) | NO | | NULL | | | uri | mediumtext | YES | | NULL | | | login | varchar(255) | YES | | NULL | | | password | mediumtext | YES | | NULL | | | account_email | mediumtext | YES | | NULL | | | notes | longtext | YES | | NULL | | +---------------+--------------+------+-----+---------+----------------+ 9 rows in set (0.003 sec) The Type field should be the only deviation from the previous version, Null and Extra should be identical. 2. Run perl ../misc4dev/run_tests.pl --run-db-compare-only --compare-with v24.05.00 3. Sign off Co-authored-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- additional_field_values.record_id was a bit weird because there is another db rev (241200045.pl) that changes the type again and would overwrite the full column definition with a correct one. Fixing mistakes that would have been in 241200018.pl Still fully fixed anyway. (commit amended) ----- The xt test was not tidy. commit amended. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- This is what happens when hitting the bug. Apply the fix. And rerunning the upgrade: ---------------------- == 1. run the old upgrade == Upgrade to 24.12.00.018 [19:43:50]: Bug 38663 - Add additional fields to libraries Converting record_id from int(11) to VARCHAR(11)... ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'COLUMN new_record_id TO record_id' at line 1 at /kohadevbox/koha/C4/Installer.pm line 825 == 2. apply patches == == 3. retry to run the upgrade == kohadev-koha@kohadevbox:koha(testing-SO-QA)$ updatedatabase Upgrade to 24.12.00.018 [19:45:11]: Bug 38663 - Add additional fields to libraries No conversion needed for record_id column. ↑↑↑↑↑↑↑ that's where it leaves new_record_id [....] Upgrade to 24.12.00.045 [19:45:12]: Bug 38457 - Add additional fields to debit types ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Unknown column 'record_id' in 'additional_field_values' at /kohadevbox/koha/C4/Installer.pm line 825 ---------------------- - the temporary new_record_id is still hanging around with the data: blocking, fix should be obvious. - it's type is VARCHAR(11) and the conversion to VARCHAR(80) has been skipped. Non blocking and can end up staying like that. Causing a divergence with the DBIC schema files. I don't know what that will mess up with. Is there anything more to worry about? (and warranting more work, the above isn't IMHO) Admins should hopefully have rollbacked the upgrade and restored a backup instead of trying to guess what to fix. If they did anyway, then at least above is a warning about one non obvious thing. And they should look here for how to compare their database schema with kohastructure.sql https://gitlab.com/koha-community/koha-misc4dev/-/blob/e7657e08b73a0d7b5ef37... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183754|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39838 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39838 [Bug 39838] Vendor alias object under specified -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|25.05 |Main --- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Switching version to main as I thing the RM and RMaints filter on that so what would direct to the wrong person once passed QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |riches-cg@comcast.net --- Comment #21 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- *** Bug 40125 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Moving to FQA. The comment of Victor needs attention. Just wondering why you did not change the status yourself, Victor? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #23 from David Nind <david@davidnind.com> --- Another instance of this happening reported on Mattermost Chat (from 23.11 to 25.05) https://chat.koha-community.org/koha-community/pl/f98s7x3b1fb95pe4y4yg1imako -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Paul Derscheid from comment #0)
The solution is to fix the usage of RENAME COLUMN in the current db_revs and to write a coding guideline and a QA test to accompany it.
We already have a QA check it seems: https://gitlab.com/koha-community/qa-test-tools/-/blob/main/QohA/File/Perl.p... 176 push @forbidden_patterns, 177 { 178 pattern => qr{RENAME\s+COLUMN}i, 179 error => "RENAME COLUMN is not supported in MariaDB < 10.5.2 (see bug 40292)" 180 } 181 if $self->path =~ m|installer/data/mysql/atomicupdate/|; Isn't it working correctly? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@openfifth.c |testopia@bugs.koha-communit |o.uk |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- *** Bug 40767 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #26 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 187428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187428&action=edit Bug 40292: Use Test::NoWarnings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187428|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187438&action=edit Bug 40292: Use Test::NoWarnings Amended-by: Jonathan Druart Added + 1 to the plan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187439&action=edit Bug 40292: Add a specific error if a previous upgrade failed We can reach an inconsistent state if the upgrade DB failed and new_record_id has been created but renamed. I don't think we should try to recover from this state, but have a specific error message in this case. We will guide people asking for help. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187440&action=edit Bug 40292: Rename new_record_id if exists If some installs didn't notice the column was missing (not renamed) we can still do it now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #30 from Jonathan Druart <jonathan.druart@gmail.com> --- Here is my try to move this blocker forward -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183777|0 |1 is obsolete| | --- Comment #31 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 187441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187441&action=edit Bug 40292: (follow-up) Add xt test to prevent future occurences Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183778|0 |1 is obsolete| | --- Comment #32 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 187442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187442&action=edit Bug 40292: Prevent SQL syntax error when upgrading to 25.05 on MariaDB 10.3 - Change `RENAME COLUMN <OLD> TO <NEW>` to `CHANGE COLUMN <OLD> <NEW> <DATATYPE (required for this syntax)>`. To test (assuming ktd): 1. Checkout upstream/24.11.x 2. Start ktd with `KOHA_IMAGE=24.11-bullseye(-arm64) DB_IMAGE=mariadb:10.3 ktd up -d` 3. Checkout upstream/main 4. Run updatedatabase in the Koha container 5. Observe the error regarding the unsupported syntax. 6. Tear everything down again: ktd down 7. Repeat 1-2. 8. Once started up, checkout upstream/main 9. Apply the patch on top of it 10. Run updatedatabase in the Koha container 11. Observe a successful upgrade 12. Sign off Side Note: I tested this against upstream/25.05.x, but this patch is based on main. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183779|0 |1 is obsolete| | --- Comment #33 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 187443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187443&action=edit Bug 40292: Specify full datatypes and comment as required for CHANGE COLUMN To test: 1. Follow the original test plan and compare the resulting tables to: MariaDB [koha_kohadev]> desc additional_field_values; +-----------+--------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +-----------+--------------+------+-----+---------+----------------+ | id | int(11) | NO | PRI | NULL | auto_increment | | field_id | int(11) | NO | MUL | NULL | | | record_id | int(11) | NO | | NULL | | | value | varchar(255) | NO | | | | +-----------+--------------+------+-----+---------+----------------+ 4 rows in set (0.003 sec) MariaDB [koha_kohadev]> desc aqbookseller_aliases; +-----------+--------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +-----------+--------------+------+-----+---------+----------------+ | alias_id | int(11) | NO | PRI | NULL | auto_increment | | vendor_id | int(11) | NO | MUL | NULL | | | alias | varchar(255) | NO | | NULL | | +-----------+--------------+------+-----+---------+----------------+ 3 rows in set (0.004 sec) MariaDB [koha_kohadev]> desc aqbookseller_interfaces; +---------------+--------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +---------------+--------------+------+-----+---------+----------------+ | interface_id | int(11) | NO | PRI | NULL | auto_increment | | vendor_id | int(11) | NO | MUL | NULL | | | type | varchar(80) | YES | | NULL | | | name | varchar(255) | NO | | NULL | | | uri | mediumtext | YES | | NULL | | | login | varchar(255) | YES | | NULL | | | password | mediumtext | YES | | NULL | | | account_email | mediumtext | YES | | NULL | | | notes | longtext | YES | | NULL | | +---------------+--------------+------+-----+---------+----------------+ 9 rows in set (0.003 sec) The Type field should be the only deviation from the previous version, Null and Extra should be identical. 2. Run perl ../misc4dev/run_tests.pl --run-db-compare-only --compare-with v24.05.00 3. Sign off Co-authored-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187438|0 |1 is obsolete| | --- Comment #34 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 187444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187444&action=edit Bug 40292: Use Test::NoWarnings Amended-by: Jonathan Druart Added + 1 to the plan Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187439|0 |1 is obsolete| | --- Comment #35 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 187445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187445&action=edit Bug 40292: Add a specific error if a previous upgrade failed We can reach an inconsistent state if the upgrade DB failed and new_record_id has been created but renamed. I don't think we should try to recover from this state, but have a specific error message in this case. We will guide people asking for help. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187440|0 |1 is obsolete| | --- Comment #36 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 187446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187446&action=edit Bug 40292: Rename new_record_id if exists If some installs didn't notice the column was missing (not renamed) we can still do it now. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #37 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 187447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187447&action=edit Bug 40292: (QA follow-up) Tidy db_revs/241200018.pl, atomicupdate/bug_40292.pl Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #38 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Thanks for working on this @joubu! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #39 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Should we give sysadmins a hint? If record_id has been dropped already, it seems like changing new_record_id to record_id is the only thing to do ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #40 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Idea to squash here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #41 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Marcel de Rooy from comment #39)
Should we give sysadmins a hint? If record_id has been dropped already, it seems like changing new_record_id to record_id is the only thing to do ?
Maybe, I didn't want to provide SQL queries without knowing exactly what happened. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #42 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- [FAIL] xt/check_db_revs_sql_syntax.t FAIL forbidden_patterns forbidden pattern: Use https:// instead of http:// for URLs (line 18) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #43 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188061&action=edit Bug 40292: Use Koha::Devel::Files to list dbrevs For reusability and to limit files to the git index -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #44 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Marcel de Rooy from comment #42)
[FAIL] xt/check_db_revs_sql_syntax.t FAIL forbidden_patterns forbidden pattern: Use https:// instead of http:// for URLs (line 18)
Fixed in the last patch (that does more than that). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #45 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #44)
(In reply to Marcel de Rooy from comment #42)
[FAIL] xt/check_db_revs_sql_syntax.t FAIL forbidden_patterns forbidden pattern: Use https:// instead of http:// for URLs (line 18)
Fixed in the last patch (that does more than that).
I welcome enhancing code. But can we squash this now? How do we want to backport etc? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #46 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Marcel de Rooy from comment #45)
(In reply to Jonathan Druart from comment #44)
(In reply to Marcel de Rooy from comment #42)
[FAIL] xt/check_db_revs_sql_syntax.t FAIL forbidden_patterns forbidden pattern: Use https:// instead of http:// for URLs (line 18)
Fixed in the last patch (that does more than that).
I welcome enhancing code. But can we squash this now? How do we want to backport etc?
Better to not squash if we want to backport then. Tests should not process files that are not in the git repository, so this is a bug fix that should be part of this bug report IMO. You are correct that Koha::Devel::Files is not in all supported branches, but this specific patch can be skipped if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Bug 40292 depends on bug 39838, which changed state. Bug 39838 Summary: Vendor alias object under specified https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39838 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187441|0 |1 is obsolete| | --- Comment #47 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 188758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188758&action=edit Bug 40292: (follow-up) Add xt test to prevent future occurences Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187442|0 |1 is obsolete| | --- Comment #48 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 188759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188759&action=edit Bug 40292: Prevent SQL syntax error when upgrading to 25.05 on MariaDB 10.3 - Change `RENAME COLUMN <OLD> TO <NEW>` to `CHANGE COLUMN <OLD> <NEW> <DATATYPE (required for this syntax)>`. To test (assuming ktd): 1. Checkout upstream/24.11.x 2. Start ktd with `KOHA_IMAGE=24.11-bullseye(-arm64) DB_IMAGE=mariadb:10.3 ktd up -d` 3. Checkout upstream/main 4. Run updatedatabase in the Koha container 5. Observe the error regarding the unsupported syntax. 6. Tear everything down again: ktd down 7. Repeat 1-2. 8. Once started up, checkout upstream/main 9. Apply the patch on top of it 10. Run updatedatabase in the Koha container 11. Observe a successful upgrade 12. Sign off Side Note: I tested this against upstream/25.05.x, but this patch is based on main. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187443|0 |1 is obsolete| | --- Comment #49 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 188760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188760&action=edit Bug 40292: Specify full datatypes and comment as required for CHANGE COLUMN To test: 1. Follow the original test plan and compare the resulting tables to: MariaDB [koha_kohadev]> desc additional_field_values; +-----------+--------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +-----------+--------------+------+-----+---------+----------------+ | id | int(11) | NO | PRI | NULL | auto_increment | | field_id | int(11) | NO | MUL | NULL | | | record_id | int(11) | NO | | NULL | | | value | varchar(255) | NO | | | | +-----------+--------------+------+-----+---------+----------------+ 4 rows in set (0.003 sec) MariaDB [koha_kohadev]> desc aqbookseller_aliases; +-----------+--------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +-----------+--------------+------+-----+---------+----------------+ | alias_id | int(11) | NO | PRI | NULL | auto_increment | | vendor_id | int(11) | NO | MUL | NULL | | | alias | varchar(255) | NO | | NULL | | +-----------+--------------+------+-----+---------+----------------+ 3 rows in set (0.004 sec) MariaDB [koha_kohadev]> desc aqbookseller_interfaces; +---------------+--------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +---------------+--------------+------+-----+---------+----------------+ | interface_id | int(11) | NO | PRI | NULL | auto_increment | | vendor_id | int(11) | NO | MUL | NULL | | | type | varchar(80) | YES | | NULL | | | name | varchar(255) | NO | | NULL | | | uri | mediumtext | YES | | NULL | | | login | varchar(255) | YES | | NULL | | | password | mediumtext | YES | | NULL | | | account_email | mediumtext | YES | | NULL | | | notes | longtext | YES | | NULL | | +---------------+--------------+------+-----+---------+----------------+ 9 rows in set (0.003 sec) The Type field should be the only deviation from the previous version, Null and Extra should be identical. 2. Run perl ../misc4dev/run_tests.pl --run-db-compare-only --compare-with v24.05.00 3. Sign off Co-authored-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187444|0 |1 is obsolete| | --- Comment #50 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 188761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188761&action=edit Bug 40292: Use Test::NoWarnings Amended-by: Jonathan Druart Added + 1 to the plan Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187445|0 |1 is obsolete| | --- Comment #51 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 188762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188762&action=edit Bug 40292: Add a specific error if a previous upgrade failed We can reach an inconsistent state if the upgrade DB failed and new_record_id has been created but renamed. I don't think we should try to recover from this state, but have a specific error message in this case. We will guide people asking for help. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187446|0 |1 is obsolete| | --- Comment #52 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 188763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188763&action=edit Bug 40292: Rename new_record_id if exists If some installs didn't notice the column was missing (not renamed) we can still do it now. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187447|0 |1 is obsolete| | --- Comment #53 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 188764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188764&action=edit Bug 40292: (QA follow-up) Tidy db_revs/241200018.pl, atomicupdate/bug_40292.pl Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188061|0 |1 is obsolete| | --- Comment #54 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 188765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188765&action=edit Bug 40292: Use Koha::Devel::Files to list dbrevs For reusability and to limit files to the git index Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #55 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- No need to keep this waiting any longer, although I think that we dont make it easier for the Rmaints here.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #56 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.05 released in| | Status|Pushed to main |Pushed to stable --- Comment #57 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #58 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 39838 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #59 from David Nind <david@davidnind.com> --- Bug fix - no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org