[Bug 12225] New: SIP renewals do not respect the "no block" flag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Bug ID: 12225 Summary: SIP renewals do not respect the "no block" flag Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com If a renewal via SIP would produce an error due to being on reserve, or exceeding maximum renewals, Koha's SIP2 implementation will refuse to renew the item even if the "no block" flag is set to Y. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7560 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SIP renewals do not respect |SIP does not respect the |the "no block" flag |"no block" flag -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- It appears this happens for checkouts as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> --- There are a number of bugs meaning that Koha does not implement no_block handling although some of the ILS routines appear to handle it. The formats parsing fixed fields are incorrect for single character flags such as no_block In the template they are defined as C which does not return a single character string but the integer value of that octet so where the code tests if ($no_block eq 'Y') that always fails because no_block == 89 If you fix the above issuing a non_block checkout calls a method checkout_no_block unfortunately no such method is present and the SIPServer instance crashes Will try fixing these and testing if we can then get the correct behaviour -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com --- Comment #3 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 37446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37446&action=edit patch incorrect formats An initial patch correct the formats. But beware we dont want to deploy this until the affected handlers have been corrected, this bug has in effect been hiding a bigger one -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Switching status to 'needs signoff' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #5 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Reverted back to assigned as a much more extensive patch is required. For Info the no block flag is placed when the unit uploads transaction which werte recorded when the unit was offline. It flags that these Checkins, Checkouts and Renewals have occured and cannot be refused. We need to address 3 layers of bugs in the existing code. 1. Interpret the flag correctly (this was addressed by the original patch) at present the code has errors in testing the flag. 2. Supply the missing methods. The current code calls no-existent methods if ho_block is set which would cause the server to abort. The missing methods need to be supplied 3. Make the appropriate checks in those methods. Currently no checks are made that the transaction is processed correctly e.g. a no block checkin my record a return from loan at 1pm but if the book was reissued at 2pm it is an error to apply that checkin to the second issue Working on a fuller patch to address these issues -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org