[Bug 15108] New: OAI-PMH provider improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Bug ID: 15108 Summary: OAI-PMH provider improvements Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: olli-antti.kivilahti@jns.fi QA Contact: testopia@bugs.koha-community.org - Fixed date handling to use UTC as specs require. - Added support for deleted records. - Added support for second precision in time stamps. - Added support for marc21 metadata prefix as recommended in the guidelines (synonym for marcxml). - ListIdentifiers and ListRecords always return records in biblionumber order. - Improved performance of database queries especially for large collections. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |olli-antti.kivilahti@jns.fi -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |3206 Blocks| |14939 CC| |frederic@tamil.fr --- Comment #1 from Frédéric Demians <frederic@tamil.fr> --- Do you plan to work on this? Support for deleted record is already there in master. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 [Bug 3206] OAI repository deleted record support http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 [Bug 14939] OAI Server classes must be modularized -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Hi! We got somebody from the national library to take a look at the OAI-PMH-implementation of Koha, and the Bugzilla entries didn't help a lot in deciphering what features have been implemented since 3.16. I will provide the commit as soon as I receive the improved version of this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #3 from Frédéric Demians <frederic@tamil.fr> ---
We got somebody from the national library to take a look at the OAI-PMH-implementation of Koha, and the Bugzilla entries didn't help a lot in deciphering what features have been implemented since 3.16. 11 I will provide the commit as soon as I receive the improved version of this patch.
Please work on the top of bug 14939. Signing it would even been better. Having a modularized OAI server will help a lot in term of maintainability. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #4 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 44317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44317&action=edit Bug 15108 - OAI-PMH provider improvements - Fixed date handling to use UTC as specs require. - Added support for deleted records. - Added support for second precision in time stamps. - Added support for marc21 metadata prefix as recommended in the guidelines (synonym for marcxml). - ListIdentifiers and ListRecords always return records in biblionumber order. - Improved performance of database queries especially for large collections. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #5 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 44318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44318&action=edit Bug 15108 - OAI-PMH provider improvements. AtomicUpdate. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #6 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- (In reply to Frédéric Demians from comment #3)
We got somebody from the national library to take a look at the OAI-PMH-implementation of Koha, and the Bugzilla entries didn't help a lot in deciphering what features have been implemented since 3.16. 11 I will provide the commit as soon as I receive the improved version of this patch.
Please work on the top of bug 14939. Signing it would even been better. Having a modularized OAI server will help a lot in term of maintainability.
I agree. Modularity is awesome. Having complete test coverage is even better. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Failing QA because of missing tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #8 from Frédéric Demians <frederic@tamil.fr> ---
I agree. Modularity is awesome. Having complete test coverage is even better.
Now, there isn't any test at all now. So modularizing is a first step. If you want tests, add them. And don't forget UT for you own patch which modify a lot of OAI server code without guaranty it won't something somewhere. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #9 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- (In reply to Frédéric Demians from comment #8)
I agree. Modularity is awesome. Having complete test coverage is even better.
Now, there isn't any test at all now. So modularizing is a first step. If you want tests, add them. And don't forget UT for you own patch which modify a lot of OAI server code without guaranty it won't something somewhere.
Just sharing the code here in hopes of it being helpful. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #10 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- And you should make tests before you refactor. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #11 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Olli-Antti Kivilahti from comment #10)
And you should make tests before you refactor.
You're welcome. It's modularizing not refactoring. The existing classes are split from oai.pl into individual .pm files, one per class. It doesn't change a line of code. So coding a full UT for OAI server would be awesome, I can't disagree, but it isn't a requirement for this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14939 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14939 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 [Bug 14939] OAI Server classes must be modularized -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org