http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15380 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Acquisitions |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15380 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45702&action=edit Bug 15380: Move Koha::Authority to Koha::MetadataRecord::Authority The existing Koha::Authority does not use Koha::Objects and does not exclusively deal with DB objects. It makes much sense to move it to let the space free for a Koha::Authority and Koha::Authorities modules based on Koha::Object. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15380 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45704&action=edit Bug 15380: Use Koha::Authority::Type[s] in admin script This path rewrites the admin/authtypes.pl script to use the new modules instead of executing the SQL queries from the script. Test plan: 1/ Create 1+ authority types 2/ Update one 3/ Delete it 4/ Create an authority record using this authority type. 5/ Try to delete the authority type Here there is a change in the behavior. Prior to this patch, the user was able to delete the authority type, now it's not. I think it was a bug, feel free to give your opinion if you disagree on this change. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15380 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45703|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 45781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45781&action=edit Bug 15380: Introduce Koha::Authorit[y|ies] and Koha::Authority::Type[s] Based on Koha::Objects. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15380 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #7 from Marc Véron <veron@veron.ch> --- Tested all patches together, followed test plan, works as expected. Prevent deleting an authority type that is in use makes sense. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15380 Ian Palko <library@stas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |library@stas.org --- Comment #8 from Ian Palko <library@stas.org> --- I am wondering if changes with Koha::Authority here will help solve the problem over in Bug 15358. When Bernardo was doing some testing to try to resolve it, he was having issues after reverting the patch from Bug 8064 with authorities merging failing due to : "In authorities/merge.pl, $recordObj1->authtype method returns 'undef', it's a Koha::MetadataRecord object." Perhaps before these changes to Koha::MetadataRecord::Authority are pushed the necessary changes can be made to harmonize it with repairing of the broken authorities merge. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15380 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45780|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 45932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45932&action=edit Bug 15380: Move Koha::Authority to Koha::MetadataRecord::Authority The existing Koha::Authority does not use Koha::Objects and does not exclusively deal with DB objects. It makes much sense to move it to let the space free for a Koha::Authority and Koha::Authorities modules based on Koha::Object. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15380 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45782|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 45934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45934&action=edit Bug 15380: Use Koha::Authority::Type[s] in admin script This path rewrites the admin/authtypes.pl script to use the new modules instead of executing the SQL queries from the script. Test plan: 1/ Create 1+ authority types 2/ Update one 3/ Delete it 4/ Create an authority record using this authority type. 5/ Try to delete the authority type Here there is a change in the behavior. Prior to this patch, the user was able to delete the authority type, now it's not. I think it was a bug, feel free to give your opinion if you disagree on this change. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15380 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #14 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to master - pretty cool :) thanks Jonathan -- You are receiving this mail because: You are watching all bug changes.