http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3164 Maria Laude <maria.laude@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maria.laude@liblime.com -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3164 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2009-05-02 19:08:35 --- Ryan, are you saying that if the template includes a hidden form field with the user's default branch the bug would be fixed? I tried this: <!-- TMPL_UNLESS NAME="singleBranchMode" --> ... normal branch select ... <!-- TMPL_ELSE --> <!-- TMPL_LOOP NAME="branchChoicesLoop" --> <!-- TMPL_IF name="selected" --><input type="hidden" name="branch" value="<!-- TMPL_VAR NAME="value" -->" /><!-- /TMPL_IF --> <!-- /TMPL_LOOP --> <!-- /TMPL_UNLESS --> ...but I got the same error. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3164 Cookie Wolfrom <cookie.wolfrom@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cookie.wolfrom@liblime.com -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3164 Beverly Church <beverly.church@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole.engard@liblime.com -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3164 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|oleonard@myacpl.org |jmf@liblime.com Priority|PATCH-Sent |P5 Platform|PC |All --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2009-09-10 14:17:18 --- This was Galen's response on the patches list following Ryan's submission: On Sat, May 30, 2009 at 7:03 PM, Ryan Higgins <rch@liblime.com> wrote:

+ my @selectedItems = split(/\//, $selectedItems, $MAX_SIMULTANEOUS_RESERVES);

Seems like $MAX_SIMULTANEOUS_RESERVES * 3 would be more accurate.

- my $branch = shift(@selectedItems); # i.e., branch code, not name - - my $singleBranchMode = $template->param('singleBranchMode'); - if ($singleBranchMode) { - $branch = $borr->{'branchcode'}; - } + my $branch = ($singleBranchMode) ? $borr->{'branchcode'} : shift(@selectedItems);

This breaks parsing of the selected items parameter. Prior to this patch, three values ($biblionumber, $itemnumber, and $branch) always got shifted off of the @selectedItems array during each loop iteration, whereas now only two get snarfed if you're in single branch mode. However, the form doesn't know that, and still supplies a triplet for each request. Please fix and resubmit. Regards, Galen -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3164 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-05-10 12:56:48 --- This is still a problem in 3.01.00.133 With singleBranchMode ON placing holds in OPAC does not work: Item level hold: ERROR: No biblionumber received. Bib level hold (next available): ERROR: Internal error: incomplete hold request. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.