http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3164 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|oleonard@myacpl.org |jmf@liblime.com Priority|PATCH-Sent |P5 Platform|PC |All --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2009-09-10 14:17:18 --- This was Galen's response on the patches list following Ryan's submission: On Sat, May 30, 2009 at 7:03 PM, Ryan Higgins <rch@liblime.com> wrote:
+ my @selectedItems = split(/\//, $selectedItems, $MAX_SIMULTANEOUS_RESERVES);
Seems like $MAX_SIMULTANEOUS_RESERVES * 3 would be more accurate.
- my $branch = shift(@selectedItems); # i.e., branch code, not name - - my $singleBranchMode = $template->param('singleBranchMode'); - if ($singleBranchMode) { - $branch = $borr->{'branchcode'}; - } + my $branch = ($singleBranchMode) ? $borr->{'branchcode'} : shift(@selectedItems);
This breaks parsing of the selected items parameter. Prior to this patch, three values ($biblionumber, $itemnumber, and $branch) always got shifted off of the @selectedItems array during each loop iteration, whereas now only two get snarfed if you're in single branch mode. However, the form doesn't know that, and still supplies a triplet for each request. Please fix and resubmit. Regards, Galen -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.