[Bug 19869] New: Move template JavaScript to the footer: UNIMARC editor plugins, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19869 Bug ID: 19869 Summary: Move template JavaScript to the footer: UNIMARC editor plugins, part 3 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 17858 Most UNIMARC plugin templates already have JavaScript at the bottom of the template instead of the top, but they should still be modified to be consistent with other templates which have been updated as part of Bug 17858. This patch modifies even more UNIMARC editor plugins. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19869 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19869 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70080&action=edit Bug 19869: Move template JavaScript to the footer: UNIMARC editor plugins, part 3 This patch updates even more UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin.
From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor.
- unimarc_field_123a.tt - unimarc_field_123d.tt - unimarc_field_123e.tt - unimarc_field_123f.tt - This template has been modified, but doesn't appear to be used. The unimarc_field_1234.pl script uses unimarc_field_123g.tt as its template. - unimarc_field_123g.tt - unimarc_field_123i_j.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19869 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19869 abernaud <anne-claire.bernaudin@univ-rennes1.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anne-claire.bernaudin@univ- | |rennes1.fr --- Comment #2 from abernaud <anne-claire.bernaudin@univ-rennes1.fr> --- Hi Owen for 123$f, it works both with the unimarc_field_123f.pl and with the unimarc_field_123g.pl. Please note that I did not have a single plugin for $i and $j as I supposed reading : "- unimarc_field_123i_j.tt" On my sandbox (http://pro.user10-koha.sandbox.biblibre.eu) there were 2 different plugins unimarc_field_123i.pl and unimarc_field_123j.pl. Everything works well, so I sign it off :). Anne-Claire -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19869 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Anne-Claire Bernaudin <anne-claire.bernaudin@univ-rennes1.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19869 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70080|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19869 --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 72994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72994&action=edit Bug 19869: Move template JavaScript to the footer: UNIMARC editor plugins, part 3 This patch updates even more UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin.
From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor.
- unimarc_field_123a.tt - unimarc_field_123d.tt - unimarc_field_123e.tt - unimarc_field_123f.tt - This template has been modified, but doesn't appear to be used. The unimarc_field_1234.pl script uses unimarc_field_123g.tt as its template. - unimarc_field_123g.tt - unimarc_field_123i_j.tt Signed-off-by: Anne-Claire Bernaudin <anne-claire.bernaudin@univ-rennes1.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19869 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19869 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72994|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73250&action=edit Bug 19869: Move template JavaScript to the footer: UNIMARC editor plugins, part 3 This patch updates even more UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin.
From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor.
- unimarc_field_123a.tt - unimarc_field_123d.tt - unimarc_field_123e.tt - unimarc_field_123f.tt - This template has been modified, but doesn't appear to be used. The unimarc_field_1234.pl script uses unimarc_field_123g.tt as its template. - unimarc_field_123g.tt - unimarc_field_123i_j.tt Signed-off-by: Anne-Claire Bernaudin <anne-claire.bernaudin@univ-rennes1.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19869 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |19868 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868 [Bug 19868] Move template JavaScript to the footer: UNIMARC editor plugins, part 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19869 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19872 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19872 [Bug 19872] Move template JavaScript to the footer: UNIMARC editor plugins, part 4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19869 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19869 Bug 19869 depends on bug 19868, which changed state. Bug 19868 Summary: Move template JavaScript to the footer: UNIMARC editor plugins, part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19869 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all, enhancement, not backported for stable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org