[Bug 19868] New: Move template JavaScript to the footer: UNIMARC editor plugins, part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868 Bug ID: 19868 Summary: Move template JavaScript to the footer: UNIMARC editor plugins, part 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 19864 Blocks: 17858 Most UNIMARC plugin templates already have JavaScript at the bottom of the template instead of the top, but they should still be modified to be consistent with other templates which have been updated as part of Bug 17858. This patch modifies several more UNIMARC editor plugins. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19864 [Bug 19864] UNIMARC field 100 plugin broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|19864 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19864 [Bug 19864] UNIMARC field 100 plugin broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70078&action=edit Bug 19868: Move template JavaScript to the footer: UNIMARC editor plugins, part 2 This patch updates several more UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin.
From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor.
- unimarc_field_116.tt - unimarc_field_117.tt - unimarc_field_120.tt - unimarc_field_121a.tt - unimarc_field_121b.tt - unimarc_field_122.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70078|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 72636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72636&action=edit Bug 19868: Move template JavaScript to the footer: UNIMARC editor plugins, part 2 This patch updates several more UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin.
From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor.
- unimarc_field_116.tt - unimarc_field_117.tt - unimarc_field_120.tt - unimarc_field_121a.tt - unimarc_field_121b.tt - unimarc_field_122.tt Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72636|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73249&action=edit Bug 19868: Move template JavaScript to the footer: UNIMARC editor plugins, part 2 This patch updates several more UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin.
From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor.
- unimarc_field_116.tt - unimarc_field_117.tt - unimarc_field_120.tt - unimarc_field_121a.tt - unimarc_field_121b.tt - unimarc_field_122.tt Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |19866 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866 [Bug 19866] Move template JavaScript to the footer: UNIMARC editor plugins, part 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19869 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19869 [Bug 19869] Move template JavaScript to the footer: UNIMARC editor plugins, part 3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868 Bug 19868 depends on bug 19866, which changed state. Bug 19866 Summary: Move template JavaScript to the footer: UNIMARC editor plugins, part 1 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |nick@bywatersolutions.com Status|Pushed to Master |RESOLVED --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all, enhancement, not backported for stable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org