http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 Winona Salesky <wsalesky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wsalesky@gmail.com --- Comment #1 from Winona Salesky <wsalesky@gmail.com> --- Any preferred location in the record for this display? My instinct is to place it either next to or below "Material Type" -Winona (In reply to Nicole C. Engard from comment #0)

655: Display as Genre/Form (full display): Display corresponding subfields a, v, x, y, z. This change would bring Koha’s display in line with the now codified practice of separating about-ness (subject headings) from is-ness (genre/form headings).

If you're interested, for more info on that, see: http://www.loc.gov/catdir/cpso/genre_form_faq.pdf

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 rgravel@marlboro.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rgravel@marlboro.edu --- Comment #2 from rgravel@marlboro.edu --- I'm not exactly sure where "Material type" is landing now, however, I will note that Genre/Form headings are closely related to "Subject(s)," and so I think they should be displayed near them. I had originally contemplated them following "Subject(s)" but am open to other suggestions! Thanks so much, Winona! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 --- Comment #4 from Winona Salesky <wsalesky@gmail.com> --- Created attachment 36918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36918&action=edit 655 display in XSLT -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 --- Comment #5 from Winona Salesky <wsalesky@gmail.com> --- Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 655 4) Perform an opac search that would show the record in the search results 5) Note this patch adds field 655 to display. Displays subfields a,v,x,y,z. uses a vertical bar to separate multiple titles. Vertical bar is wrapped in span class="separator" for easy suppression/customization of separator. 6) Repeat steps 4 and 5 for the staff interface -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 --- Comment #7 from Winona Salesky <wsalesky@gmail.com> --- Thanks Nick, I will take a look and fix these two issues. -Winona (In reply to Nick Clemens from comment #6)

Looks good in terms of displaying the correct fields, but two issues:

1 - 655 are now showing in both the Subject and Genre/Form Sections, they should only show as Genre/Form

2 - When displaying as Genre/Form the headings are not linked for searching, I think they should still be clickable. This is just my opinion though, willing to concede ts one.

(In reply to Winona Salesky from comment #5)

...

Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 655 4) Perform an opac search that would show the record in the search results 5) Note this patch adds field 655 to display. Displays subfields a,v,x,y,z. uses a vertical bar to separate multiple titles. Vertical bar is wrapped in span class="separator" for easy suppression/customization of separator. 6) Repeat steps 4 and 5 for the staff interface

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 --- Comment #8 from Winona Salesky <wsalesky@gmail.com> --- Created attachment 37937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37937&action=edit Bug 13433 - 655 display in XSLT Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 655 4) Perform an opac search and select records with 655 field that would show the record in the search results 5) Note this patch adds field 655 to display. Displays subfields a,v,x,y,z. uses a vertical bar to separate multiple titles. Vertical bar is wrapped in span class="separator" for easy suppression/customization of separator. 6) Repeat steps 4 and 5 for the staff interface -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37937|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 37987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37987&action=edit [SIGNED OFF] Bug 13433 - 655 display in XSLT Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 655 4) Perform an opac search and select records with 655 field that would show the record in the search results 5) Note this patch adds field 655 to display. Displays subfields a,v,x,y,z. uses a vertical bar to separate multiple titles. Vertical bar is wrapped in span class="separator" for easy suppression/customization of separator. 6) Repeat steps 4 and 5 for the staff interface Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37986|0 |1 is obsolete| | Attachment #37987|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38102&action=edit [PASSED QA] Bug 13433 - Added 655 display to OPAC and staff full views. This patch field 655 to the full displays in the staff and OPAC views. Multiple 655 fields are separated with a span class=separator | . To test: * Search the opac for records with genre/field 655 * Click the title * Make sure the fields display properly * Repeat for a few more titles * Repeat in the Staff Client http://bugs.koha-community.org/show_bug.cgi?id=13433 Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Winona! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 Irma Birchall <irma@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |irma@calyx.net.au -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.