[Bug 15047] New: Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Bug ID: 15047 Summary: Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: mtj@kohaaloha.com QA Contact: testopia@bugs.koha-community.org Created attachment 43726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43726&action=edit pix, before patch pix attached -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13433 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 [Bug 13433] 655 display in XSLT -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- Created attachment 43728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43728&action=edit Bug 15047 - Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled to test... 1/ create a 655$a subfield in a bib, with some general info - save bib 2/ view bib in opac-detail.pl - confim genre/form is displayed, but non-clickable :/ 3/ apply patch 4/ confim genre/form is displayed, and *is* clickable :0) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 --- Comment #2 from Mason James <mtj@kohaaloha.com> --- Created attachment 43729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43729&action=edit pic, after patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15048 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 --- Comment #3 from Winona Salesky <wsalesky@gmail.com> --- Created attachment 43767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43767&action=edit Bug 15047 - 655 URL not clickable in opac-detail. Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 655 4) Perform an opac search and select records with 655 field, select record and review details page. 5) Check that 655 field is clickable. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15048 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 43767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43767 Bug 15047 - 655 URL not clickable in opac-detail. Review of attachment 43767: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15047&attachment=43767) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl @@ +785,4 @@
<xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=an:<xsl:value-of select="marc:subfield[@code=9]"/></xsl:attribute> </xsl:when> <xsl:when test="$TraceSubjectSubdivisions='1'"> + <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=<xsl:call-template name="subfieldSelectSubject">
Why the name change? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- The two patches conflict, and Mark's question could use an answer -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43728|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #6 from Mason James <mtj@kohaaloha.com> --- (In reply to Nick Clemens from comment #5)
The two patches conflict,
I have marked my patch obsolete -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Winona Salesky <wsalesky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wsalesky@gmail.com --- Comment #7 from Winona Salesky <wsalesky@gmail.com> --- Sorry for the lack of communication. We actually submitted the patches at nearly the same time. The only difference is my patch uses the named template subfieldSelectSubject not subfieldSelect. The subfieldSelectSubject template was developed to address issues with parentheses in subject searches. The subfieldSelectSubject template strips parentheses from the search string. RE: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13650 Hope that helps clarify. -Winona (In reply to Mason James from comment #6)
(In reply to Nick Clemens from comment #5)
The two patches conflict,
I have marked my patch obsolete
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43767|0 |1 is obsolete| | --- Comment #8 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 44977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44977&action=edit [SIGNED-OFF]Bug 15047: 655 URL not clickable in opac-detail. Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 655 4) Perform an opac search and select records with 655 field, select record and review details page. 5) Check that 655 field is clickable. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. 655 field clickable -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44977|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44984&action=edit [PASSED QA] Bug 15047: 655 URL not clickable in opac-detail. Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 655 4) Perform an opac search and select records with 655 field, select record and review details page. 5) Check that 655 field is clickable. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. 655 field clickable Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Winona! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #11 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org