[Bug 38978] New: [24.05.x] Can't hide column in holdings table from Table settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 Bug ID: 38978 Summary: [24.05.x] Can't hide column in holdings table from Table settings Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1. In 24.05.x, hide some columns via Table settings. 2. The columns do not hide properly, you cannot hide any columns via Table settings on this table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- It seems to be the update_columns_visibility function, it is hiding columns without data but ignoring those configured via column settings. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177204&action=edit Bug 38978: [24.05.x] Fix update_columns_visibility to check table settings To test: 1. In 24.05.x, hide some columns via Table settings. 2. The columns do not hide properly, you cannot hide any columns via Table settings on this table. 3. APPLY PATCH 4. Check hiding columns now, it should work. 5. Make sure that columns with no data at all are still hidden. 6. Enable 'SeparateHoldings' and make sure you can also properly hide columns in the Other holdings table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Main |24.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I had a go at testing, but the patch doesn't seem to work for me. I can replicate the issue. However, after applying the patch the columns are not hiding correctly for me. Using KTD: 1. Koha codebase: git checkout 24.05.x 2. KTD: - Change .env file: KOHA_IMAGE=24.05 - Update images: ktd pull - Start up KTD: ktd up 3. Apply the patch, restart everything (restart_all), and clear browser cache. 4. View record 262 (Programming Perl). 5. Default columns shown (holdings_issues, holdings_renewals, and holdings_localuse are selected in the "Is hidden by default" for table settings): - Tick box - Item type - Current library - Home library - Collection - Status - Last seen - Checkouts (is showing even though holdings_issues is hidden by default) - Renewals (is showing even though holdings_renewals is hidden by default) - Barcode - Actions column 6. Hide "Last seen" and "Barcode" (Table id: holdings_table). 7. Columns now shown: - Tick box - Item type - Current library - Home library - Collection - Status --> Last seen: still shown - Checkouts --> Renewals: no longer shown --> Barcode: still shown - Actions column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37954 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 Angela Berrett <angela.berrett@familysearch.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.berrett@familysearch | |.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Thanks David. I see, we don't have bKohaColumnsUseNames in main anymore but have it in 24.05.x, so this is accounting for missing columns. Reverting Bug 38118 solves the Table settings not working, but it brings back the bug describe there. Going to need a solution here that uses bKohaColumnsUseNames. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177204|0 |1 is obsolete| | --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177205&action=edit Bug 38978: [24.05.x] Don't show every column initially To test: 1. In 24.05.x, hide some columns via Table settings. 2. The columns do not hide properly, you cannot hide any columns via Table settings on this table. 3. APPLY PATCH 4. Check hiding columns now, it should work. 5. Make sure that columns with no data at all are still hidden. 6. Enable 'SeparateHoldings' and make sure you can also properly hide columns in the Other holdings table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Note to testers: Ensure the test plans from Bug 38240 and Bug 38118 still work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 Imani <imani.thomas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |imani.thomas@bywatersolutio | |ns.com --- Comment #7 from Imani <imani.thomas@bywatersolutions.com> --- changes work as intended for http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=312&searchid=scs_1738080254469 internal admin page but I am seeing blank columns after applying the patch at http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=312 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 Imani <imani.thomas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Imani <imani.thomas@bywatersolutions.com> --- disregard that previous comment. it was a mistake in my system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 Imani <imani.thomas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 Imani <imani.thomas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177205|0 |1 is obsolete| | --- Comment #9 from Imani <imani.thomas@bywatersolutions.com> --- Created attachment 177287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177287&action=edit Bug 38978: [24.05.x] Don't show every column initially To test: 1. In 24.05.x, hide some columns via Table settings. 2. The columns do not hide properly, you cannot hide any columns via Table settings on this table. 3. APPLY PATCH 4. Check hiding columns now, it should work. 5. Make sure that columns with no data at all are still hidden. 6. Enable 'SeparateHoldings' and make sure you can also properly hide columns in the Other holdings table. Signed-off-by: Imani Thomas <imani.thomas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Fixing those bugs in version < 24.11 is almost impossible. You can go with this, but you will have other weird behaviours that are certainly fixed in main. For instance here, if you have a column A with (item1=aaa, item2=aaaa, item3=aaaaa), then a column B (with item1,2,3 empty and item 4=bbb) Then global filter using aaa will remove the column B because all empty. If you clear the global filter the column B will stay empty. This certainly also appears when you change page. Example: https://snipboard.io/PaXHmW.jpg https://snipboard.io/lUVKHa.jpg https://snipboard.io/MvDjUu.jpg I am not blocking here, but I let you chose which bug is the worst :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #10)
Fixing those bugs in version < 24.11 is almost impossible.
Why impossible? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Lucas Gass (lukeg) from comment #11)
(In reply to Jonathan Druart from comment #10)
Fixing those bugs in version < 24.11 is almost impossible.
Why impossible?
This area moved a lot, we there were several follow-ups to fix different bugs on this specific page. As you can see in my previous comment your patch introduced another bug, which is fixed in the next version. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 karie.straube@yavapaiaz.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karie.straube@yavapaiaz.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 mteal@greenvillelibrary.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mteal@greenvillelibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |m.de.rooy@rijksmuseum.nl --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looks like In Discussion? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 Kristi <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g --- Comment #14 from Kristi <kkrueger@cuyahogalibrary.org> --- Hoping we will be able to reliably hide columns in the item holdings again soon. On most monitors, showing all the additional columns requires horizontal scrolling that cataloging staff would like to avoid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina@bywatersolutions.co | |m --- Comment #15 from Catrina Berka <catrina@bywatersolutions.com> --- I'm with Kristi - I hope that there's discussion on moving this forward because the loss of being able to hide columns on large tables is a big pain. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Chip.Halvorsen@WestlakeLibr | |ary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 Angela Berrett <angela.berrett@familysearch.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|angela.berrett@familysearch | |.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lucas@bywatersolutions.com |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Why is this in discussion? What is being discussed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 --- Comment #17 from Catrina Berka <catrina@bywatersolutions.com> --- Also chiming in - what's the question in discussion here? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- 24.05 is not longer maintained. Do you have this problem in more recent versions of Koha? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org