[Bug 18760] New: printable checkin alerts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760 Bug ID: 18760 Summary: printable checkin alerts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: gaetan.boisson@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Our options right now to display messages at check in are as follow : - put a note in itemnotes, which will display in red in the checked in items table - write something in materials, which will display a proper alert, but dedicated to accompanying materials A new feature is on the way to allow patrons to write notes themselves, on a specific issue but not on the item if i understood correctly, that's bug 14224. This feature will create a new field in the items table: checkin_alert, to allow librarians to have arbitrary alerts displaying at checkin. These alerts will be printable. Use case: the item is an ILL item, and when checking it back in, the librarian wants to have a printed slip with the address of the partner library the item should be sent back to. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com Assignee|koha-bugs@lists.koha-commun |alex.arnaud@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760 --- Comment #1 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 64256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64256&action=edit Bug 18760 - Add item printable checkin alert field Test plan: - Apply this patch(es), - update databases, - launch misc/devel/update_dbix_class_files.pl, - edit an item to have html or text content in chekin_alert (may need a koha to marc mapping for gui edition), - check out this item, - check it in: you should get a modal showing the alert, - check that you can print the alert. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 64256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64256 Bug 18760 - Add item printable checkin alert field Review of attachment 64256: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18760&attachment=64256) ----------------------------------------------------------------- Hi, I took a look at these patches, I agree a per item check-in note could be quite useful. But I have found some issues with the patch and have some concerns: For the existing patch, see the splinter review notes and below: - Changes to kohastructure.sql are missing. - SQL should use AFTER/BEFORE to make sure the column is always added in the same spot. General concern: In MARC21 there is only one unmapped subfield left: $k To prevent people from unmapping important things and make this feature discoverable, we should at least provide a default mapping for new installations and a note for existing ones if $k (or UNIMARC equivalent) is already mapped. But that makes me think: I wonder if this should really be part of the MARC record or if it wouldn't be better to have these kinds of notes in a separate table, manageable outside of the item editor. Example: What if we'd like to have another note for check-out? - We are running out of unused subfields. - There is a possible privavy issue, because as soon as you add a Koha-to-MARC-mapping, the note field will be searchable in the OPAC (existing problem with itemnotes_nonpublic). - Also, it will get exported with the MARC exports and be visible on the MARC view if not set up correctly (given that the visibility settings now work correctly) Maybe something to be discussed some more. ::: circ/print-alert.pl @@ +1,4 @@
+#!/usr/bin/perl + + +# Copyright 2008 LibLime
Copy and paste error? @@ +18,5 @@
+# You should have received a copy of the GNU General Public License +# along with Koha; if not, see <http://www.gnu.org/licenses>. + +use strict; +#use warnings; FIXME - Bug 2505
Should be Modern::Perl instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Also missing changes to deleted_items! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64256|0 |1 is obsolete| | --- Comment #4 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 67185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67185&action=edit Bug 18760 - Add item printable checkin alert field Test plan: - Apply this patch(es), - update databases, - launch misc/devel/update_dbix_class_files.pl, - edit an item to have html or text content in chekin_alert (may need a koha to marc mapping for gui edition), - check out this item, - check it in: you should get a modal showing the alert, - check that you can print the alert. Test plan #1: - Create a koha to marc mapping for the column checkin alert, - import an item with a checkin alert message, - check that the mapping is done -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Alex Arnaud <alex.arnaud@biblibre.com> --- The last replacement patch fix Katrin's QA comment. Also i created a default mapping for MARC21 and UNIMARC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |alexbuckley@catalyst.net.nz --- Comment #6 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Alex Following the first test plan in comment 4 I notice that when you click to edit an item the checkin alert input is empty even if you have entered a checkn alert. And then when you checkout and then checkin an item no alert modal box is displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The mapping for UNIMARC is wrong - 952 vs 995. I am still not in favour of using our last available mapping for this, I think having a separate note storage (outside MARC) would be better for the future. But this is something more people should give their opinion on, not just me :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19360 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13937 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|printable checkin alerts |Printable checkin alerts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 174452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174452&action=edit Bug 18760: Add item printable checkin alert field Test plan: - Apply this patch(es), - update databases, - launch misc/devel/update_dbix_class_files.pl, - edit an item to have html or text content in chekin_alert (may need a koha to marc mapping for gui edition), - check out this item, - check it in: you should get a modal showing the alert, - check that you can print the alert. Test plan #1: - Create a koha to marc mapping for the column checkin alert, - import an item with a checkin alert message, - check that the mapping is done -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Attachment #67185|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Here is an updated version. Added API part Perl script renamed printalert.pl to be like printalert.tt printalert.tt updated to look like printslip.tt A set to assigned because needs some rework before re-proposing for signoff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- This allows adding HTML that will be used "raw" in staff interface, so there may be a security pb. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org