http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 41420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41420&action=edit Bug 14660: Fix stocknumberAV.pl catalguing plugin The cataloguing plugin stocknumberAV.pl is broken and no longer generating numbers - this patch fixes it. To test: - Link a subfield to the plugin - usually it's 952$i or the UNIMARC equivalent in your MARC frameworks - Set up a new authorised value INVENTORY, the code is an uppercase prefix - "B" - The Descriptions is your starting number - 1 - The OPAC description remains empty - Catalalog an item - Enter B as stocknumber and activate the plugin by clicking on ... at the end of the field - The number will not get added - Firebug shows an error: Undefined subroutine CGI::output_html_with_http_headers - Apply patch - Verify numbers are now generated and no errors are shown -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 41421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41421&action=edit Bug 14660: Fix stocknumberam123.pl catalguing plugin The cataloguing plugin stocknumberam123.pl is broken and no longer generating numbers - this patch fixes it. To test: - Link a subfield to the plugin - usually it's 952$i or the UNIMARC equivalent in your MARC frameworks - Create a new item, set the inventory number to: A 0000000002 - Start to catalog another item, enter A into inventory and - Enter A as stocknumber and activate the plugin by clicking on ... at the end of the field - The number will not get added - Firebug shows an error: Undefined subroutine CGI::output_html_with_http_headers - Apply patch - Verify numbers are now generated and no errors are shown -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41420|0 |1 is obsolete| | Attachment #41421|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 41422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41422&action=edit Bug 14660: Fix stocknumberAV.pl cataloguing plugin The cataloguing plugin stocknumberAV.pl is broken and no longer generating numbers - this patch fixes it. To test: - Link a subfield to the plugin - usually it's 952$i or the UNIMARC equivalent in your MARC frameworks - Set up a new authorised value INVENTORY, the code is an uppercase prefix - "B" - The Descriptions is your starting number - 1 - The OPAC description remains empty - Catalalog an item - Enter B as stocknumber and activate the plugin by clicking on ... at the end of the field - The number will not get added - Firebug shows an error: Undefined subroutine CGI::output_html_with_http_headers - Apply patch - Verify numbers are now generated and no errors are shown -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 41427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41427&action=edit Bug 14660: Fix stocknumberam123.pl cataloguing plugin The cataloguing plugin stocknumberam123.pl is broken and no longer generating numbers - this patch fixes it. To test: - Link a subfield to the plugin - usually it's 952$i or the UNIMARC equivalent in your MARC frameworks - Create a new item, set the inventory number to: A 0000000002 - Start to catalog another item, enter A into inventory and - Enter A as stocknumber and activate the plugin by clicking on ... at the end of the field - The number will not get added - Firebug shows an error: Undefined subroutine CGI::output_html_with_http_headers - Apply patch - Verify numbers are now generated and no errors are shown Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- % grep -Hl output_ `grep -RL 'C4::Output' cataloguing/value_builder` cataloguing/value_builder/callnumber.pl cataloguing/value_builder/unimarc_field_010.pl cataloguing/value_builder/stocknumberAV.pl cataloguing/value_builder/stocknumberam123.pl cataloguing/value_builder/callnumber-KU.pl Some others exist. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41426|0 |1 is obsolete| | Attachment #41427|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41651&action=edit Bug 14660: Fix stocknumberAV.pl cataloguing plugin The cataloguing plugin stocknumberAV.pl is broken and no longer generating numbers - this patch fixes it. To test: - Link a subfield to the plugin - usually it's 952$i or the UNIMARC equivalent in your MARC frameworks - Set up a new authorised value INVENTORY, the code is an uppercase prefix - "B" - The Descriptions is your starting number - 1 - The OPAC description remains empty - Catalalog an item - Enter B as stocknumber and activate the plugin by clicking on ... at the end of the field - The number will not get added - Firebug shows an error: Undefined subroutine CGI::output_html_with_http_headers - Apply patch - Verify numbers are now generated and no errors are shown Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41653&action=edit Bug 14660: Fix 3 other cataloguing plugins These 3 should use C4::Output not to explode. Test plan: Link the plugins with the correct fields They should not log an error when calling them Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Increasing the severity to major. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Katrina and Jonathan! -- You are receiving this mail because: You are watching all bug changes.