[Bug 14644] New: SIP2 terminal authentication via telnet transport broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Bug ID: 14644 Summary: SIP2 terminal authentication via telnet transport broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: gmcharlt@gmail.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com The removal of C4::SIP::Sip::Configuration::* in bug 13506 did not reach all of the code that was using those classes. In particular, the telnet transport expects to compare the password supplied by the client with the password in the SIP configuration, and at the moment attempts to use the object method ->password() that was previously supplied by C4::SIP::Sip::Configuration::Account. Since that method no longer exists, what happens is that the SIPServer backend crashes and aborts the connection if the client attempts to log in via the telnet transport. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |gmcharlt@gmail.com |ity.org | Keywords| |regression -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 --- Comment #1 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 41359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41359&action=edit Bug 14644: unbreak SIP2 terminal login when using telnet transport This patch fixes breakage introduced by the patch for bug 13506 that prevented SIP2 clients from authenticating themselves over the telnet transport. Attempts to do so would manifest by the SIPServer backend crashing and the connection getting closed. To test: [1] Use the stock SIPServer config, etc/SIPconfig.xml, and ensure that the database contains a staff user whose username is 'term1' and password is 'term1' that has the circulate permission. [2] Start SIPServer, telnet to port 8023, and attempt to log in. The connection will be aborted: $ telnet localhost 8023 Trying 127.0.0.1... Connected to localhost. Escape character is '^]'. login: term1 password: term1 Connection closed by foreign host. [3] Apply the patch and restart SIPSever, then repeat step 2. This time, the login should succeed: $ telnet localhost 8023 Trying 127.0.0.1... Connected to localhost. Escape character is '^]'. login: term1 password: term1 Login OK. Initiating SIP Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Agnes Rivers-Moore <arm@hanover.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm@hanover.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41359|0 |1 is obsolete| | --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 41373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41373&action=edit Signed Off patch Signed off - works as described -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41373|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41657&action=edit Bug 14644: unbreak SIP2 terminal login when using telnet transport This patch fixes breakage introduced by the patch for bug 13506 that prevented SIP2 clients from authenticating themselves over the telnet transport. Attempts to do so would manifest by the SIPServer backend crashing and the connection getting closed. To test: [1] Use the stock SIPServer config, etc/SIPconfig.xml, and ensure that the database contains a staff user whose username is 'term1' and password is 'term1' that has the circulate permission. [2] Start SIPServer, telnet to port 8023, and attempt to log in. The connection will be aborted: $ telnet localhost 8023 Trying 127.0.0.1... Connected to localhost. Escape character is '^]'. login: term1 password: term1 Connection closed by foreign host. [3] Apply the patch and restart SIPSever, then repeat step 2. This time, the login should succeed: $ telnet localhost 8023 Trying 127.0.0.1... Connected to localhost. Escape character is '^]'. login: term1 password: term1 Login OK. Initiating SIP Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13506 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Should be backported to 3.20.x. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13506 [Bug 13506] Sip/Configuration/*.pm classes are unused -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Galen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.3 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org